* [PATCH] Drivers: hv: vmbus: Fix the misplaced function description
@ 2024-08-01 21:22 Roman Kisel
2024-08-02 15:51 ` Michael Kelley
0 siblings, 1 reply; 3+ messages in thread
From: Roman Kisel @ 2024-08-01 21:22 UTC (permalink / raw)
To: kys, haiyangz, wei.liu, decui, sashal, linux-hyperv, linux-kernel
Cc: apais, benhill, ssengar, sunilmut, vdso
When hv_synic_disable_regs was introduced, it received the description
of hv_synic_cleanup. Fix that.
Fixes: dba61cda3046 ("Drivers: hv: vmbus: Break out synic enable and disable operations")
Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
---
drivers/hv/hv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index e0d676c74f14..36d9ba097ff5 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -342,9 +342,6 @@ int hv_synic_init(unsigned int cpu)
return 0;
}
-/*
- * hv_synic_cleanup - Cleanup routine for hv_synic_init().
- */
void hv_synic_disable_regs(unsigned int cpu)
{
struct hv_per_cpu_context *hv_cpu =
@@ -436,6 +433,9 @@ static bool hv_synic_event_pending(void)
return pending;
}
+/*
+ * hv_synic_cleanup - Cleanup routine for hv_synic_init().
+ */
int hv_synic_cleanup(unsigned int cpu)
{
struct vmbus_channel *channel, *sc;
base-commit: 831bcbcead6668ebf20b64fdb27518f1362ace3a
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] Drivers: hv: vmbus: Fix the misplaced function description
2024-08-01 21:22 [PATCH] Drivers: hv: vmbus: Fix the misplaced function description Roman Kisel
@ 2024-08-02 15:51 ` Michael Kelley
2024-08-03 0:13 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2024-08-02 15:51 UTC (permalink / raw)
To: Roman Kisel, kys@microsoft.com, haiyangz@microsoft.com,
wei.liu@kernel.org, decui@microsoft.com, sashal@kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: apais@microsoft.com, benhill@microsoft.com, ssengar@microsoft.com,
sunilmut@microsoft.com, vdso@hexbites.dev
From: Roman Kisel <romank@linux.microsoft.com> Sent: Thursday, August 1, 2024 2:23 PM
>
> When hv_synic_disable_regs was introduced, it received the description
> of hv_synic_cleanup. Fix that.
>
> Fixes: dba61cda3046 ("Drivers: hv: vmbus: Break out synic enable and disable
> operations")
>
> Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
> ---
> drivers/hv/hv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index e0d676c74f14..36d9ba097ff5 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -342,9 +342,6 @@ int hv_synic_init(unsigned int cpu)
> return 0;
> }
>
> -/*
> - * hv_synic_cleanup - Cleanup routine for hv_synic_init().
> - */
> void hv_synic_disable_regs(unsigned int cpu)
> {
> struct hv_per_cpu_context *hv_cpu =
> @@ -436,6 +433,9 @@ static bool hv_synic_event_pending(void)
> return pending;
> }
>
> +/*
> + * hv_synic_cleanup - Cleanup routine for hv_synic_init().
> + */
> int hv_synic_cleanup(unsigned int cpu)
> {
> struct vmbus_channel *channel, *sc;
>
> base-commit: 831bcbcead6668ebf20b64fdb27518f1362ace3a
> --
> 2.34.1
>
Reviewed-by: Michael Kelley <mhkelley@outlook.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Drivers: hv: vmbus: Fix the misplaced function description
2024-08-02 15:51 ` Michael Kelley
@ 2024-08-03 0:13 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2024-08-03 0:13 UTC (permalink / raw)
To: Michael Kelley
Cc: Roman Kisel, kys@microsoft.com, haiyangz@microsoft.com,
wei.liu@kernel.org, decui@microsoft.com, sashal@kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
apais@microsoft.com, benhill@microsoft.com, ssengar@microsoft.com,
sunilmut@microsoft.com, vdso@hexbites.dev
On Fri, Aug 02, 2024 at 03:51:37PM +0000, Michael Kelley wrote:
> From: Roman Kisel <romank@linux.microsoft.com> Sent: Thursday, August 1, 2024 2:23 PM
> >
> > When hv_synic_disable_regs was introduced, it received the description
> > of hv_synic_cleanup. Fix that.
> >
> > Fixes: dba61cda3046 ("Drivers: hv: vmbus: Break out synic enable and disable
> > operations")
> >
> > Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
> > ---
> > drivers/hv/hv.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > index e0d676c74f14..36d9ba097ff5 100644
> > --- a/drivers/hv/hv.c
> > +++ b/drivers/hv/hv.c
> > @@ -342,9 +342,6 @@ int hv_synic_init(unsigned int cpu)
> > return 0;
> > }
> >
> > -/*
> > - * hv_synic_cleanup - Cleanup routine for hv_synic_init().
> > - */
> > void hv_synic_disable_regs(unsigned int cpu)
> > {
> > struct hv_per_cpu_context *hv_cpu =
> > @@ -436,6 +433,9 @@ static bool hv_synic_event_pending(void)
> > return pending;
> > }
> >
> > +/*
> > + * hv_synic_cleanup - Cleanup routine for hv_synic_init().
> > + */
> > int hv_synic_cleanup(unsigned int cpu)
> > {
> > struct vmbus_channel *channel, *sc;
> >
> > base-commit: 831bcbcead6668ebf20b64fdb27518f1362ace3a
> > --
> > 2.34.1
> >
>
> Reviewed-by: Michael Kelley <mhkelley@outlook.com>
>
Applied to hyperv-fixes. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-03 0:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 21:22 [PATCH] Drivers: hv: vmbus: Fix the misplaced function description Roman Kisel
2024-08-02 15:51 ` Michael Kelley
2024-08-03 0:13 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).