From: Naman Jain <namjain@linux.microsoft.com>
To: "K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
Naman Jain <namjain@linux.microsoft.com>,
John Starks <jostarks@microsoft.com>,
jacob.pan@linux.microsoft.com,
Easwar Hariharan <eahariha@linux.microsoft.com>
Subject: [PATCH 2/2] Drivers: hv: vmbus: Log on missing offers
Date: Fri, 18 Oct 2024 04:58:11 -0700 [thread overview]
Message-ID: <20241018115811.5530-3-namjain@linux.microsoft.com> (raw)
In-Reply-To: <20241018115811.5530-1-namjain@linux.microsoft.com>
From: John Starks <jostarks@microsoft.com>
When resuming from hibernation, log any channels that were present
before hibernation but now are gone.
Signed-off-by: John Starks <jostarks@microsoft.com>
Co-developed-by: Naman Jain <namjain@linux.microsoft.com>
Signed-off-by: Naman Jain <namjain@linux.microsoft.com>
---
drivers/hv/vmbus_drv.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index bd3fc41dc06b..1f56d138210e 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -2462,6 +2462,7 @@ static int vmbus_bus_suspend(struct device *dev)
static int vmbus_bus_resume(struct device *dev)
{
+ struct vmbus_channel *channel;
struct vmbus_channel_msginfo *msginfo;
size_t msgsize;
int ret;
@@ -2494,6 +2495,21 @@ static int vmbus_bus_resume(struct device *dev)
vmbus_request_offers();
+ mutex_lock(&vmbus_connection.channel_mutex);
+ list_for_each_entry(channel, &vmbus_connection.chn_list, listentry) {
+ if (channel->offermsg.child_relid != INVALID_RELID)
+ continue;
+
+ /* hvsock channels are not expected to be present. */
+ if (is_hvsock_channel(channel))
+ continue;
+
+ pr_err("channel %pUl/%pUl not present after resume.\n",
+ &channel->offermsg.offer.if_type,
+ &channel->offermsg.offer.if_instance);
+ }
+ mutex_unlock(&vmbus_connection.channel_mutex);
+
/* Reset the event for the next suspend. */
reinit_completion(&vmbus_connection.ready_for_suspend_event);
--
2.34.1
next prev parent reply other threads:[~2024-10-18 11:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 11:58 [PATCH 0/2] Drivers: hv: vmbus: Wait for offers and log missing offers Naman Jain
2024-10-18 11:58 ` [PATCH 1/2] Drivers: hv: vmbus: Wait for offers during boot Naman Jain
2024-10-18 22:52 ` Easwar Hariharan
2024-10-21 4:33 ` Michael Kelley
2024-10-22 9:50 ` Naman Jain
2024-10-22 18:03 ` Michael Kelley
2024-10-25 18:18 ` Dexuan Cui
2024-10-28 15:21 ` Michael Kelley
2024-10-28 4:54 ` Naman Jain
2024-10-21 4:57 ` Saurabh Singh Sengar
2024-10-22 9:55 ` Naman Jain
2024-10-22 17:38 ` Michael Kelley
2024-10-24 10:32 ` Naman Jain
2024-10-18 11:58 ` Naman Jain [this message]
2024-10-21 2:43 ` [PATCH 2/2] Drivers: hv: vmbus: Log on missing offers Easwar Hariharan
2024-10-21 4:26 ` Saurabh Singh Sengar
2024-10-21 4:31 ` Naman Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018115811.5530-3-namjain@linux.microsoft.com \
--to=namjain@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=jacob.pan@linux.microsoft.com \
--cc=jostarks@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).