From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD461A9B58; Sat, 30 Nov 2024 22:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733004190; cv=none; b=N+3tuAMZNAO6Q+eki6sBtMtoTteTzFC7IIIz5rTOlwZB/9hq60BODymlapsM8Z+Ggo4BJBxMLAdzITL9xJN+rpOX5GHnpioF9xnHo2d4kAsByE+YjSMAR8jxurPFrpoabqUCrrI/zJZgTAD+Jq4PktGhNLWavmS36l4RY6G8dkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733004190; c=relaxed/simple; bh=cSG/0QfMLpGgugGMeoqQy4eeYYHrqIdNNTuEdiWAP5I=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ij4YhsI3bEeMwzGrjTYhoA+w73G/GO/DJ+uAWRPzv4HlTWrj2WdtoG8dkgL6esuvpPKq2gUGJpVB1yXCZwSmOgs7AOEOVLYiBTGwQyqVoSZNLewuBYVpoo4bLZTVPBsvP0X7osWTEQdeGjChUc9PoiUQoJIZZI0DuxBV3szdu58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XGCAkHLz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XGCAkHLz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5CF4C4CED3; Sat, 30 Nov 2024 22:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733004189; bh=cSG/0QfMLpGgugGMeoqQy4eeYYHrqIdNNTuEdiWAP5I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XGCAkHLz5ZE7bU+L+nUBTE0y0OhK/NG1LZg9Y8IgL3INmNXIFelOQTWe1DwnL7rPI 96RS990iYIib072aVevhuqV7G94HejMx3XR84vv8ZodHTN8YOvfe+JSRZc3DpQnBmK ydFPuecmGEZ2XQ+esSJpPSqyrCZySqWU/h0TSp+U6ErP/ZdWqohcaT/n7YcKWx5hyK zLjsBWo0SwzXMDAmPAmeAIi09Nzof2FggkhTZB1UeIH5VJ83XOB59mCfljBWz/5RPe 1Y7oNiJhUadFdYFwVgUCp1Zc08L4Wu4yMDLNQ82/+eQinMA/+vo/suBiOj7k033dPY CBycqzaWSvSCw== Date: Sat, 30 Nov 2024 14:03:07 -0800 From: Jakub Kicinski To: longli@linuxonhyperv.com Cc: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Paolo Abeni , Shradha Gupta , Simon Horman , Konstantin Taranov , Souradeep Chakrabarti , Erick Archer , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Long Li Subject: Re: [PATCH] hv_netvsc: Set device flags for properly indicating bonding Message-ID: <20241130140307.3f0c028c@kernel.org> In-Reply-To: <1732736570-19700-1-git-send-email-longli@linuxonhyperv.com> References: <1732736570-19700-1-git-send-email-longli@linuxonhyperv.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Nov 2024 11:42:50 -0800 longli@linuxonhyperv.com wrote: > hv_netvsc uses a subset of bonding features in that the master always > has only one active slave. But it never properly setup those flags. > > Other kernel APIs (e.g those in "include/linux/netdevice.h") check for > IFF_MASTER, IFF_SLAVE and IFF_BONDING for determing if those are used > in a master/slave setup. I feel like this has been nacked 10 times already? IFF_BONDING means the bonding driver. There is more than one driver in the tree providing link aggregation and only bonding uses IFF_BONDING. If some user is buggy fix the user. -- pw-bot: reject