From: Roman Kisel <romank@linux.microsoft.com>
To: bp@alien8.de, dave.hansen@linux.intel.com, decui@microsoft.com,
haiyangz@microsoft.com, hpa@zytor.com, kys@microsoft.com,
mingo@redhat.com, ssengar@linux.microsoft.com,
tglx@linutronix.de, wei.liu@kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org
Cc: apais@microsoft.com, benhill@microsoft.com,
sunilmut@microsoft.com, vdso@hexbites.dev
Subject: [PATCH hyperv-next 2/2] x86/hyperv: VTL mode callback for restarting the system
Date: Fri, 17 Jan 2025 13:07:02 -0800 [thread overview]
Message-ID: <20250117210702.1529580-3-romank@linux.microsoft.com> (raw)
In-Reply-To: <20250117210702.1529580-1-romank@linux.microsoft.com>
The kernel runs as a firmware in the VTL mode, and the only way
to restart on x86 is to triple fault. Thus, one has to always
supply "reboot=t" on the kernel command line, and missing that
renders rebooting not working.
Define the machine restart callback to always use the triple
fault to provide the robust configuration by default.
Cc: stable@vger.kernel.org
Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
---
arch/x86/hyperv/hv_vtl.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/hyperv/hv_vtl.c b/arch/x86/hyperv/hv_vtl.c
index 8931fc186a5f..eb402362d738 100644
--- a/arch/x86/hyperv/hv_vtl.c
+++ b/arch/x86/hyperv/hv_vtl.c
@@ -44,6 +44,12 @@ static void __noreturn hv_vtl_emergency_restart(void)
}
}
+/* The only way to restart is triple fault */
+static void __noreturn hv_vtl_restart(char *)
+{
+ hv_vtl_emergency_restart();
+}
+
void __init hv_vtl_init_platform(void)
{
pr_info("Linux runs in Hyper-V Virtual Trust Level\n");
@@ -269,6 +275,7 @@ int __init hv_vtl_early_init(void)
apic_update_callback(wakeup_secondary_cpu_64, hv_vtl_wakeup_secondary_cpu);
machine_ops.emergency_restart = hv_vtl_emergency_restart;
+ machine_ops.restart = hv_vtl_restart;
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2025-01-17 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 21:07 [PATCH hyperv-next 0/2] x86/hyperv: VTL mode reboot fixes Roman Kisel
2025-01-17 21:07 ` [PATCH hyperv-next 1/2] x86/hyperv: VTL mode emergency restart callback Roman Kisel
2025-01-17 21:07 ` Roman Kisel [this message]
2025-01-18 16:19 ` [PATCH hyperv-next 2/2] x86/hyperv: VTL mode callback for restarting the system kernel test robot
2025-02-12 2:21 ` [PATCH hyperv-next 0/2] x86/hyperv: VTL mode reboot fixes Wei Liu
2025-02-12 17:54 ` Saurabh Singh Sengar
2025-02-12 22:56 ` Roman Kisel
2025-02-13 10:52 ` Saurabh Singh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117210702.1529580-3-romank@linux.microsoft.com \
--to=romank@linux.microsoft.com \
--cc=apais@microsoft.com \
--cc=benhill@microsoft.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ssengar@linux.microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vdso@hexbites.dev \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).