linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Kisel <romank@linux.microsoft.com>
To: eahariha@linux.microsoft.com, mhklinux@outlook.com,
	kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
	decui@microsoft.com, James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, linux-hyperv@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: apais@microsoft.com, benhill@microsoft.com, sunilmut@microsoft.com
Subject: [PATCH hyperv-next v2 1/1] scsi: storvsc: Don't report the host packet status as the hv status
Date: Mon,  3 Mar 2025 16:09:40 -0800	[thread overview]
Message-ID: <20250304000940.9557-2-romank@linux.microsoft.com> (raw)
In-Reply-To: <20250304000940.9557-1-romank@linux.microsoft.com>

The log statement reports the packet status code as the hv
status code which causes confusion when debugging as "hv"
might refer to a hypervisor, and sometimes to the host part
of the Hyper-V virtualization stack.

Fix the name of the datum being logged to clearly indicate
the component reporting the error. Also log it in hexadecimal
everywhere for consistency.

Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
---
 drivers/scsi/storvsc_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index a8614e54544e..35db061ae3ec 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -776,7 +776,7 @@ static void  handle_multichannel_storage(struct hv_device *device, int max_chns)
 
 	if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
 	    vstor_packet->status != 0) {
-		dev_err(dev, "Failed to create sub-channel: op=%d, sts=%d\n",
+		dev_err(dev, "Failed to create sub-channel: op=%d, host=0x%x\n",
 			vstor_packet->operation, vstor_packet->status);
 		return;
 	}
@@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device,
 			STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR;
 
 		storvsc_log_ratelimited(device, loglevel,
-			"tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n",
+			"tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x host 0x%x\n",
 			scsi_cmd_to_rq(request->cmd)->tag,
 			stor_pkt->vm_srb.cdb[0],
 			vstor_packet->vm_srb.scsi_status,
-- 
2.43.0


  reply	other threads:[~2025-03-04  0:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04  0:09 [PATCH hyperv-next v2 0/1] scsi: storvsc: Don't report the host packet status as the hv status Roman Kisel
2025-03-04  0:09 ` Roman Kisel [this message]
2025-03-04  4:06   ` [PATCH hyperv-next v2 1/1] " Easwar Hariharan
2025-03-04  4:21   ` Michael Kelley
2025-03-11  1:19   ` Martin K. Petersen
2025-03-18  0:54 ` [PATCH hyperv-next v2 0/1] " Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250304000940.9557-2-romank@linux.microsoft.com \
    --to=romank@linux.microsoft.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=apais@microsoft.com \
    --cc=benhill@microsoft.com \
    --cc=decui@microsoft.com \
    --cc=eahariha@linux.microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mhklinux@outlook.com \
    --cc=sunilmut@microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).