From: Jason Gunthorpe <jgg@ziepe.ca>
To: longli@linuxonhyperv.com
Cc: Leon Romanovsky <leon@kernel.org>,
Konstantin Taranov <kotaranov@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
Long Li <longli@microsoft.com>
Subject: Re: [patch rdma-next v3 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu
Date: Wed, 5 Mar 2025 14:50:52 -0400 [thread overview]
Message-ID: <20250305185052.GA354403@ziepe.ca> (raw)
In-Reply-To: <1741132802-26795-1-git-send-email-longli@linuxonhyperv.com>
On Tue, Mar 04, 2025 at 04:00:01PM -0800, longli@linuxonhyperv.com wrote:
>
> -struct net_device *mana_get_primary_netdev_rcu(struct mana_context *ac, u32 port_index)
> +struct net_device *mana_get_primary_netdev(struct mana_context *ac, u32 port_index)
> {
> struct net_device *ndev;
>
> - RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
> - "Taking primary netdev without holding the RCU read lock");
> if (port_index >= ac->num_ports)
> return NULL;
>
> + rcu_read_lock();
> +
> /* When mana is used in netvsc, the upper netdevice should be returned. */
> if (ac->ports[port_index]->flags & IFF_SLAVE)
> ndev = netdev_master_upper_dev_get_rcu(ac->ports[port_index]);
> else
> ndev = ac->ports[port_index];
>
> + dev_hold(ndev);
> + rcu_read_unlock();
That's much better, yes
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
prev parent reply other threads:[~2025-03-05 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 0:00 [patch rdma-next v3 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu longli
2025-03-05 0:00 ` [patch rdma-next v3 2/2] RDMA/mana_ib: Handle net event for pointing to the current netdev longli
2025-03-05 1:28 ` [patch rdma-next v3 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu Jakub Kicinski
2025-03-05 4:28 ` [EXTERNAL] " Long Li
2025-03-05 18:50 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305185052.GA354403@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).