From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 205E61C84B4 for ; Wed, 5 Mar 2025 18:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741200656; cv=none; b=FmMepmTd+cqdqMvivCLhvHA4n4gchwBtJBv1OgVHzzfrQum/OlbZDepfh/Zr6sIuqgTDLYlr2iC8//4RXY8xY5m9KbOrODEQcoNe1+LWs4ndHoAH+OkW3cONWCowhe07S86IsqA8pLM6+RouX+tzbvGUj0Snsw6M7JjgYIHuyHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741200656; c=relaxed/simple; bh=QbaAYVsuHtR4sFbwYlItPyeMtj1+0TldiW7il+PRxZc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TxOGZhqfTyPgh2C3Fu6WYQarsUJDcY3Ltxicr32wNIKLLjUML8gWUC66tMNmuC8wUPsG/9xJxD4ngz8CgDmZGCLnX6iC8QQbiQxrPok3RKXy827ESXYMWceQLHsBtxKEAnq0/HBWxUwF/7s7WGE+vBeoqEA1U8jdjgKWoB8VQGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=YdKISRre; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YdKISRre" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6e41e18137bso56188866d6.1 for ; Wed, 05 Mar 2025 10:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1741200654; x=1741805454; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z7/tB8dYiu5A38nEKy58/W/Pt5oX/QvBFHO/wQ46XSc=; b=YdKISRre2vQzP5L91LnjrMPLlIWIMUyv0FCKNrb8H8ZEwRFG3hWoxi3tw6UQImAN8P dC2T8/fDqHcn71EDd95kew5KAHCLbRwWCmexzmO8KLYbo76tEQX/rL+/kFE13HKznSXJ VPIvClo7wJ+3I28B+lVMxtM19Ei0Rhm8tDZojPF9tqbMc+e8OOrMiHTNSgHxNPlw5Rxr Vy16yI2bw8ut1ptKtqydSYdWwQSjMtnzG3m6YpR914NO6TEEAmife16dDa1QUsA40Exw D+fz4MvGGySafE1nvAuaB1u0tWCggL2iFCW27B0Lh86hakThRBKcKgstH3wz4mk1Bz2X HM/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741200654; x=1741805454; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z7/tB8dYiu5A38nEKy58/W/Pt5oX/QvBFHO/wQ46XSc=; b=LieFG2oMIqbnS16nsioYX9vOtGHuGTBesTFTpgmaxDRaPyZ7026yE559dMXkiDz/1X D34pAv7jE/p79pL8xK52unOaxmjULQdY/nXNozqRt7p3zwY/QhPRc4YZSp5TMgHTZC7t MK2UqRXfnqE+0v8sEnuNVZbZ4mjpF/pI0+SXxrEmYS5EI2bo7+ZUWrUhy+Ew0sCWUuZq ylTR/4uqh9PZXLnYFJpof1RvcaZtd/48F1YBadE4RoB9v6yPBVoDQNuebVHFamNrP9Fb khiDXbLgxb5PCrIXcf0Kd/RQeI/AKzj6RjI1+9VKyiHIK5RZffBFXF9kdWCuDTVrE4gV XQ1Q== X-Forwarded-Encrypted: i=1; AJvYcCU94dhj8GwaOUHma++O/biGJKD8baH5+nm5DkMkvuJqwRo9rQ5jxtTXhktXoao7zzH4yHMghs4jZy64tSo=@vger.kernel.org X-Gm-Message-State: AOJu0YxkjCU0BzA+SJ2pKFYdwW55MsNQ8l/sf8Q93H4ZxRHTpT9VZGA8 +/OBZjC4WQw2eQKcMvtoTuhj/NGob+GiZPPjLixnt2CxN305FA0daVx9UbPFrBY= X-Gm-Gg: ASbGnctckPIOK2+mSYTazQ3UZlOnuEqQzMVSadiboTS8nwL1eTEujqiD1N0KmABJry8 lIRCHLV0VX2LkYaAdP5oYR+oWVWRyE1p30JxVmeianU+gz7T+VX550+BWNLTfIqhefwoqnW6m7q FxBjTT3hEPSB2WMc2uM0udDzBx/Cf2S/EBBpK/czSFR2U6vPsSSzQ6hDe7UMJl9C4SzpT1YCaUu fOwN4mWTxwLiibgNRFwxQOiTVihdEi+V5MxGyO/sCTJrS138jmcMLuMSGqqkhd0AAQfi8dSDiuF 5bMnxzfA7gCH5uLO3qlzSlCTOVdF1GOv0KnDQBXq56YS5kkU/t7fVODCjJVNZzKLQlxSKgE2mk1 m3Xpohn5uk1jxPaNzAw== X-Google-Smtp-Source: AGHT+IHBfk4VjAwwmewmwy7/cD04QxrX3NO7CkQZxs6uiHniAKBSHBOE/omselhSlxfJQQW6JbT7mg== X-Received: by 2002:a05:6214:518b:b0:6e6:60f6:56cf with SMTP id 6a1803df08f44-6e8e6cfffa9mr54007756d6.5.1741200653911; Wed, 05 Mar 2025 10:50:53 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e8e8f52086sm10432506d6.63.2025.03.05.10.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 10:50:53 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tptpU-00000001UT9-2uWT; Wed, 05 Mar 2025 14:50:52 -0400 Date: Wed, 5 Mar 2025 14:50:52 -0400 From: Jason Gunthorpe To: longli@linuxonhyperv.com Cc: Leon Romanovsky , Konstantin Taranov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, Long Li Subject: Re: [patch rdma-next v3 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu Message-ID: <20250305185052.GA354403@ziepe.ca> References: <1741132802-26795-1-git-send-email-longli@linuxonhyperv.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1741132802-26795-1-git-send-email-longli@linuxonhyperv.com> On Tue, Mar 04, 2025 at 04:00:01PM -0800, longli@linuxonhyperv.com wrote: > > -struct net_device *mana_get_primary_netdev_rcu(struct mana_context *ac, u32 port_index) > +struct net_device *mana_get_primary_netdev(struct mana_context *ac, u32 port_index) > { > struct net_device *ndev; > > - RCU_LOCKDEP_WARN(!rcu_read_lock_held(), > - "Taking primary netdev without holding the RCU read lock"); > if (port_index >= ac->num_ports) > return NULL; > > + rcu_read_lock(); > + > /* When mana is used in netvsc, the upper netdevice should be returned. */ > if (ac->ports[port_index]->flags & IFF_SLAVE) > ndev = netdev_master_upper_dev_get_rcu(ac->ports[port_index]); > else > ndev = ac->ports[port_index]; > > + dev_hold(ndev); > + rcu_read_unlock(); That's much better, yes Reviewed-by: Jason Gunthorpe Jason