From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Naman Jain <namjain@linux.microsoft.com>
Cc: "K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org, Saurabh Sengar <ssengar@linux.microsoft.com>,
Michael Kelley <mhklinux@outlook.com>
Subject: Re: [PATCH v4 1/2] uio_hv_generic: Fix sysfs creation path for ring buffer
Date: Tue, 15 Apr 2025 18:13:44 +0200 [thread overview]
Message-ID: <2025041556-disburse-tiling-8e72@gregkh> (raw)
In-Reply-To: <20250410060847.82407-2-namjain@linux.microsoft.com>
On Thu, Apr 10, 2025 at 11:38:46AM +0530, Naman Jain wrote:
> + /*
> + * Skip updating the sysfs group if the primary channel is not yet initialized and sysfs
> + * group is not yet created. In those cases, the 'ring' will be created later in
> + * vmbus_device_register() -> vmbus_add_channel_kobj().
> + */
> + if (!primary_channel->device_obj->channels_kset)
> + return 0;
2 spaces after "if"?
Yeah, it's minor, but it made me think that checkpatch had not been run.
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-15 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 6:08 [PATCH v4 0/2] uio_hv_generic: Fix ring buffer sysfs creation path Naman Jain
2025-04-10 6:08 ` [PATCH v4 1/2] uio_hv_generic: Fix sysfs creation path for ring buffer Naman Jain
2025-04-15 15:10 ` Greg Kroah-Hartman
2025-04-15 15:54 ` Naman Jain
2025-04-15 16:14 ` Greg Kroah-Hartman
2025-04-15 16:21 ` Naman Jain
2025-04-15 16:13 ` Greg Kroah-Hartman [this message]
2025-04-10 6:08 ` [PATCH v4 2/2] Drivers: hv: Make the sysfs node size for the ring buffer dynamic Naman Jain
2025-04-15 16:08 ` [PATCH v4 0/2] uio_hv_generic: Fix ring buffer sysfs creation path Michael Kelley
2025-04-15 16:11 ` Naman Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025041556-disburse-tiling-8e72@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=namjain@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=stable@kernel.org \
--cc=stephen@networkplumber.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).