From: Jakub Kicinski <kuba@kernel.org>
To: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
shradhagupta@linux.microsoft.com, ernis@linux.microsoft.com,
dipayanroy@linux.microsoft.com, shirazsaleem@microsoft.com,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ssengar@microsoft.com,
stable@vger.kernel.org
Subject: Re: [PATCH net] net: mana: Remove redundant netdev_lock_ops_to_full() calls
Date: Mon, 25 Aug 2025 17:41:33 -0700 [thread overview]
Message-ID: <20250825174133.30e58c60@kernel.org> (raw)
In-Reply-To: <1756119794-20110-1-git-send-email-ssengar@linux.microsoft.com>
On Mon, 25 Aug 2025 04:03:14 -0700 Saurabh Sengar wrote:
> NET_SHAPER is always selected for MANA driver. When NET_SHAPER is enabled,
> netdev_lock_ops_to_full() reduces effectively to only an assert for lock,
> which is always held in the path when NET_SHAPER is enabled.
>
> Remove the redundant netdev_lock_ops_to_full() call.
>
> Fixes: d5c8f0e4e0cb ("net: mana: Fix potential deadlocks in mana napi ops")
> Cc: stable@vger.kernel.org
If the call is a nop why is this a stable-worthy fix?
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-26 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 11:03 [PATCH net] net: mana: Remove redundant netdev_lock_ops_to_full() calls Saurabh Sengar
2025-08-26 0:41 ` Jakub Kicinski [this message]
2025-08-26 4:57 ` Saurabh Singh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825174133.30e58c60@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=dipayanroy@linux.microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shirazsaleem@microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox