From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0BB29B781; Thu, 11 Sep 2025 07:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757576905; cv=none; b=GGYUnQsENij8Z86DSTMIXyMU37mJIdpMQH2BLUeFmHwULNrEd+RIvyKTGanr+KRAGasBQi/Q494j2HOrkJeAzrEgvBxsdZoRYjz/vZjv4v/OYAB9HrQYJzX87rSUmYaQgZFzhNO/xwzv7hi0GFbV272irjtmMzECpBMsEtiLhds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757576905; c=relaxed/simple; bh=jbEyhSiC8FqnzGUnmdJ4vWD227e0EMZTC6+/lryewqQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=akVb0uhoeWRbFZJbMt4vvIqHYCKwPjy904FLqkAvshRjY1jYe5AMLiHMjR+MOeLP0vsfZgSp3lO7fJJTAdpaXa80SkYgPzezEFpX270He7y5F4jSK/QxsbBQy9+dqONb/RZB24EdnJmcOMhdfjSHrEaQ/I9dqTqEOw3fK7q3fUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=dtblvupK; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dtblvupK" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=U+zkD5dacXBFakf/sW3Py81BzX7lYGPL/ab+J9kqcdg=; b=dtblvupKAE3nc1oFdtwVOyBn3s qQ9tg0VGEhHjuvKxZPxfRVF1cTfkYKjF/W+AwWB9diArBmEmm4Dfo/ILIs3e5rJ0/5KaZpD3GXmSB FXefRy7svN0YXAcrJjt3YWye+YQ0estPxRI2xQMCbC1bD6yN7dw1arYZpKy1e4xQQe5ML0VNUdNJ6 l9DNs+IDKPtEAflAFtb2KKgqBAU6H0+mqP50MZicIma2XhWBmW8XqC9xgjm0J59fHbnEejWLv453P A5qAXgvCLf5WM5s8aYtSUlvD3Wo8lQJQjAVyBBEA0NVxt9BfNlALxdh71F7ssGPRshV9k2rEF5ICR L5NHqPpQ==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwc2U-000000062CS-27zT; Thu, 11 Sep 2025 07:48:18 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 455AE3002EB; Thu, 11 Sep 2025 09:48:17 +0200 (CEST) Date: Thu, 11 Sep 2025 09:48:17 +0200 From: Peter Zijlstra To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Will Deacon , Boqun Feng , Waiman Long , Jiri Kosina , Josh Poimboeuf , Pawan Gupta , Boris Ostrovsky , xen-devel@lists.xenproject.org, Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Russell King , Catalin Marinas , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-arm-kernel@lists.infradead.org, Paolo Bonzini , Vitaly Kuznetsov , Stefano Stabellini , Oleksandr Tyshchenko , Daniel Lezcano Subject: Re: [PATCH 00/14] paravirt: cleanup and reorg Message-ID: <20250911074817.GX3245006@noisy.programming.kicks-ass.net> References: <20250911063433.13783-1-jgross@suse.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250911063433.13783-1-jgross@suse.com> On Thu, Sep 11, 2025 at 08:34:19AM +0200, Juergen Gross wrote: > Some cleanups and reorg of paravirt code and headers: > > - The first 2 patches should be not controversial at all, as they > remove just some no longer needed #include and struct forward > declarations. > > - The 3rd patch is removing CONFIG_PARAVIRT_DEBUG, which IMO has > no real value, as it just changes a crash to a BUG() (the stack > trace will basically be the same). As the maintainer of the main > paravirt user (Xen) I have never seen this crash/BUG() to happen. > > - The 4th patch is just a movement of code. > > - I don't know for what reason asm/paravirt_api_clock.h was added, > as all archs supporting it do it exactly in the same way. Patch > 5 is removing it. > > - Patches 6-12 are streamlining the paravirt clock interfaces by > using a common implementation across architectures where possible > and by moving the related code into common sched code, as this is > where it should live. > > - Patches 13+14 are more like RFC material: patch 13 is doing some > preparation work to enable patch 14 to move all spinlock related > paravirt functions into qspinlock.h. If this approach is accepted, > I'd like to continue with this work by moving most (or all?) > paravirt functions from paravirt.h into the headers where their > native counterparts are defined. This is meant to keep the native > and paravirt function definitions together in one place and > hopefully to be able to reduce the include hell with paravirt. > > Juergen Gross (14): > x86/paravirt: remove not needed includes of paravirt.h > x86/paravirt: remove some unneeded struct declarations > x86/paravirt: remove PARAVIRT_DEBUG config option > x86/paravirt: move thunk macros to paravirt_types.h > paravirt: remove asm/paravirt_api_clock.h > sched: move clock related paravirt code to kernel/sched > arm/paravirt: use common code for paravirt_steal_clock() > arm64/paravirt: use common code for paravirt_steal_clock() > loongarch/paravirt: use common code for paravirt_steal_clock() > riscv/paravirt: use common code for paravirt_steal_clock() > x86/paravirt: use common code for paravirt_steal_clock() > x86/paravirt: move paravirt_sched_clock() related code into tsc.c > x86/paravirt: allow pv-calls outside paravirt.h > x86/pvlocks: move paravirt spinlock functions into qspinlock.h With the note that tip typically likes a capital after the prefix, like: x86/paravirt: Remove unneeded includes of paravirt.h For 1-12: Acked-by: Peter Zijlstra (Intel) Now, as to the last two, I'm not sure. Leaking those macros out of PV isn't particularly nice, then again, not the end of the world either. Just not sure.