From: Wei Liu <wei.liu@kernel.org>
To: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
Cc: Roman Kisel <romank@linux.microsoft.com>,
decui@microsoft.com, eahariha@linux.microsoft.com,
haiyangz@microsoft.com, kys@microsoft.com, mhklinux@outlook.com,
nunodasneves@linux.microsoft.com, wei.liu@kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
benhill@microsoft.com, bperkins@microsoft.com,
sunilmut@microsoft.com
Subject: Re: [PATCH hyperv-next] hyperv: Remove the spurious null directive line
Date: Thu, 2 Oct 2025 21:21:48 +0000 [thread overview]
Message-ID: <20251002212148.GB925245@liuwe-devbox-debian-v2.local> (raw)
In-Reply-To: <089d6be9-20be-4985-a761-51bfb9879b92@linux.microsoft.com>
On Thu, Oct 02, 2025 at 09:04:21AM -0700, Easwar Hariharan wrote:
> On 10/1/2025 4:08 PM, Roman Kisel wrote:
> > The file contains a line that consists of the lone # symbol
> > followed by a newline. While that is a valid syntax as
> > defined by the C99+ grammar (6.10.7 "Null directive"), it
> > serves no apparent purpose in this case.
> >
> > Remove the null preprocessor directive. No functional changes.
> >
> > Fixes: e68bda71a238 ("hyperv: Add new Hyper-V headers in include/hyperv")
> > Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
> > ---
> > include/hyperv/hvgdk_mini.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/include/hyperv/hvgdk_mini.h b/include/hyperv/hvgdk_mini.h
> > index 1be7f6a02304..77abddfc750e 100644
> > --- a/include/hyperv/hvgdk_mini.h
> > +++ b/include/hyperv/hvgdk_mini.h
> > @@ -597,8 +597,6 @@ struct ms_hyperv_tsc_page { /* HV_REFERENCE_TSC_PAGE */
> > #define HV_SYNIC_SINT_AUTO_EOI (1ULL << 17)
> > #define HV_SYNIC_SINT_VECTOR_MASK (0xFF)
> >
> > -#
> > -
> > /* Hyper-V defined statically assigned SINTs */
> > #define HV_SYNIC_INTERCEPTION_SINT_INDEX 0x00000000
> > #define HV_SYNIC_IOMMU_FAULT_SINT_INDEX 0x00000001
> >
> > base-commit: e3ec97c3abaf2fb68cc755cae3229288696b9f3d
>
> Reviewed-by: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
Applied.
prev parent reply other threads:[~2025-10-02 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 23:08 [PATCH hyperv-next] hyperv: Remove the spurious null directive line Roman Kisel
2025-10-02 16:04 ` Easwar Hariharan
2025-10-02 21:21 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002212148.GB925245@liuwe-devbox-debian-v2.local \
--to=wei.liu@kernel.org \
--cc=benhill@microsoft.com \
--cc=bperkins@microsoft.com \
--cc=decui@microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=easwar.hariharan@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=romank@linux.microsoft.com \
--cc=sunilmut@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).