* [PATCH hyperv-next] hyperv: Remove the spurious null directive line
@ 2025-10-01 23:08 Roman Kisel
2025-10-02 16:04 ` Easwar Hariharan
0 siblings, 1 reply; 3+ messages in thread
From: Roman Kisel @ 2025-10-01 23:08 UTC (permalink / raw)
To: decui, eahariha, haiyangz, kys, mhklinux, nunodasneves, wei.liu,
linux-hyperv, linux-kernel
Cc: benhill, bperkins, sunilmut, romank
The file contains a line that consists of the lone # symbol
followed by a newline. While that is a valid syntax as
defined by the C99+ grammar (6.10.7 "Null directive"), it
serves no apparent purpose in this case.
Remove the null preprocessor directive. No functional changes.
Fixes: e68bda71a238 ("hyperv: Add new Hyper-V headers in include/hyperv")
Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
---
include/hyperv/hvgdk_mini.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/hyperv/hvgdk_mini.h b/include/hyperv/hvgdk_mini.h
index 1be7f6a02304..77abddfc750e 100644
--- a/include/hyperv/hvgdk_mini.h
+++ b/include/hyperv/hvgdk_mini.h
@@ -597,8 +597,6 @@ struct ms_hyperv_tsc_page { /* HV_REFERENCE_TSC_PAGE */
#define HV_SYNIC_SINT_AUTO_EOI (1ULL << 17)
#define HV_SYNIC_SINT_VECTOR_MASK (0xFF)
-#
-
/* Hyper-V defined statically assigned SINTs */
#define HV_SYNIC_INTERCEPTION_SINT_INDEX 0x00000000
#define HV_SYNIC_IOMMU_FAULT_SINT_INDEX 0x00000001
base-commit: e3ec97c3abaf2fb68cc755cae3229288696b9f3d
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH hyperv-next] hyperv: Remove the spurious null directive line
2025-10-01 23:08 [PATCH hyperv-next] hyperv: Remove the spurious null directive line Roman Kisel
@ 2025-10-02 16:04 ` Easwar Hariharan
2025-10-02 21:21 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Easwar Hariharan @ 2025-10-02 16:04 UTC (permalink / raw)
To: Roman Kisel
Cc: decui, eahariha, haiyangz, kys, mhklinux, nunodasneves, wei.liu,
linux-hyperv, linux-kernel, easwar.hariharan, benhill, bperkins,
sunilmut
On 10/1/2025 4:08 PM, Roman Kisel wrote:
> The file contains a line that consists of the lone # symbol
> followed by a newline. While that is a valid syntax as
> defined by the C99+ grammar (6.10.7 "Null directive"), it
> serves no apparent purpose in this case.
>
> Remove the null preprocessor directive. No functional changes.
>
> Fixes: e68bda71a238 ("hyperv: Add new Hyper-V headers in include/hyperv")
> Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
> ---
> include/hyperv/hvgdk_mini.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hyperv/hvgdk_mini.h b/include/hyperv/hvgdk_mini.h
> index 1be7f6a02304..77abddfc750e 100644
> --- a/include/hyperv/hvgdk_mini.h
> +++ b/include/hyperv/hvgdk_mini.h
> @@ -597,8 +597,6 @@ struct ms_hyperv_tsc_page { /* HV_REFERENCE_TSC_PAGE */
> #define HV_SYNIC_SINT_AUTO_EOI (1ULL << 17)
> #define HV_SYNIC_SINT_VECTOR_MASK (0xFF)
>
> -#
> -
> /* Hyper-V defined statically assigned SINTs */
> #define HV_SYNIC_INTERCEPTION_SINT_INDEX 0x00000000
> #define HV_SYNIC_IOMMU_FAULT_SINT_INDEX 0x00000001
>
> base-commit: e3ec97c3abaf2fb68cc755cae3229288696b9f3d
Reviewed-by: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH hyperv-next] hyperv: Remove the spurious null directive line
2025-10-02 16:04 ` Easwar Hariharan
@ 2025-10-02 21:21 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2025-10-02 21:21 UTC (permalink / raw)
To: Easwar Hariharan
Cc: Roman Kisel, decui, eahariha, haiyangz, kys, mhklinux,
nunodasneves, wei.liu, linux-hyperv, linux-kernel, benhill,
bperkins, sunilmut
On Thu, Oct 02, 2025 at 09:04:21AM -0700, Easwar Hariharan wrote:
> On 10/1/2025 4:08 PM, Roman Kisel wrote:
> > The file contains a line that consists of the lone # symbol
> > followed by a newline. While that is a valid syntax as
> > defined by the C99+ grammar (6.10.7 "Null directive"), it
> > serves no apparent purpose in this case.
> >
> > Remove the null preprocessor directive. No functional changes.
> >
> > Fixes: e68bda71a238 ("hyperv: Add new Hyper-V headers in include/hyperv")
> > Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
> > ---
> > include/hyperv/hvgdk_mini.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/include/hyperv/hvgdk_mini.h b/include/hyperv/hvgdk_mini.h
> > index 1be7f6a02304..77abddfc750e 100644
> > --- a/include/hyperv/hvgdk_mini.h
> > +++ b/include/hyperv/hvgdk_mini.h
> > @@ -597,8 +597,6 @@ struct ms_hyperv_tsc_page { /* HV_REFERENCE_TSC_PAGE */
> > #define HV_SYNIC_SINT_AUTO_EOI (1ULL << 17)
> > #define HV_SYNIC_SINT_VECTOR_MASK (0xFF)
> >
> > -#
> > -
> > /* Hyper-V defined statically assigned SINTs */
> > #define HV_SYNIC_INTERCEPTION_SINT_INDEX 0x00000000
> > #define HV_SYNIC_IOMMU_FAULT_SINT_INDEX 0x00000001
> >
> > base-commit: e3ec97c3abaf2fb68cc755cae3229288696b9f3d
>
> Reviewed-by: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-02 21:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-01 23:08 [PATCH hyperv-next] hyperv: Remove the spurious null directive line Roman Kisel
2025-10-02 16:04 ` Easwar Hariharan
2025-10-02 21:21 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).