From: Borislav Petkov <bp@alien8.de>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: x86@kernel.org, Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Michael Kelley <mhklinux@outlook.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Saurabh Sengar <ssengar@linux.microsoft.com>,
Chris Oo <cho@microsoft.com>,
"Kirill A. Shutemov" <kas@kernel.org>,
linux-hyperv@vger.kernel.org, devicetree@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Ricardo Neri <ricardo.neri@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Yunhong Jiang <yunhong.jiang@linux.intel.com>
Subject: Re: [PATCH v6 02/10] x86/acpi: Move acpi_wakeup_cpu() and helpers to smpwakeup.c
Date: Wed, 29 Oct 2025 12:13:58 +0100 [thread overview]
Message-ID: <20251029111358.GDaQH29lURT0p_WWsb@fat_crate.local> (raw)
In-Reply-To: <20251027205816.GB14161@ranerica-svr.sc.intel.com>
On Mon, Oct 27, 2025 at 01:58:16PM -0700, Ricardo Neri wrote:
> Right. All the functions in the file start with the acpi_ prefix. It could
> be kept under arch/x86/kernel/acpi/. The Kconfig symbol X86_MAILBOX_WAKEUP
> would have to live in arch/x86/Kconfig as there is no Kconfig file under
> arch/x86/kernel/acpi. ACPI_MADT_WAKEUP is arch/x86/Kconfig.
>
> Does that sound acceptable?
Right, this looks kinda weird. You have devicetree thing using ACPI code,
you're trying to carve it out but then it is ACPI code anyway. So why even do
that?
You can simply leave ACPI enabled on that configuration. I don't see yet what
the point for the split is - saving memory, or...?
> Thank you for your feedback, Boris,
Sure, np. Trying my best. :-)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2025-10-29 11:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 2:57 [PATCH v6 00/10] x86/hyperv/hv_vtl: Use a wakeup mailbox to boot secondary CPUs Ricardo Neri
2025-10-17 2:57 ` [PATCH v6 01/10] x86/acpi: Add helper functions to setup and access the wakeup mailbox Ricardo Neri
2025-10-17 9:46 ` Rafael J. Wysocki
2025-10-17 21:10 ` Ricardo Neri
2025-10-18 13:08 ` Rafael J. Wysocki
2025-10-17 2:57 ` [PATCH v6 02/10] x86/acpi: Move acpi_wakeup_cpu() and helpers to smpwakeup.c Ricardo Neri
2025-10-27 14:18 ` Borislav Petkov
2025-10-27 20:58 ` Ricardo Neri
2025-10-29 11:13 ` Borislav Petkov [this message]
2025-10-30 5:43 ` Ricardo Neri
2025-11-03 13:40 ` Borislav Petkov
2025-11-10 17:49 ` Ricardo Neri
2025-11-10 19:46 ` Borislav Petkov
2025-11-10 20:56 ` Rafael J. Wysocki
2025-10-17 2:57 ` [PATCH v6 03/10] dt-bindings: reserved-memory: Wakeup Mailbox for Intel processors Ricardo Neri
2025-10-27 14:22 ` Borislav Petkov
2025-10-27 20:45 ` Ricardo Neri
2025-10-27 20:41 ` Wysocki, Rafael J
2025-10-27 22:51 ` Borislav Petkov
2025-10-17 2:57 ` [PATCH v6 04/10] x86/dt: Parse the " Ricardo Neri
2025-10-17 22:17 ` Wei Liu
2025-10-17 2:57 ` [PATCH v6 05/10] x86/hyperv/vtl: Set real_mode_header in hv_vtl_init_platform() Ricardo Neri
2025-10-17 2:57 ` [PATCH v6 06/10] x86/realmode: Make the location of the trampoline configurable Ricardo Neri
2025-10-17 2:57 ` [PATCH v6 07/10] x86/hyperv/vtl: Setup the 64-bit trampoline for TDX guests Ricardo Neri
2025-10-17 2:57 ` [PATCH v6 08/10] x86/smpwakeup: Add a helper get the address of the wakeup mailbox Ricardo Neri
2025-10-17 22:16 ` Wei Liu
2025-10-17 2:57 ` [PATCH v6 09/10] x86/hyperv/vtl: Mark the wakeup mailbox page as private Ricardo Neri
2025-10-17 2:57 ` [PATCH v6 10/10] x86/hyperv/vtl: Use the wakeup mailbox to boot secondary CPUs Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029111358.GDaQH29lURT0p_WWsb@fat_crate.local \
--to=bp@alien8.de \
--cc=cho@microsoft.com \
--cc=conor+dt@kernel.org \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=haiyangz@microsoft.com \
--cc=kas@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=robh@kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
--cc=yunhong.jiang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox