From: Wei Liu <wei.liu@kernel.org>
To: Nuno Das Neves <nunodasneves@linux.microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
muislam@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com,
decui@microsoft.com, longli@microsoft.com, mhklinux@outlook.com,
skinsburskii@linux.microsoft.com, romank@linux.microsoft.com,
Jinank Jain <jinankjain@microsoft.com>
Subject: Re: [PATCH v2] mshv: Extend create partition ioctl to support cpu features
Date: Fri, 7 Nov 2025 18:14:57 +0000 [thread overview]
Message-ID: <20251107181457.GC4041739@liuwe-devbox-debian-v2.local> (raw)
In-Reply-To: <28ab51c0-fe14-4122-8828-3f680207865d@linux.microsoft.com>
On Fri, Oct 31, 2025 at 01:08:45PM -0700, Nuno Das Neves wrote:
> On 10/31/2025 11:31 AM, Wei Liu wrote:
> > On Thu, Oct 30, 2025 at 02:40:31PM -0700, Nuno Das Neves wrote:
> >> From: Muminul Islam <muislam@microsoft.com>
> >>
> >> The existing mshv create partition ioctl does not provide a way to
> >> specify which cpu features are enabled in the guest. This was done
> >> to reduce unnecessary complexity in the API.
> >>
> >> However, some new scenarios require fine-grained control over the
> >> cpu feature bits.
> >>
> >> Define a new mshv_create_partition_v2 structure which supports passing
> >> through the disabled cpu flags and xsave flags to the hypervisor
> >> directly.
> >>
> >> When these are not specified (pt_num_cpu_fbanks == 0) or the old
> >> structure is used, define a set of default flags which cover most
> >> cases.
> >>
> >> Retain backward compatibility with the old structure via a new flag
> >> MSHV_PT_BIT_CPU_AND_XSAVE_FEATURES which enables the new struct.
> >>
> >> Co-developed-by: Jinank Jain <jinankjain@microsoft.com>
> >> Signed-off-by: Jinank Jain <jinankjain@microsoft.com>
> >> Signed-off-by: Muminul Islam <muislam@microsoft.com>
> >> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
> >> ---
> >> Changes in v2:
> >> - Fix compilation issues [kernel test robot]
> >>
> >> ---
> >> drivers/hv/mshv_root_main.c | 176 ++++++++++++++++++++++++++++++++----
> >> include/hyperv/hvhdk.h | 86 +++++++++++++++++-
> >
> > There is no mention of updating hvhdk.h in the commit message.
> >
> Ah, that's true..
>
> > Can you split out this part to a separate commit?
>
> I put the header changes in this patch because a patch containing
> those alone doesn't have much merit on its own.
>
> I know we have split header changes into separate patches in the
> past but I'm not sure it's always the right choice.
>
This makes it easier for me or other maintainers to track specifically
the header changes.
> Thinking about this, I could also split it up another way: one
> patch to introduce the new cpu features flags and use them in the
> driver, and one patch to introduce mshv_create_partition_v2.
That's fine by me.
Wei
>
> Nuno>
> > Wei
>
next prev parent reply other threads:[~2025-11-07 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 21:40 [PATCH v2] mshv: Extend create partition ioctl to support cpu features Nuno Das Neves
2025-10-31 18:31 ` Wei Liu
2025-10-31 20:08 ` Nuno Das Neves
2025-11-07 18:14 ` Wei Liu [this message]
2025-10-31 18:37 ` Easwar Hariharan
2025-10-31 19:49 ` Nuno Das Neves
2025-11-02 14:13 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107181457.GC4041739@liuwe-devbox-debian-v2.local \
--to=wei.liu@kernel.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=jinankjain@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mhklinux@outlook.com \
--cc=muislam@microsoft.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=romank@linux.microsoft.com \
--cc=skinsburskii@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).