From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: "Stefano Garzarella" <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Wei Liu" <wei.liu@kernel.org>,
"Dexuan Cui" <decui@microsoft.com>,
"Bryan Tan" <bryan-bt.tan@broadcom.com>,
"Vishnu Dasa" <vishnu.dasa@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Shuah Khan" <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org,
berrange@redhat.com, Sargun Dhillon <sargun@sargun.me>,
Bobby Eshleman <bobbyeshleman@gmail.com>,
Bobby Eshleman <bobbyeshleman@meta.com>
Subject: [PATCH net-next v12 07/12] selftests/vsock: add vm_dmesg_{warn,oops}_count() helpers
Date: Wed, 26 Nov 2025 23:47:36 -0800 [thread overview]
Message-ID: <20251126-vsock-vmtest-v12-7-257ee21cd5de@meta.com> (raw)
In-Reply-To: <20251126-vsock-vmtest-v12-0-257ee21cd5de@meta.com>
From: Bobby Eshleman <bobbyeshleman@meta.com>
These functions are reused by the VM tests to collect and compare dmesg
warnings and oops counts. The future VM-specific tests use them heavily.
This patches relies on vm_ssh() already supporting namespaces.
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
---
Changes in v11:
- break these out into an earlier patch so that they can be used
directly in new patches (instead of causing churn by adding this
later)
---
tools/testing/selftests/vsock/vmtest.sh | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh
index 4da91828a6a0..1623e4da15e2 100755
--- a/tools/testing/selftests/vsock/vmtest.sh
+++ b/tools/testing/selftests/vsock/vmtest.sh
@@ -389,6 +389,17 @@ host_wait_for_listener() {
fi
}
+vm_dmesg_oops_count() {
+ local ns=$1
+
+ vm_ssh "${ns}" -- dmesg 2>/dev/null | grep -c -i 'Oops'
+}
+
+vm_dmesg_warn_count() {
+ local ns=$1
+
+ vm_ssh "${ns}" -- dmesg --level=warn 2>/dev/null | grep -c -i 'vsock'
+}
vm_vsock_test() {
local ns=$1
@@ -596,8 +607,8 @@ run_shared_vm_test() {
host_oops_cnt_before=$(dmesg | grep -c -i 'Oops')
host_warn_cnt_before=$(dmesg --level=warn | grep -c -i 'vsock')
- vm_oops_cnt_before=$(vm_ssh -- dmesg | grep -c -i 'Oops')
- vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
+ vm_oops_cnt_before=$(vm_dmesg_oops_count "init_ns")
+ vm_warn_cnt_before=$(vm_dmesg_warn_count "init_ns")
name=$(echo "${1}" | awk '{ print $1 }')
eval test_"${name}"
@@ -615,13 +626,13 @@ run_shared_vm_test() {
rc=$KSFT_FAIL
fi
- vm_oops_cnt_after=$(vm_ssh -- dmesg | grep -i 'Oops' | wc -l)
+ vm_oops_cnt_after=$(vm_dmesg_oops_count "init_ns")
if [[ ${vm_oops_cnt_after} -gt ${vm_oops_cnt_before} ]]; then
echo "FAIL: kernel oops detected on vm" | log_host
rc=$KSFT_FAIL
fi
- vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
+ vm_warn_cnt_after=$(vm_dmesg_warn_count "init_ns")
if [[ ${vm_warn_cnt_after} -gt ${vm_warn_cnt_before} ]]; then
echo "FAIL: kernel warning detected on vm" | log_host
rc=$KSFT_FAIL
--
2.47.3
next prev parent reply other threads:[~2025-11-27 7:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 7:47 [PATCH net-next v12 00/12] vsock: add namespace support to vhost-vsock and loopback Bobby Eshleman
2025-11-27 7:47 ` [PATCH net-next v12 01/12] vsock: a per-net vsock NS mode state Bobby Eshleman
2025-11-27 7:47 ` [PATCH net-next v12 02/12] vsock: add netns to vsock core Bobby Eshleman
2025-11-27 14:25 ` Stefano Garzarella
2025-11-27 16:33 ` Bobby Eshleman
2025-11-27 7:47 ` [PATCH net-next v12 03/12] virtio: set skb owner of virtio_transport_reset_no_sock() reply Bobby Eshleman
2025-11-27 7:47 ` [PATCH net-next v12 04/12] vsock: add netns support to virtio transports Bobby Eshleman
2025-11-27 14:44 ` Stefano Garzarella
2025-12-02 10:18 ` Paolo Abeni
2025-12-02 17:56 ` Bobby Eshleman
2025-12-02 20:00 ` Bobby Eshleman
2025-12-02 20:47 ` Paolo Abeni
2025-12-02 22:01 ` Bobby Eshleman
2025-12-03 14:16 ` Stefano Garzarella
2025-12-12 15:26 ` Bobby Eshleman
2025-12-15 14:11 ` Stefano Garzarella
2025-12-16 1:22 ` Bobby Eshleman
2025-12-24 0:32 ` Bobby Eshleman
2025-12-24 13:01 ` Stefano Garzarella
2025-11-27 7:47 ` [PATCH net-next v12 05/12] selftests/vsock: add namespace helpers to vmtest.sh Bobby Eshleman
2025-11-27 7:47 ` [PATCH net-next v12 06/12] selftests/vsock: prepare vm management helpers for namespaces Bobby Eshleman
2025-11-27 7:47 ` Bobby Eshleman [this message]
2025-11-27 7:47 ` [PATCH net-next v12 08/12] selftests/vsock: use ss to wait for listeners instead of /proc/net Bobby Eshleman
2025-11-27 7:47 ` [PATCH net-next v12 09/12] selftests/vsock: add tests for proc sys vsock ns_mode Bobby Eshleman
2025-11-27 7:47 ` [PATCH net-next v12 10/12] selftests/vsock: add namespace tests for CID collisions Bobby Eshleman
2025-11-27 7:47 ` [PATCH net-next v12 11/12] selftests/vsock: add tests for host <-> vm connectivity with namespaces Bobby Eshleman
2025-11-27 14:49 ` Stefano Garzarella
2025-11-27 7:47 ` [PATCH net-next v12 12/12] selftests/vsock: add tests for namespace deletion and mode changes Bobby Eshleman
2025-11-27 15:17 ` [PATCH net-next v12 00/12] vsock: add namespace support to vhost-vsock and loopback Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126-vsock-vmtest-v12-7-257ee21cd5de@meta.com \
--to=bobbyeshleman@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=berrange@redhat.com \
--cc=bobbyeshleman@meta.com \
--cc=bryan-bt.tan@broadcom.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sargun@sargun.me \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=vishnu.dasa@broadcom.com \
--cc=wei.liu@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).