* [PATCH V0] x86/hyperv: Fix compiler warnings in hv_crash.c
@ 2026-01-21 2:40 Mukesh R
2026-01-29 4:21 ` Michael Kelley
0 siblings, 1 reply; 3+ messages in thread
From: Mukesh R @ 2026-01-21 2:40 UTC (permalink / raw)
To: linux-hyperv, linux-kernel; +Cc: wei.liu
Fix two compiler warnings:
o smp_ops is only defined if CONFIG_SMP
o status is set but not explicitly used.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202512301641.FC6OAbGM-lkp@intel.com/
Signed-off-by: Mukesh R <mrathor@linux.microsoft.com>
---
arch/x86/hyperv/hv_crash.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/hyperv/hv_crash.c b/arch/x86/hyperv/hv_crash.c
index c0e22921ace1..82915b22ceae 100644
--- a/arch/x86/hyperv/hv_crash.c
+++ b/arch/x86/hyperv/hv_crash.c
@@ -279,7 +279,6 @@ static void hv_notify_prepare_hyp(void)
static noinline __noclone void crash_nmi_callback(struct pt_regs *regs)
{
struct hv_input_disable_hyp_ex *input;
- u64 status;
int msecs = 1000, ccpu = smp_processor_id();
if (ccpu == 0) {
@@ -313,7 +312,7 @@ static noinline __noclone void crash_nmi_callback(struct pt_regs *regs)
input->rip = trampoline_pa;
input->arg = devirt_arg;
- status = hv_do_hypercall(HVCALL_DISABLE_HYP_EX, input, NULL);
+ hv_do_hypercall(HVCALL_DISABLE_HYP_EX, input, NULL);
hv_panic_timeout_reboot();
}
@@ -628,8 +627,9 @@ void hv_root_crash_init(void)
if (rc)
goto err_out;
+#ifdef CONFIG_SMP
smp_ops.crash_stop_other_cpus = hv_crash_stop_other_cpus;
-
+#endif
crash_kexec_post_notifiers = true;
hv_crash_enabled = true;
pr_info("Hyper-V: both linux and hypervisor kdump support enabled\n");
--
2.51.2.vfs.0.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH V0] x86/hyperv: Fix compiler warnings in hv_crash.c
2026-01-21 2:40 [PATCH V0] x86/hyperv: Fix compiler warnings in hv_crash.c Mukesh R
@ 2026-01-29 4:21 ` Michael Kelley
2026-02-04 6:12 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2026-01-29 4:21 UTC (permalink / raw)
To: Mukesh R, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: wei.liu@kernel.org
From: Mukesh R <mrathor@linux.microsoft.com> Sent: Tuesday, January 20, 2026 6:41 PM
>
> Fix two compiler warnings:
> o smp_ops is only defined if CONFIG_SMP
> o status is set but not explicitly used.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512301641.FC6OAbGM-lkp@intel.com/
> Signed-off-by: Mukesh R <mrathor@linux.microsoft.com>
> ---
> arch/x86/hyperv/hv_crash.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/hyperv/hv_crash.c b/arch/x86/hyperv/hv_crash.c
> index c0e22921ace1..82915b22ceae 100644
> --- a/arch/x86/hyperv/hv_crash.c
> +++ b/arch/x86/hyperv/hv_crash.c
> @@ -279,7 +279,6 @@ static void hv_notify_prepare_hyp(void)
> static noinline __noclone void crash_nmi_callback(struct pt_regs *regs)
> {
> struct hv_input_disable_hyp_ex *input;
> - u64 status;
> int msecs = 1000, ccpu = smp_processor_id();
>
> if (ccpu == 0) {
> @@ -313,7 +312,7 @@ static noinline __noclone void crash_nmi_callback(struct
> pt_regs *regs)
> input->rip = trampoline_pa;
> input->arg = devirt_arg;
>
> - status = hv_do_hypercall(HVCALL_DISABLE_HYP_EX, input, NULL);
> + hv_do_hypercall(HVCALL_DISABLE_HYP_EX, input, NULL);
>
> hv_panic_timeout_reboot();
> }
> @@ -628,8 +627,9 @@ void hv_root_crash_init(void)
> if (rc)
> goto err_out;
>
> +#ifdef CONFIG_SMP
> smp_ops.crash_stop_other_cpus = hv_crash_stop_other_cpus;
> -
> +#endif
> crash_kexec_post_notifiers = true;
> hv_crash_enabled = true;
> pr_info("Hyper-V: both linux and hypervisor kdump support enabled\n");
> --
> 2.51.2.vfs.0.1
>
Ingo Molnar has separately fixed the smp_ops problem in [1]. Removing
the unused "status" value looks good to me, though it's probably slightly
better to add (void) to hv_do_hypercall() as an explicit acknowledgement
that there's a return value that's not relevant and is being ignored; i.e.,
(void)hv_do_hypercall(HVCALL_DISABLE_HYP_EX, input, NULL);
Regardless, for the unused "status" part of this patch,
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
[1] https://lore.kernel.org/all/176959812223.510.4055929851272785854.tip-bot2@tip-bot2/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V0] x86/hyperv: Fix compiler warnings in hv_crash.c
2026-01-29 4:21 ` Michael Kelley
@ 2026-02-04 6:12 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2026-02-04 6:12 UTC (permalink / raw)
To: Michael Kelley
Cc: Mukesh R, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, wei.liu@kernel.org
On Thu, Jan 29, 2026 at 04:21:56AM +0000, Michael Kelley wrote:
> From: Mukesh R <mrathor@linux.microsoft.com> Sent: Tuesday, January 20, 2026 6:41 PM
> >
> > Fix two compiler warnings:
> > o smp_ops is only defined if CONFIG_SMP
> > o status is set but not explicitly used.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202512301641.FC6OAbGM-lkp@intel.com/
> > Signed-off-by: Mukesh R <mrathor@linux.microsoft.com>
> > ---
> > arch/x86/hyperv/hv_crash.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/x86/hyperv/hv_crash.c b/arch/x86/hyperv/hv_crash.c
> > index c0e22921ace1..82915b22ceae 100644
> > --- a/arch/x86/hyperv/hv_crash.c
> > +++ b/arch/x86/hyperv/hv_crash.c
> > @@ -279,7 +279,6 @@ static void hv_notify_prepare_hyp(void)
> > static noinline __noclone void crash_nmi_callback(struct pt_regs *regs)
> > {
> > struct hv_input_disable_hyp_ex *input;
> > - u64 status;
> > int msecs = 1000, ccpu = smp_processor_id();
> >
> > if (ccpu == 0) {
> > @@ -313,7 +312,7 @@ static noinline __noclone void crash_nmi_callback(struct
> > pt_regs *regs)
> > input->rip = trampoline_pa;
> > input->arg = devirt_arg;
> >
> > - status = hv_do_hypercall(HVCALL_DISABLE_HYP_EX, input, NULL);
> > + hv_do_hypercall(HVCALL_DISABLE_HYP_EX, input, NULL);
> >
> > hv_panic_timeout_reboot();
> > }
> > @@ -628,8 +627,9 @@ void hv_root_crash_init(void)
> > if (rc)
> > goto err_out;
> >
> > +#ifdef CONFIG_SMP
> > smp_ops.crash_stop_other_cpus = hv_crash_stop_other_cpus;
> > -
> > +#endif
> > crash_kexec_post_notifiers = true;
> > hv_crash_enabled = true;
> > pr_info("Hyper-V: both linux and hypervisor kdump support enabled\n");
> > --
> > 2.51.2.vfs.0.1
> >
>
> Ingo Molnar has separately fixed the smp_ops problem in [1]. Removing
> the unused "status" value looks good to me, though it's probably slightly
> better to add (void) to hv_do_hypercall() as an explicit acknowledgement
> that there's a return value that's not relevant and is being ignored; i.e.,
>
> (void)hv_do_hypercall(HVCALL_DISABLE_HYP_EX, input, NULL);
>
> Regardless, for the unused "status" part of this patch,
>
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
>
> [1] https://lore.kernel.org/all/176959812223.510.4055929851272785854.tip-bot2@tip-bot2/
It's my fault. I didn't get to this earlier.
I have applied the other fix to my tree.
Thanks,
Wei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-04 6:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-21 2:40 [PATCH V0] x86/hyperv: Fix compiler warnings in hv_crash.c Mukesh R
2026-01-29 4:21 ` Michael Kelley
2026-02-04 6:12 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox