* [PATCH] pci: pci-hyperv-intf: remove unnecessary module_init/exit functions
@ 2026-01-31 2:00 Ethan Nelson-Moore
2026-02-04 6:21 ` Wei Liu
2026-02-04 12:38 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-31 2:00 UTC (permalink / raw)
To: linux-hyperv, linux-pci
Cc: Ethan Nelson-Moore, K. Y. Srinivasan, Haiyang Zhang, Wei Liu,
Dexuan Cui, Long Li, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas
The pci-hyperv-intf driver has unnecessary empty module_init and
module_exit functions. Remove them. Note that if a module_init function
exists, a module_exit function must also exist; otherwise, the module
cannot be unloaded.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/pci/controller/pci-hyperv-intf.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/pci/controller/pci-hyperv-intf.c b/drivers/pci/controller/pci-hyperv-intf.c
index 28b3e93d31c0..18acbda867f0 100644
--- a/drivers/pci/controller/pci-hyperv-intf.c
+++ b/drivers/pci/controller/pci-hyperv-intf.c
@@ -52,17 +52,5 @@ int hyperv_reg_block_invalidate(struct pci_dev *dev, void *context,
}
EXPORT_SYMBOL_GPL(hyperv_reg_block_invalidate);
-static void __exit exit_hv_pci_intf(void)
-{
-}
-
-static int __init init_hv_pci_intf(void)
-{
- return 0;
-}
-
-module_init(init_hv_pci_intf);
-module_exit(exit_hv_pci_intf);
-
MODULE_DESCRIPTION("Hyper-V PCI Interface");
MODULE_LICENSE("GPL v2");
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pci: pci-hyperv-intf: remove unnecessary module_init/exit functions
2026-01-31 2:00 [PATCH] pci: pci-hyperv-intf: remove unnecessary module_init/exit functions Ethan Nelson-Moore
@ 2026-02-04 6:21 ` Wei Liu
2026-02-04 12:38 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2026-02-04 6:21 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: linux-hyperv, linux-pci, K. Y. Srinivasan, Haiyang Zhang, Wei Liu,
Dexuan Cui, Long Li, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas
On Fri, Jan 30, 2026 at 06:00:17PM -0800, Ethan Nelson-Moore wrote:
> The pci-hyperv-intf driver has unnecessary empty module_init and
> module_exit functions. Remove them. Note that if a module_init function
> exists, a module_exit function must also exist; otherwise, the module
> cannot be unloaded.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Applied to hyperv-next. I modified the subject line to match our
conventions. Thanks.
Wei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: pci-hyperv-intf: remove unnecessary module_init/exit functions
2026-01-31 2:00 [PATCH] pci: pci-hyperv-intf: remove unnecessary module_init/exit functions Ethan Nelson-Moore
2026-02-04 6:21 ` Wei Liu
@ 2026-02-04 12:38 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2026-02-04 12:38 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: linux-hyperv, linux-pci, K. Y. Srinivasan, Haiyang Zhang, Wei Liu,
Dexuan Cui, Long Li, Lorenzo Pieralisi, Krzysztof Wilczyński,
Rob Herring, Bjorn Helgaas
On Fri, Jan 30, 2026 at 06:00:17PM -0800, Ethan Nelson-Moore wrote:
> The pci-hyperv-intf driver has unnecessary empty module_init and
> module_exit functions. Remove them. Note that if a module_init function
> exists, a module_exit function must also exist; otherwise, the module
> cannot be unloaded.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
- Mani
> ---
> drivers/pci/controller/pci-hyperv-intf.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-hyperv-intf.c b/drivers/pci/controller/pci-hyperv-intf.c
> index 28b3e93d31c0..18acbda867f0 100644
> --- a/drivers/pci/controller/pci-hyperv-intf.c
> +++ b/drivers/pci/controller/pci-hyperv-intf.c
> @@ -52,17 +52,5 @@ int hyperv_reg_block_invalidate(struct pci_dev *dev, void *context,
> }
> EXPORT_SYMBOL_GPL(hyperv_reg_block_invalidate);
>
> -static void __exit exit_hv_pci_intf(void)
> -{
> -}
> -
> -static int __init init_hv_pci_intf(void)
> -{
> - return 0;
> -}
> -
> -module_init(init_hv_pci_intf);
> -module_exit(exit_hv_pci_intf);
> -
> MODULE_DESCRIPTION("Hyper-V PCI Interface");
> MODULE_LICENSE("GPL v2");
> --
> 2.43.0
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-04 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-31 2:00 [PATCH] pci: pci-hyperv-intf: remove unnecessary module_init/exit functions Ethan Nelson-Moore
2026-02-04 6:21 ` Wei Liu
2026-02-04 12:38 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox