From: Jason Gunthorpe <jgg@nvidia.com>
To: Gal Pressman <gal.pressman@linux.dev>
Cc: Abhijit Gangurde <abhijit.gangurde@amd.com>,
Allen Hubbe <allen.hubbe@amd.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Bernard Metzler <bernard.metzler@linux.dev>,
Bryan Tan <bryan-bt.tan@broadcom.com>,
Cheng Xu <chengyou@linux.alibaba.com>,
Junxian Huang <huangjunxian6@hisilicon.com>,
Kai Shen <kaishen@linux.alibaba.com>,
Konstantin Taranov <kotaranov@microsoft.com>,
Krzysztof Czurylo <krzysztof.czurylo@intel.com>,
Leon Romanovsky <leon@kernel.org>,
linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org,
Long Li <longli@microsoft.com>,
Michal Kalderon <mkalderon@marvell.com>,
Michael Margolin <mrgolin@amazon.com>,
Nelson Escobar <neescoba@cisco.com>,
Satish Kharat <satishkh@cisco.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Yossi Leybovich <sleybo@amazon.com>,
Chengchang Tang <tangchengchang@huawei.com>,
Tatyana Nikolova <tatyana.e.nikolova@intel.com>,
Vishnu Dasa <vishnu.dasa@broadcom.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
patches@lists.linux.dev
Subject: Re: [PATCH 10/16] RDMA/efa: Use ib_copy_validate_udata_in_cm()
Date: Thu, 12 Mar 2026 08:20:20 -0300 [thread overview]
Message-ID: <20260312112020.GE1448102@nvidia.com> (raw)
In-Reply-To: <cf3bbf89-0bb1-4c58-b78f-37afdb2ff99c@linux.dev>
On Thu, Mar 12, 2026 at 01:03:59PM +0200, Gal Pressman wrote:
> On 12/03/2026 2:24, Jason Gunthorpe wrote:
> > Add the missed check for unsupported comp_mask bits.
>
> Is it really missed? IIRC, it's intended.
>
> See the comment above your hunk, and efa_user_comp_handshake()?
No, that is an illegal way to use a field called comp_mask.
If the driver wants that it needs a new field "suggested feature flags
to enable"
comp_mask is strictly to say that new fields are present and must be
processed by the kernel, and nothing else.
Jason
next prev parent reply other threads:[~2026-03-12 11:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 0:24 [PATCH 00/16] Update drivers to use ib_copy_validate_udata_in() Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 01/16] RDMA: Consolidate patterns with offsetofend() to ib_copy_validate_udata_in() Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 02/16] RDMA: Consolidate patterns with offsetof() " Jason Gunthorpe
2026-03-17 18:03 ` [EXTERNAL] " Long Li
2026-03-12 0:24 ` [PATCH 03/16] RDMA: Consolidate patterns with sizeof() " Jason Gunthorpe
2026-03-17 18:08 ` [EXTERNAL] " Long Li
2026-03-12 0:24 ` [PATCH 04/16] RDMA: Use ib_copy_validate_udata_in() for implicit full structs Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 05/16] RDMA/pvrdma: Use ib_copy_validate_udata_in() for srq Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 06/16] RDMA/mlx5: Use ib_copy_validate_udata_in() Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 07/16] RDMA/mlx4: " Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 08/16] RDMA/mlx4: Use ib_copy_validate_udata_in() for QP Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 09/16] RDMA/hns: Use ib_copy_validate_udata_in() Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 10/16] RDMA/efa: Use ib_copy_validate_udata_in_cm() Jason Gunthorpe
2026-03-12 11:03 ` Gal Pressman
2026-03-12 11:20 ` Jason Gunthorpe [this message]
2026-03-12 12:08 ` Jason Gunthorpe
2026-03-12 13:22 ` Michael Margolin
2026-03-12 0:24 ` [PATCH 11/16] RDMA: Use ib_copy_validate_udata_in_cm() for zero comp_mask Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 12/16] RDMA/mlx5: Pull comp_mask validation into ib_copy_validate_udata_in_cm() Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 13/16] RDMA/hns: Add missing comp_mask check in create_qp Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 14/16] RDMA/irdma: Add missing comp_mask check in alloc_ucontext Jason Gunthorpe
2026-03-12 0:24 ` [PATCH 15/16] RDMA: Remove redundant = {} for udata req structs Jason Gunthorpe
2026-03-17 18:16 ` [EXTERNAL] " Long Li
2026-03-12 0:24 ` [PATCH 16/16] RDMA/hns: Remove the duplicate calls to ib_copy_validate_udata_in() Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312112020.GE1448102@nvidia.com \
--to=jgg@nvidia.com \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bernard.metzler@linux.dev \
--cc=bryan-bt.tan@broadcom.com \
--cc=chengyou@linux.alibaba.com \
--cc=gal.pressman@linux.dev \
--cc=huangjunxian6@hisilicon.com \
--cc=kaishen@linux.alibaba.com \
--cc=kotaranov@microsoft.com \
--cc=krzysztof.czurylo@intel.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mkalderon@marvell.com \
--cc=mrgolin@amazon.com \
--cc=neescoba@cisco.com \
--cc=patches@lists.linux.dev \
--cc=satishkh@cisco.com \
--cc=selvin.xavier@broadcom.com \
--cc=sleybo@amazon.com \
--cc=tangchengchang@huawei.com \
--cc=tatyana.e.nikolova@intel.com \
--cc=vishnu.dasa@broadcom.com \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox