From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75AA3C2794 for ; Thu, 12 Mar 2026 12:57:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773320257; cv=none; b=m40oWfLGWxFShhKzJxhd6XsSYutQKQMW3jc+vbC5Y6PtwLlrmY+3BQJSi+mxI1bxyQXe4C+WiScen86wc5/J/oZ6eoFuMPm29rH6LaLucpah/hpiDSNkOYamGAdUaMgaS/SLC9yTQ06DdYPSmfRleWiG5CLk2xkLIICrmPbtHo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773320257; c=relaxed/simple; bh=Rr1jkAP22lZkLvo3o90a9fRSWh9+kilNKtAarSScWFY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oJI5n+aVpjQyl0zTECMn/uIU6ubbfYsRMb82XyHZsooEhpwafpnPgxIkxdDVA5Y8wssuQTaS9lpwWvtgNNREuhlLr2mTtySVQdr6OHf4VFR5yeCIb683M56l7DxJ4QyFKaJ4cKA1Oa3gMX1QB9uHkZEp6YHulz7rUS+0ja6lkTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=fHqxjqGD; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="fHqxjqGD" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8cd8a189f44so98277485a.0 for ; Thu, 12 Mar 2026 05:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773320252; x=1773925052; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J1SF1XBHkHR0j7NZVucv0LxpGoGXl67PUefLsfwpAbo=; b=fHqxjqGD7mReR8MT2yBowt9MuNKPAKQc++mWcb4ZOttX6YldICO+OnnxWIQjO0C8L5 wjOw0Gg7MqV4U+G9pES+s6h1NtZIjaKrBXMW81hrLyc8SxWYHtvQK3FlTjqiyroZskXE jYj0kUENL7Yhu5zg+0UQ91XYlYYlozX9U8uAqBEFaih0fSnDo8kprjTDRYJ58gzKRExo MSUW+Q+e0P2WpZGotx0DuVRaUqq4vGsUUSX1YbPnOxmRUKlXFY/aNRmXMXDbAEfx0Lnn e41FpuPSZjTSuTkWfTMW8e1MvewVXC2p6zLd4GrSZjvSKS4Q06nDQYaSimUW3qR5RhoY JV6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773320252; x=1773925052; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J1SF1XBHkHR0j7NZVucv0LxpGoGXl67PUefLsfwpAbo=; b=rdiDh87nZfRsjA5r50Bow362l+zSJ7kFxLarVLJhgoCdVkIyzLqv6h/YPC66+1dmn3 Bm1GniHUCyX9Qp9frWVG+mG8e9R6YuGKmODOG1oDSRIW8lPTzQtyURCEbLQVqmYBM9wO 8FCqn0O+Xl8UU3aPLPa2QvgJROvQPt3o+U1jNhomSZZh9tRavNO2lOtoer67wAYExE11 dTVCc4Y4UG+WHPdqh3//FvO7sZ9eHfc6i8ziq8g6dtv+bMozZnjyS0Y2ut5cljpcOuza iA85cH30DC8uWik+zEYZtNJjt55mCegh8vc3V3TGH7MzWq99tBTphnrLOu6BhKzDN5Gk WK+g== X-Forwarded-Encrypted: i=1; AJvYcCWQgOIKjyiQVcnk6FXt7m6P5N/e/UHnvubGlndeP0A16cLmZaXadl9P7/7EvRAHa9EKIEnzbbGccr6tj+c=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4z49MCpHm1Wi0SEfE91dWE3D1eqUZwIeewjVeOiqro6DHC+AF dOXkGg/VN+w3fjg6k6/IqwQ7z/eq3vkdXrAPvWJ5o1Q/xD9Pfe3z8lTdLshKBuHXnT8= X-Gm-Gg: ATEYQzxdYh26mxRtKRePGT050dHtU9wc1GF+z8F1wdN12UvTTYfRlUwW64qEof1xvoQ pqZ5df/x+JC6H8THh5drU3CP+BTtfZcsnHsNkwcE1oKx79KCmzBrvdvOJkVo6iUQhwT+p1Dt7Qs RWNYlseDKrkj6HdeB6K7ODx8u/IQSLf7V5NuLn8Zgh3qmlbgWMNos5yv+nMkCfA5wV7Hd71oc1D hF2CdljL6NWwWZn5Y8UJdXflfWdnOjX4kfWkgXEKymRiZpQearENWXZ1/kumMsuRRAWiXN18u6M M2S47tqn+h2WJutuojiI4Lr5OGCRKVHXl5jKTa5FZhxFeHxRgVi5CR/Shh4D2aBQl0GV2xq0Shb rdCt9/gZ8XBg2mTG99gnDfCavP/1fW9VoDBi13T4dycL6evxQkWcue/8xBjmZTcV9SF9ZCk6dlu 46C6g1MtN97twLEAWQzBmQ1m5RJdPEJri1OqCAnYLkTAPzw/P4LO+Lm2IAmmxyS4WwVo70j3b6Y /h+l/sn X-Received: by 2002:ac8:5d4d:0:b0:509:cbc:127b with SMTP id d75a77b69052e-5093a1bd58fmr77950521cf.60.1773320251710; Thu, 12 Mar 2026 05:57:31 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a65bd318fsm33341196d6.8.2026.03.12.05.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 05:57:31 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w0fbW-00000006fKD-1POa; Thu, 12 Mar 2026 09:57:30 -0300 Date: Thu, 12 Mar 2026 09:57:30 -0300 From: Jason Gunthorpe To: Kuan-Wei Chiu Cc: Philipp Hahn , amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev Subject: Re: [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor Message-ID: <20260312125730.GI1469476@ziepe.ca> References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 11, 2026 at 02:40:36AM +0800, Kuan-Wei Chiu wrote: > IMHO, the necessity of IS_ERR_OR_NULL() often highlights a confusing or > flawed API design. It usually implies that the caller is unsure whether > a failure results in an error pointer or a NULL pointer. +1 IS_ERR_OR_NULL() should always be looked on with suspicion. Very little should be returning some tri-state 'ERR' 'NULL' 'SUCCESS' pointer. What does the middle condition even mean? IS_ERR_OR_NULL() implies ERR and NULL are semanticly the same, so fix the things to always use ERR. If you want to improve things work to get rid of the NULL checks this script identifies. Remove ERR or NULL because only one can ever happen, or fix the source to consistently return ERR. Jason