public inbox for linux-hyperv@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Long Li <longli@microsoft.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Florian Bezdeka <florian.bezdeka@siemens.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: Move add_interrupt_randomness back to real interrupt
Date: Tue, 17 Mar 2026 12:05:35 +0100	[thread overview]
Message-ID: <20260317110535.Smn9viQ7@linutronix.de> (raw)
In-Reply-To: <1b53653a-98a5-402a-a224-996b26edaa97@siemens.com>

On 2026-03-17 09:09:27 [+0100], Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Sebastian Siewior wrote:
> "This is feeding entropy and would like to see interrupt registers. But
> since this is invoked from a thread it won't."
> 
> So move it back to where it is always in interrupt context.
> 
> Fixes: f8e6343b7a89 ("Drivers: hv: vmbus: Simplify allocation of vmbus_evt")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  drivers/hv/vmbus_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index bc4fc1951ae1..28025a264861 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1361,8 +1361,6 @@ static void __vmbus_isr(void)
>  
>  	vmbus_message_sched(hv_cpu, hv_cpu->hyp_synic_message_page);
>  	vmbus_message_sched(hv_cpu, hv_cpu->para_synic_message_page);
> -
> -	add_interrupt_randomness(vmbus_interrupt);
>  }
>  
>  static DEFINE_PER_CPU(bool, vmbus_irq_pending);
> @@ -1410,6 +1408,8 @@ void vmbus_isr(void)
>  		lockdep_hardirq_threaded();
>  		__vmbus_isr();
>  	}
> +
> +	add_interrupt_randomness(vmbus_interrupt);
>  }
>  EXPORT_SYMBOL_FOR_MODULES(vmbus_isr, "mshv_vtl");

Why not sysvec_hyperv_callback()?

Sebastian

  reply	other threads:[~2026-03-17 11:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  8:09 [PATCH] Drivers: hv: vmbus: Move add_interrupt_randomness back to real interrupt Jan Kiszka
2026-03-17 11:05 ` Sebastian Andrzej Siewior [this message]
2026-03-17 11:56   ` Jan Kiszka
2026-03-17 13:22     ` Sebastian Andrzej Siewior
2026-03-17 13:34       ` Jan Kiszka
2026-03-17 17:26         ` Michael Kelley
2026-03-18 10:10           ` Sebastian Andrzej Siewior
2026-03-19  3:39             ` Michael Kelley
2026-03-19  9:57               ` Sebastian Andrzej Siewior
2026-03-19 14:19                 ` Michael Kelley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317110535.Smn9viQ7@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=decui@microsoft.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=haiyangz@microsoft.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox