From: Eric Curtin <ericcurtin17@gmail.com>
To: linux-hyperv@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, iourit@linux.microsoft.com,
wei.liu@kernel.org, decui@microsoft.com, haiyangz@microsoft.com
Subject: [PATCH 44/55] drivers: hv: dxgkrnl: Implement known escapes
Date: Thu, 19 Mar 2026 20:24:58 +0000 [thread overview]
Message-ID: <20260319202509.63802-45-eric.curtin@docker.com> (raw)
In-Reply-To: <20260319202509.63802-1-eric.curtin@docker.com>
From: Iouri Tarassov <iourit@linux.microsoft.com>
Implement an escape to build test command buffer.
Implement other known escapes.
Signed-off-by: Iouri Tarassov <iourit@linux.microsoft.com>
[kms: forward port to 6.6 from 6.1. No code changes made.]
Signed-off-by: Kelsey Steele <kelseysteele@microsoft.com>
---
drivers/hv/dxgkrnl/dxgkrnl.h | 3 +-
drivers/hv/dxgkrnl/dxgvmbus.c | 40 +++++---
drivers/hv/dxgkrnl/ioctl.c | 170 +++++++++++++++++++++++++++++-----
include/uapi/misc/d3dkmthk.h | 31 +++++++
4 files changed, 205 insertions(+), 39 deletions(-)
diff --git a/drivers/hv/dxgkrnl/dxgkrnl.h b/drivers/hv/dxgkrnl/dxgkrnl.h
index ebf81cffa289..9599ec8e0f1d 100644
--- a/drivers/hv/dxgkrnl/dxgkrnl.h
+++ b/drivers/hv/dxgkrnl/dxgkrnl.h
@@ -953,7 +953,8 @@ int dxgvmb_send_query_alloc_residency(struct dxgprocess *process,
*args);
int dxgvmb_send_escape(struct dxgprocess *process,
struct dxgadapter *adapter,
- struct d3dkmt_escape *args);
+ struct d3dkmt_escape *args,
+ bool user_mode);
int dxgvmb_send_query_vidmem_info(struct dxgprocess *process,
struct dxgadapter *adapter,
struct d3dkmt_queryvideomemoryinfo *args,
diff --git a/drivers/hv/dxgkrnl/dxgvmbus.c b/drivers/hv/dxgkrnl/dxgvmbus.c
index 2436e1a7bc73..de28c6162a70 100644
--- a/drivers/hv/dxgkrnl/dxgvmbus.c
+++ b/drivers/hv/dxgkrnl/dxgvmbus.c
@@ -2174,7 +2174,8 @@ int dxgvmb_send_query_alloc_residency(struct dxgprocess *process,
int dxgvmb_send_escape(struct dxgprocess *process,
struct dxgadapter *adapter,
- struct d3dkmt_escape *args)
+ struct d3dkmt_escape *args,
+ bool user_mode)
{
int ret;
struct dxgkvmb_command_escape *command = NULL;
@@ -2203,13 +2204,18 @@ int dxgvmb_send_escape(struct dxgprocess *process,
command->priv_drv_data_size = args->priv_drv_data_size;
command->context = args->context;
if (args->priv_drv_data_size) {
- ret = copy_from_user(command->priv_drv_data,
- args->priv_drv_data,
- args->priv_drv_data_size);
- if (ret) {
- DXG_ERR("failed to copy priv data");
- ret = -EFAULT;
- goto cleanup;
+ if (user_mode) {
+ ret = copy_from_user(command->priv_drv_data,
+ args->priv_drv_data,
+ args->priv_drv_data_size);
+ if (ret) {
+ DXG_ERR("failed to copy priv data");
+ ret = -EFAULT;
+ goto cleanup;
+ }
+ } else {
+ memcpy(command->priv_drv_data, args->priv_drv_data,
+ args->priv_drv_data_size);
}
}
@@ -2220,12 +2226,18 @@ int dxgvmb_send_escape(struct dxgprocess *process,
goto cleanup;
if (args->priv_drv_data_size) {
- ret = copy_to_user(args->priv_drv_data,
- command->priv_drv_data,
- args->priv_drv_data_size);
- if (ret) {
- DXG_ERR("failed to copy priv data");
- ret = -EINVAL;
+ if (user_mode) {
+ ret = copy_to_user(args->priv_drv_data,
+ command->priv_drv_data,
+ args->priv_drv_data_size);
+ if (ret) {
+ DXG_ERR("failed to copy priv data");
+ ret = -EINVAL;
+ }
+ } else {
+ memcpy(args->priv_drv_data,
+ command->priv_drv_data,
+ args->priv_drv_data_size);
}
}
diff --git a/drivers/hv/dxgkrnl/ioctl.c b/drivers/hv/dxgkrnl/ioctl.c
index 5ff4b27af19d..f8ca79d098f3 100644
--- a/drivers/hv/dxgkrnl/ioctl.c
+++ b/drivers/hv/dxgkrnl/ioctl.c
@@ -4257,10 +4257,8 @@ dxgkio_change_vidmem_reservation(struct dxgprocess *process, void *__user inargs
}
ret = dxgadapter_acquire_lock_shared(adapter);
- if (ret < 0) {
- adapter = NULL;
+ if (ret < 0)
goto cleanup;
- }
adapter_locked = true;
args.adapter.v = 0;
ret = dxgvmb_send_change_vidmem_reservation(process, adapter,
@@ -4299,10 +4297,8 @@ dxgkio_query_clock_calibration(struct dxgprocess *process, void *__user inargs)
}
ret = dxgadapter_acquire_lock_shared(adapter);
- if (ret < 0) {
- adapter = NULL;
+ if (ret < 0)
goto cleanup;
- }
adapter_locked = true;
args.adapter = adapter->host_handle;
@@ -4349,10 +4345,8 @@ dxgkio_flush_heap_transitions(struct dxgprocess *process, void *__user inargs)
}
ret = dxgadapter_acquire_lock_shared(adapter);
- if (ret < 0) {
- adapter = NULL;
+ if (ret < 0)
goto cleanup;
- }
adapter_locked = true;
args.adapter = adapter->host_handle;
@@ -4417,6 +4411,134 @@ dxgkio_invalidate_cache(struct dxgprocess *process, void *__user inargs)
return ret;
}
+static int
+build_test_command_buffer(struct dxgprocess *process,
+ struct dxgadapter *adapter,
+ struct d3dkmt_escape *args)
+{
+ int ret;
+ struct d3dddi_buildtestcommandbuffer cmd;
+ struct d3dkmt_escape newargs = *args;
+ u32 buf_size;
+ struct d3dddi_buildtestcommandbuffer *buf = NULL;
+ struct d3dddi_buildtestcommandbuffer *__user ucmd;
+
+ ucmd = args->priv_drv_data;
+ if (args->priv_drv_data_size <
+ sizeof(struct d3dddi_buildtestcommandbuffer)) {
+ DXG_ERR("Invalid private data size");
+ return -EINVAL;
+ }
+ ret = copy_from_user(&cmd, ucmd, sizeof(cmd));
+ if (ret) {
+ DXG_ERR("Failed to copy private data");
+ return -EFAULT;
+ }
+
+ if (cmd.dma_buffer_size < sizeof(u32) ||
+ cmd.dma_buffer_size > D3DDDI_MAXTESTBUFFERSIZE ||
+ cmd.dma_buffer_priv_data_size >
+ D3DDDI_MAXTESTBUFFERPRIVATEDRIVERDATASIZE) {
+ DXG_ERR("Invalid DMA buffer or private data size");
+ return -EINVAL;
+ }
+ /* Allocate a new buffer for the escape call */
+ buf_size = sizeof(struct d3dddi_buildtestcommandbuffer) +
+ cmd.dma_buffer_size +
+ cmd.dma_buffer_priv_data_size;
+ buf = vzalloc(buf_size);
+ if (buf == NULL) {
+ ret = -ENOMEM;
+ goto cleanup;
+ }
+ *buf = cmd;
+ buf->dma_buffer = NULL;
+ buf->dma_buffer_priv_data = NULL;
+
+ /* Replace private data in the escape arguments and call the host */
+ newargs.priv_drv_data = buf;
+ newargs.priv_drv_data_size = buf_size;
+ ret = dxgvmb_send_escape(process, adapter, &newargs, false);
+ if (ret) {
+ DXG_ERR("Host failed escape");
+ goto cleanup;
+ }
+
+ ret = copy_to_user(&ucmd->dma_buffer_size, &buf->dma_buffer_size,
+ sizeof(u32));
+ if (ret) {
+ DXG_ERR("Failed to dma size to user");
+ ret = -EFAULT;
+ goto cleanup;
+ }
+ ret = copy_to_user(&ucmd->dma_buffer_priv_data_size,
+ &buf->dma_buffer_priv_data_size,
+ sizeof(u32));
+ if (ret) {
+ DXG_ERR("Failed to dma private data size to user");
+ ret = -EFAULT;
+ goto cleanup;
+ }
+ ret = copy_to_user(cmd.dma_buffer, (char *)buf + sizeof(*buf),
+ buf->dma_buffer_size);
+ if (ret) {
+ DXG_ERR("Failed to copy dma buffer to user");
+ ret = -EFAULT;
+ goto cleanup;
+ }
+ if (buf->dma_buffer_priv_data_size) {
+ ret = copy_to_user(cmd.dma_buffer_priv_data,
+ (char *)buf + sizeof(*buf) + cmd.dma_buffer_size,
+ buf->dma_buffer_priv_data_size);
+ if (ret) {
+ DXG_ERR("Failed to copy private data to user");
+ ret = -EFAULT;
+ goto cleanup;
+ }
+ }
+
+cleanup:
+ if (buf)
+ vfree(buf);
+ return ret;
+}
+
+static int
+driver_known_escape(struct dxgprocess *process,
+ struct dxgadapter *adapter,
+ struct d3dkmt_escape *args)
+{
+ enum d3dkmt_escapetype escape_type;
+ int ret = 0;
+
+ if (args->priv_drv_data_size < sizeof(enum d3dddi_knownescapetype))
+ {
+ DXG_ERR("Invalid private data size");
+ return -EINVAL;
+ }
+ ret = copy_from_user(&escape_type, args->priv_drv_data,
+ sizeof(escape_type));
+ if (ret) {
+ DXG_ERR("Failed to read escape type");
+ return -EFAULT;
+ }
+ switch (escape_type) {
+ case _D3DDDI_DRIVERESCAPETYPE_TRANSLATEALLOCATIONHANDLE:
+ case _D3DDDI_DRIVERESCAPETYPE_TRANSLATERESOURCEHANDLE:
+ /*
+ * The host and VM handles are the same
+ */
+ break;
+ case _D3DDDI_DRIVERESCAPETYPE_BUILDTESTCOMMANDBUFFER:
+ ret = build_test_command_buffer(process, adapter, args);
+ break;
+ default:
+ ret = dxgvmb_send_escape(process, adapter, args, true);
+ break;
+ }
+ return ret;
+}
+
static int
dxgkio_escape(struct dxgprocess *process, void *__user inargs)
{
@@ -4438,14 +4560,17 @@ dxgkio_escape(struct dxgprocess *process, void *__user inargs)
}
ret = dxgadapter_acquire_lock_shared(adapter);
- if (ret < 0) {
- adapter = NULL;
+ if (ret < 0)
goto cleanup;
- }
adapter_locked = true;
args.adapter = adapter->host_handle;
- ret = dxgvmb_send_escape(process, adapter, &args);
+
+ if (args.type == _D3DKMT_ESCAPE_DRIVERPRIVATE &&
+ args.flags.driver_known_escape)
+ ret = driver_known_escape(process, adapter, &args);
+ else
+ ret = dxgvmb_send_escape(process, adapter, &args, true);
cleanup:
@@ -4485,10 +4610,8 @@ dxgkio_query_vidmem_info(struct dxgprocess *process, void *__user inargs)
}
ret = dxgadapter_acquire_lock_shared(adapter);
- if (ret < 0) {
- adapter = NULL;
+ if (ret < 0)
goto cleanup;
- }
adapter_locked = true;
args.adapter = adapter->host_handle;
@@ -5323,9 +5446,9 @@ dxgkio_is_feature_enabled(struct dxgprocess *process, void *__user inargs)
{
struct d3dkmt_isfeatureenabled args;
struct dxgadapter *adapter = NULL;
- struct dxgglobal *dxgglobal = dxggbl();
struct d3dkmt_isfeatureenabled *__user uargs = inargs;
int ret;
+ bool adapter_locked = false;
ret = copy_from_user(&args, inargs, sizeof(args));
if (ret) {
@@ -5340,11 +5463,10 @@ dxgkio_is_feature_enabled(struct dxgprocess *process, void *__user inargs)
goto cleanup;
}
- if (adapter) {
- ret = dxgadapter_acquire_lock_shared(adapter);
- if (ret < 0)
- goto cleanup;
- }
+ ret = dxgadapter_acquire_lock_shared(adapter);
+ if (ret < 0)
+ goto cleanup;
+ adapter_locked = true;
ret = dxgvmb_send_is_feature_enabled(adapter, &args);
if (ret)
@@ -5354,10 +5476,10 @@ dxgkio_is_feature_enabled(struct dxgprocess *process, void *__user inargs)
cleanup:
- if (adapter) {
+ if (adapter_locked)
dxgadapter_release_lock_shared(adapter);
+ if (adapter)
kref_put(&adapter->adapter_kref, dxgadapter_release);
- }
DXG_TRACE_IOCTL_END(ret);
return ret;
diff --git a/include/uapi/misc/d3dkmthk.h b/include/uapi/misc/d3dkmthk.h
index 5b345ddaf66e..db40e8ff40b0 100644
--- a/include/uapi/misc/d3dkmthk.h
+++ b/include/uapi/misc/d3dkmthk.h
@@ -237,6 +237,37 @@ struct d3dddi_destroypagingqueue {
struct d3dkmthandle paging_queue;
};
+enum d3dddi_knownescapetype {
+ _D3DDDI_DRIVERESCAPETYPE_TRANSLATEALLOCATIONHANDLE = 0,
+ _D3DDDI_DRIVERESCAPETYPE_TRANSLATERESOURCEHANDLE = 1,
+ _D3DDDI_DRIVERESCAPETYPE_CPUEVENTUSAGE = 2,
+ _D3DDDI_DRIVERESCAPETYPE_BUILDTESTCOMMANDBUFFER = 3,
+};
+
+struct d3dddi_translate_allocation_handle {
+ enum d3dddi_knownescapetype escape_type;
+ struct d3dkmthandle allocation;
+};
+
+struct d3dddi_testcommand {
+ char buffer[72];
+};
+
+#define D3DDDI_MAXTESTBUFFERSIZE 4096
+#define D3DDDI_MAXTESTBUFFERPRIVATEDRIVERDATASIZE 1024
+
+struct d3dddi_buildtestcommandbuffer {
+ enum d3dddi_knownescapetype escape_type;
+ struct d3dkmthandle device;
+ struct d3dkmthandle context;
+ __u32 flags;
+ struct d3dddi_testcommand command;
+ void *dma_buffer;
+ void *dma_buffer_priv_data;
+ __u32 dma_buffer_size;
+ __u32 dma_buffer_priv_data_size;
+};
+
enum d3dkmt_escapetype {
_D3DKMT_ESCAPE_DRIVERPRIVATE = 0,
_D3DKMT_ESCAPE_VIDMM = 1,
next prev parent reply other threads:[~2026-03-19 20:26 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 20:24 [PATCH v4 00/55] drivers: hv: dxgkrnl: Driver for Hyper-V virtual compute device Eric Curtin
2026-03-19 20:24 ` [PATCH 01/55] drivers: hv: dxgkrnl: Driver initialization and loading Eric Curtin
2026-03-19 20:24 ` [PATCH 02/55] drivers: hv: dxgkrnl: Add VMBus message support, initialize VMBus channels Eric Curtin
2026-03-19 20:24 ` [PATCH 03/55] drivers: hv: dxgkrnl: Creation of dxgadapter object Eric Curtin
2026-03-19 20:24 ` [PATCH 04/55] drivers: hv: dxgkrnl: Opening of /dev/dxg device and dxgprocess creation Eric Curtin
2026-03-19 20:24 ` [PATCH 05/55] drivers: hv: dxgkrnl: Enumerate and open dxgadapter objects Eric Curtin
2026-03-19 20:24 ` [PATCH 06/55] drivers: hv: dxgkrnl: Creation of dxgdevice objects Eric Curtin
2026-03-19 20:24 ` [PATCH 07/55] drivers: hv: dxgkrnl: Creation of dxgcontext objects Eric Curtin
2026-03-19 20:24 ` [PATCH 08/55] drivers: hv: dxgkrnl: Creation of compute device allocations and resources Eric Curtin
2026-03-19 20:24 ` [PATCH 09/55] drivers: hv: dxgkrnl: Creation of compute device sync objects Eric Curtin
2026-03-19 20:24 ` [PATCH 10/55] drivers: hv: dxgkrnl: Operations using " Eric Curtin
2026-03-19 20:24 ` [PATCH 11/55] drivers: hv: dxgkrnl: Sharing of dxgresource objects Eric Curtin
2026-03-19 20:24 ` [PATCH 12/55] drivers: hv: dxgkrnl: Sharing of sync objects Eric Curtin
2026-03-19 20:24 ` [PATCH 13/55] drivers: hv: dxgkrnl: Creation of paging queue objects Eric Curtin
2026-03-19 20:24 ` [PATCH 14/55] drivers: hv: dxgkrnl: Submit execution commands to the compute device Eric Curtin
2026-03-19 20:24 ` [PATCH 15/55] drivers: hv: dxgkrnl: Share objects with the host Eric Curtin
2026-03-19 20:24 ` [PATCH 16/55] drivers: hv: dxgkrnl: Query the dxgdevice state Eric Curtin
2026-03-19 20:24 ` [PATCH 17/55] drivers: hv: dxgkrnl: Map(unmap) CPU address to device allocation Eric Curtin
2026-03-19 20:24 ` [PATCH 18/55] drivers: hv: dxgkrnl: Manage device allocation properties Eric Curtin
2026-03-19 20:24 ` [PATCH 19/55] drivers: hv: dxgkrnl: Flush heap transitions Eric Curtin
2026-03-19 20:24 ` [PATCH 20/55] drivers: hv: dxgkrnl: Query video memory information Eric Curtin
2026-03-19 20:24 ` [PATCH 21/55] drivers: hv: dxgkrnl: The escape ioctl Eric Curtin
2026-03-19 20:24 ` [PATCH 22/55] drivers: hv: dxgkrnl: Ioctl to put device to error state Eric Curtin
2026-03-19 20:24 ` [PATCH 23/55] drivers: hv: dxgkrnl: Ioctls to query statistics and clock calibration Eric Curtin
2026-03-19 20:24 ` [PATCH 24/55] drivers: hv: dxgkrnl: Offer and reclaim allocations Eric Curtin
2026-03-19 20:24 ` [PATCH 25/55] drivers: hv: dxgkrnl: Ioctls to manage scheduling priority Eric Curtin
2026-03-19 20:24 ` [PATCH 26/55] drivers: hv: dxgkrnl: Manage residency of allocations Eric Curtin
2026-03-19 20:24 ` [PATCH 27/55] drivers: hv: dxgkrnl: Manage compute device virtual addresses Eric Curtin
2026-03-19 20:24 ` [PATCH 28/55] drivers: hv: dxgkrnl: Add support to map guest pages by host Eric Curtin
2026-03-19 20:24 ` [PATCH 29/55] drivers: hv: dxgkrnl: Removed struct vmbus_gpadl, which was defined in the main linux branch Eric Curtin
2026-03-19 20:24 ` [PATCH 30/55] drivers: hv: dxgkrnl: Remove dxgk_init_ioctls Eric Curtin
2026-03-19 20:24 ` [PATCH 31/55] drivers: hv: dxgkrnl: Creation of dxgsyncfile objects Eric Curtin
2026-03-19 20:24 ` [PATCH 32/55] drivers: hv: dxgkrnl: Use tracing instead of dev_dbg Eric Curtin
2026-03-19 20:24 ` [PATCH 33/55] drivers: hv: dxgkrnl: Implement D3DKMTWaitSyncFile Eric Curtin
2026-03-19 20:24 ` [PATCH 34/55] drivers: hv: dxgkrnl: Improve tracing and return values from copy from user Eric Curtin
2026-03-19 20:24 ` [PATCH 35/55] drivers: hv: dxgkrnl: Fix synchronization locks Eric Curtin
2026-03-19 20:24 ` [PATCH 36/55] drivers: hv: dxgkrnl: Close shared file objects in case of a failure Eric Curtin
2026-03-19 20:24 ` [PATCH 37/55] drivers: hv: dxgkrnl: Added missed NULL check for resource object Eric Curtin
2026-03-19 20:24 ` [PATCH 38/55] drivers: hv: dxgkrnl: Fixed dxgkrnl to build for the 6.1 kernel Eric Curtin
2026-03-19 20:24 ` [PATCH 39/55] drivers: hv: dxgkrnl: Added support for compute only adapters Eric Curtin
2026-03-19 20:24 ` [PATCH 40/55] drivers: hv: dxgkrnl: Added implementation for D3DKMTInvalidateCache Eric Curtin
2026-03-19 20:24 ` [PATCH 41/55] drivers: hv: dxgkrnl: Handle process ID in D3DKMTQueryStatistics Eric Curtin
2026-03-19 20:24 ` [PATCH 42/55] drivers: hv: dxgkrnl: Implement the D3DKMTEnumProcesses API Eric Curtin
2026-03-19 20:24 ` [PATCH 43/55] drivers: hv: dxgkrnl: Implement D3DDKMTIsFeatureEnabled API Eric Curtin
2026-03-19 20:24 ` Eric Curtin [this message]
2026-03-19 20:24 ` [PATCH 45/55] drivers: hv: dxgkrnl: Fixed coding style issues Eric Curtin
2026-03-19 20:25 ` [PATCH 46/55] drivers: hv: dxgkrnl: Fixed the implementation of D3DKMTQueryClockCalibration Eric Curtin
2026-03-19 20:25 ` [PATCH 47/55] drivers: hv: dxgkrnl: Retry sending a VM bus packet when there is no place in the ring buffer Eric Curtin
2026-03-19 20:25 ` [PATCH 48/55] drivers: hv: dxgkrnl: Add support for locking a shared allocation by not the owner Eric Curtin
2026-03-19 20:25 ` [PATCH 49/55] drivers: hv: dxgkrnl: Fix build breaks when switching to 6.6 kernel due to hv_driver remove callback change Eric Curtin
2026-03-19 20:25 ` [PATCH 50/55] drivers: hv: dxgkrnl: Fix build breaks when switching to 6.6 kernel due to removed uuid_le_cmp Eric Curtin
2026-03-19 20:25 ` [PATCH 51/55] drivers: hv: dxgkrnl: Implement D3DKMTEnumProcesses to match the Windows implementation Eric Curtin
2026-03-19 20:25 ` [PATCH 52/55] drivers: hv: dxgkrnl: Use pin_user_pages instead of get_user_pages for DMA accessible memory Eric Curtin
2026-03-19 20:25 ` [PATCH 53/55] drivers: hv: dxgkrnl: Do not print error messages when virtual GPU is not present Eric Curtin
2026-03-19 20:25 ` [PATCH 54/55] drivers: hv: dxgkrnl: Fix crash at hmgrtable_free_handle Eric Curtin
2026-03-19 20:25 ` [PATCH 55/55] drivers: hv: dxgkrnl: Code cleanup for upstream submission Eric Curtin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319202509.63802-45-eric.curtin@docker.com \
--to=ericcurtin17@gmail.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=iourit@linux.microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox