From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF45D1D435F; Mon, 13 Apr 2026 05:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776057010; cv=none; b=Tc/jy+QfGNsP09gsrvPhFIWtC/mICTU6ypYv8/ACjX8ncp0dSZR+arCNHzPfLGI1sKd376Yeikqd37SEMZVtMqXUHg6tqda2Glu5b25d/5cTuZ1j2JA7ZGHdpASO+K6fJ5b6oTA0oZKD3HDKo1lidZNS6MJpmVmlWiznDGnn13Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776057010; c=relaxed/simple; bh=S1RPgc3ieNbPHCWODeWvLFxJmmZA72lpp1jJb4Hx9Lc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sEpcM5+J9hwViQtbZ9zxnN8BOH66IMZaJzJKQSYPmcuGEfmd26lChxf9LBxOCyO4JEUqGV0L2yRobnz4FPqpIGyJuR6xCxX8NdcIL529UkCwQcDJ9ZONWp0a/cF6oajfwpR35ATC8pXdV+DsHlPTk2gaIxsjKF7ILlYYVsxadvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=eEZRuUCN; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="eEZRuUCN" Received: by linux.microsoft.com (Postfix, from userid 1173) id E109C20B6F01; Sun, 12 Apr 2026 22:10:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E109C20B6F01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1776057008; bh=r8/mdOBpoRRMgRcF8KxeNZyoEUm662XAFr49YQ9Uozw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=eEZRuUCNCelhvESpqgBV4iB3bvNepOdMhoFgnbZf6/nZ1sJtrJ2ljqyfz5USu+E85 0ouzPlmIdIgc4k8Aie+lF/FtLU4R4VVIoiOIqU2avQg45zMARFhRtM7U26TSiB+ZIW sHJXd9gecyRjIbhvrNDkd8W2U87WchE/eyH3v1Mk= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 4/4] net: mana: Fix EQ leak in mana_remove on NULL port Date: Sun, 12 Apr 2026 22:08:40 -0700 Message-ID: <20260413050843.605789-5-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260413050843.605789-1-ernis@linux.microsoft.com> References: <20260413050843.605789-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In mana_remove(), when a NULL port is encountered in the port iteration loop, 'goto out' skips the mana_destroy_eq(ac) call, leaking the event queues allocated earlier by mana_create_eq(). This can happen when mana_probe_port() fails for port 0, leaving ac->ports[0] as NULL. On driver unload or error cleanup, mana_remove() hits the NULL entry and jumps past mana_destroy_eq(). Change 'goto out' to 'break' so the for-loop exits normally and mana_destroy_eq() is always reached. Remove the now-unreferenced out: label. Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Signed-off-by: Erni Sri Satya Vennela --- Changes in v2: * Apply the patch in net instead of net-next. --- drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index 1a141c46ac27..97237d137cbf 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3747,7 +3747,7 @@ void mana_remove(struct gdma_dev *gd, bool suspending) if (!ndev) { if (i == 0) dev_err(dev, "No net device to remove\n"); - goto out; + break; } apc = netdev_priv(ndev); @@ -3778,7 +3778,7 @@ void mana_remove(struct gdma_dev *gd, bool suspending) } mana_destroy_eq(ac); -out: + if (ac->per_port_queue_reset_wq) { destroy_workqueue(ac->per_port_queue_reset_wq); ac->per_port_queue_reset_wq = NULL; -- 2.34.1