From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E883D902A; Tue, 14 Apr 2026 15:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776181267; cv=none; b=KRjj0Iun4/u/mt3Syot24/bEy3uXJDOKW1QOBdd4E8bMVUilnCl3XQiAy70P/Jt1CJs6uOaEE4F9/Rx+C/BS4Etbf8+gerKfQgVOQV10M3MM6kwHROvdNEVuyLFjqdB1/0q0jKNvjEsB5YsZCDVC7buBo8Ti/ya4Fu56Cj4DDyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776181267; c=relaxed/simple; bh=YrmTD9eum045wyxGIEZt1HMiOH5MJ9kWS/wJfIDaWNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ix18uR1K+bjq1NMXQeLG8vqYJlY68feCPMLUMPEDUjqXvqM+OVRGlgm0HDxI8pKbjuFCIQGd5f7VSS+CA1LiZLioWowMkxQeDSA1YKTC7O9Xdn4Kvs8gBZD4FRmUXAdI77YaQ4O3p8+PzYM0RF4p1qtkajQHwCaik1g19VMm25M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZKS7uiiz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZKS7uiiz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA7D8C19425; Tue, 14 Apr 2026 15:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776181267; bh=YrmTD9eum045wyxGIEZt1HMiOH5MJ9kWS/wJfIDaWNw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZKS7uiiz1giGWkML/vR5PNrWYhEtX/07uokO0jOQcvzbe5WP2laoXgpEUvpCrv1kd YEvd7IdD0+k7CkWz9V+HBLyP4n51hq6Jelf5WSWHka6ySsBFFCIq5Kvy6x8393OKnU 2OR2bPHA4Y3INR8RdlMvT86Ss0zde+LCMVKWZAM8qoVD5JDGKS5hdjBjk+7MlQ3Xe1 c9UocBs1Zdcsjc/Jpv2HFtVrzbf0YmzGFWMgY0L/Qqg1BreOFMwBsctKw+hi8xRZiT GnX3UdbKd0i1FXOGqXph1b6xoefed+C993+QRdEQGTaUivyh7I63lFk/aNQzewllo/ qibTSXn+nWJDw== From: Simon Horman To: ernis@linux.microsoft.com Cc: Simon Horman , pabeni@redhat.com, edumazet@google.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, decui@microsoft.com, shacharr@microsoft.com, linux-hyperv@vger.kernel.org, kotaranov@microsoft.com, kys@microsoft.com, shirazsaleem@microsoft.com, longli@microsoft.com, kuba@kernel.org, andrew+netdev@lunn.ch, wei.liu@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, haiyangz@microsoft.com, kees@kernel.org, stephen@networkplumber.org, leon@kernel.org, davem@davemloft.net Subject: Re: [PATCH net v2 4/4] net: mana: Fix EQ leak in mana_remove on NULL port Date: Tue, 14 Apr 2026 16:40:58 +0100 Message-ID: <20260414154058.771241-1-horms@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413050843.605789-5-ernis@linux.microsoft.com> References: <20260413050843.605789-5-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- net: mana: Fix EQ leak in mana_remove on NULL port In mana_remove(), when a NULL port is encountered in the port iteration loop, 'goto out' skips the mana_destroy_eq(ac) call, leaking the event queues allocated earlier by mana_create_eq(). This can happen when mana_probe_port() fails for port 0, leaving ac->ports[0] as NULL. On driver unload or error cleanup, mana_remove() hits the NULL entry and jumps past mana_destroy_eq(). Change 'goto out' to 'break' so the for-loop exits normally and mana_destroy_eq() is always reached. > Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Does this Fixes tag point to the correct commit? Looking at the commit history, the original driver commit ca9c54d2d6a5 did not have mana_destroy_eq() in mana_remove() at all, so the 'goto out' pattern could not have caused an EQ leak at that point. The bug appears to have been introduced by commit 1e2d0824a9c3 ("net: mana: Add support for EQ sharing"), which added mana_destroy_eq(ac) to mana_remove() and placed it after the 'out:' label, making it skippable by the 'goto out' on NULL port. Should the Fixes tag be: Fixes: 1e2d0824a9c3 ("net: mana: Add support for EQ sharing")