From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 311CC27E1DC; Fri, 17 Apr 2026 14:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776434927; cv=none; b=mOOowEopy+8yeh6wklI0lFhW0yGYRLWAVVTLRnjUyPxR025oMTGe5PNIjN0Iuh37Qg6UiMq6NcqVvEHZrLJM/oeIWVcv2rfLcKh9Vy2nwBOvQspIFAL3hxaBRiN9Xh76UeHFUAm7vruiJgUzbOpmmiViYWAcJsO6XnfUR7sc9P4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776434927; c=relaxed/simple; bh=5trXQSOgOJ7eFKoDmo6UoUhSEJRJR8wzR8pcrXIc12I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gWDSAymy9td8GW+zNbCrxZfjPTPQdCse+dXy1Nkh4IyObnxG33JvXfbhCUmpF0/T1j2RvzSopqHEpBKTT3imFrD+LbFnPshVrhaDdk569n+SuM3HoTzcM11qyrqM5EZeEn5W/lxJRfl3tyFqU6fWoIGMHsnAUnA9MyuyfZVwqOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WMbQCh9t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WMbQCh9t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B1E0C2BCB6; Fri, 17 Apr 2026 14:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776434927; bh=5trXQSOgOJ7eFKoDmo6UoUhSEJRJR8wzR8pcrXIc12I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WMbQCh9tAYm3Q2aALGdhquuFDQcf70jSZZ0keHsbDm7znhcIOYBXcbjQFti/ktdYH 715iBlUJnWMVTXgQKk03NJMJhGdi+EMjtjcBFu6XughhjtjTMGtWWgpoJjzywmB4p5 SwVny0kAb33R6RFK+h4U1VNZgoV/5C/zhCwa/7CGUlqOihmq/Gl4t7lEKk3h4GDXzZ bcseNyHarfSjfBf/22+BIPU5DOk4mNvrOirbWU8lMVtFyZUTkptapWgEmcC3kAvw91 1gri5WfOqsU2NuXDUxzZRVS12baqdX02WcpTXhBDJPl7XjrsTTGQW6Z3IPBw901OqS 8wmP8cRRgIWHA== Date: Fri, 17 Apr 2026 15:08:39 +0100 From: Simon Horman To: Erni Sri Satya Vennela Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3 2/5] net: mana: Init gf_stats_work before potential error paths in probe Message-ID: <20260417140839.GE31784@horms.kernel.org> References: <20260415080944.732901-1-ernis@linux.microsoft.com> <20260415080944.732901-3-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415080944.732901-3-ernis@linux.microsoft.com> On Wed, Apr 15, 2026 at 01:09:38AM -0700, Erni Sri Satya Vennela wrote: > Move INIT_DELAYED_WORK(gf_stats_work) to before mana_create_eq(), > while keeping schedule_delayed_work() at its original location. > > Previously, if any function between mana_create_eq() and the > INIT_DELAYED_WORK call failed, mana_probe() would call mana_remove() > which unconditionally calls cancel_delayed_work_sync(gf_stats_work) > in __flush_work() or debug object warnings with > CONFIG_DEBUG_OBJECTS_WORK enabled. > > Fixes: be4f1d67ec56 ("net: mana: Add standard counter rx_missed_errors") > Signed-off-by: Erni Sri Satya Vennela > --- > Changes in v3: > * No change > Changes in v2: > * Apply the patch in net instead of net-next. Reviewed-by: Simon Horman