From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-of-o54.zoho.com (sender4-of-o54.zoho.com [136.143.188.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60F793B5304; Wed, 29 Apr 2026 09:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.54 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777456749; cv=pass; b=A24k//BVk7MkBOI96xrNUXM7UxAn9Ag6SSFjP/915XJU5ACHmM5pWWkPTn8Zf+Xvj8k0u6/OyIZv0UG6Q1c6wj/3zezzJCZ39EPEW7XGdgWyCQfc3BJidww15GIFw/FDGxPrzCBxCiN7kc8Je1+cDwPYPbUwZQkSERDaUvnSyok= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777456749; c=relaxed/simple; bh=lXLV5RuuztwQv/9vqhAXh6mReJtqqSvMU9NvBQzL0GY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rSJPSHLkm0k8DpTvmxTCsCTVDERetfLeTzLcQ7Xbj2gju7mPSUPFiWToUmyu2RmkY3srtYKvjg5LTkFkf0iDDaacboLcyBxnCBlSd2nCWbRLIbDI+LshNmmF4oJVF22JZeO69vM96QGI0Cl7EpuJre66ji4PSJNRALyN09c80H0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=anirudhrb.com; spf=pass smtp.mailfrom=anirudhrb.com; dkim=pass (1024-bit key) header.d=anirudhrb.com header.i=anirudh@anirudhrb.com header.b=FFJ9vHnj; arc=pass smtp.client-ip=136.143.188.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=anirudhrb.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=anirudhrb.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=anirudhrb.com header.i=anirudh@anirudhrb.com header.b="FFJ9vHnj" ARC-Seal: i=1; a=rsa-sha256; t=1777456727; cv=none; d=zohomail.com; s=zohoarc; b=cIWt9xAWrdzMNTWwRVXgoerdmeoZ6Sr/lFB2AQ3BMxuiuBRTeo3JLkrSBXLwKJh+wesn99cjBj6Mz3fK26GfPbcBhv8vECqIqsuR4tlMtToC/rIcCevK3jBYb97iYUYUgE1QZBFka/nBMcYUdmDevZYLJc8QKZbvhN6ntpHAZMg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777456727; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=iX7P9wk0N+hjbsv3e1etMxA/H/6GGHLzR7d21GExkjo=; b=FwZ/PVvAo4gQtPR4hurim+a0a+6EDy+hmxk0xPHUnnBOeQNtsaoqqWd0nkizHmmpYcqe/nsvxfMXfTKFjjYgiC8R78UyWwPNfFPHFXcMJIaGQjy+rU5SQIymJwXdtt9Vtv8FHMHGYh8bq5pJXHkEq7tCWV2gM+QQnVpndVv8ocU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=anirudhrb.com; spf=pass smtp.mailfrom=anirudh@anirudhrb.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1777456727; s=zoho; d=anirudhrb.com; i=anirudh@anirudhrb.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=iX7P9wk0N+hjbsv3e1etMxA/H/6GGHLzR7d21GExkjo=; b=FFJ9vHnjS/NYmpO7eHyYut8zB3EZKq2fhkWVPd0EvPV5+jG2vxg48sM2LeI7YIGZ WvgQua0Mc3KPd4lpl2E4CkImG5tAKYLPfVZ9Ibwu5+TB4F7d7InCppT5gClYxayEpWr +CWuewxR0lhM5LCXLbQLbYq4jVZXZprFqmL6ylTU= Received: by mx.zohomail.com with SMTPS id 177745672421517.47327517723204; Wed, 29 Apr 2026 02:58:44 -0700 (PDT) Date: Wed, 29 Apr 2026 09:58:38 +0000 From: Anirudh Rayabharam To: Jork Loeser Cc: linux-hyperv@vger.kernel.org, x86@kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Arnd Bergmann , Michael Kelley , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4 2/3] mshv: clean up SynIC state on kexec for L1VH Message-ID: <20260429-whispering-vegan-emu-caff87@anirudhrb> References: <20260427213855.1675044-1-jloeser@linux.microsoft.com> <20260427213855.1675044-3-jloeser@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427213855.1675044-3-jloeser@linux.microsoft.com> X-ZohoMailClient: External On Mon, Apr 27, 2026 at 02:38:53PM -0700, Jork Loeser wrote: > The reboot notifier that tears down the SynIC cpuhp state guards the > cleanup with hv_root_partition(), so on L1VH (where > hv_root_partition() is false) SINT0, SINT5, and SIRBP are never > cleaned up before kexec. The kexec'd kernel then inherits stale > unmasked SINTs and an enabled SIRBP pointing to freed memory. > > Remove the hv_root_partition() guard so the cleanup runs for all > parent partitions. > > Signed-off-by: Jork Loeser > --- > drivers/hv/mshv_synic.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/hv/mshv_synic.c b/drivers/hv/mshv_synic.c > index 2db3b0192eac..978a1cace341 100644 > --- a/drivers/hv/mshv_synic.c > +++ b/drivers/hv/mshv_synic.c > @@ -723,9 +723,6 @@ mshv_unregister_doorbell(u64 partition_id, int doorbell_portid) > static int mshv_synic_reboot_notify(struct notifier_block *nb, > unsigned long code, void *unused) > { > - if (!hv_root_partition()) > - return 0; > - > cpuhp_remove_state(synic_cpuhp_online); > return 0; > } > -- > 2.43.0 > Reviewed-by: Anirudh Rayabharam (Microsoft)