From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 148CA12B143 for ; Sat, 16 May 2026 04:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778904334; cv=none; b=oXQ22n/H3GgFOHC402L470com6IUA0FZaG6SRp4ofEVoj3LJmJq9SQbQpddekkOQebsRIepLG2FTXy8t4TsaKFwCgM5a74bv1EBZeLbT9ql6EvkaE2oZ4As6iU+v/Xl2kS//22vqkd0sAh0TwWatrXL/oCNB0Ls6W3zmnLz0w2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778904334; c=relaxed/simple; bh=LZ/FaQSw/adFN5x6lhsuoaV3q3HNG6O2DtcVJTM/LDE=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=bkiL+oFg0d35/GYgQJHZShdvMbjpSKVmIJ+quLB0E8qZ7Y0TmGJIHg/7CJibg1G9A7KldDQCtDVxeagSkSVETepCYU3bmg4ELPwT5GGVTbCoCVXSKZFCZsOQhcYmPFPCHlXYRflkul6JbW6h7SEmXS+Yn3xwKoYjrVFOMsLjEpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mInEw8mQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mInEw8mQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C84C0C19425; Sat, 16 May 2026 04:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778904333; bh=LZ/FaQSw/adFN5x6lhsuoaV3q3HNG6O2DtcVJTM/LDE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=mInEw8mQBgBM4BZgHjP04TLqobnTC9pXF+YWA/cIzpPfmP5ivORKVyYJD2jMEVaeA Pyj+lzwHS1t2lAE2plqOLyHmYQz4Tlqp6gm+Fh9vTkPTgZat132nn4VKQdz7VFtmG4 AuA3TbcTEnQGDnrV4gaGSKdAlOVfqRd22uKAW1iXFaGErmwDZ5lVCL/U0xLTYy3weE 8DyuCo92v1ZIuNvJ6COsgaL2ixz5ljcyjy2iksNRsNeU9yel+ww9vMNq0aDpQ2LfpJ U4xHzDKARyISaUv/hy+/JB8NwN9FSIfb8Y13o6DZlzurVRddqjnXzf1WzDfot4yqqI l0GeZOD8RYV4g== From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v10 5/6] net: mana: Allocate interrupt context for each EQ when creating vPort Reply-To: sashiko-reviews@lists.linux.dev To: "Long Li" Cc: linux-hyperv@vger.kernel.org In-Reply-To: <20260515040508.491748-6-longli@microsoft.com> References: <20260515040508.491748-6-longli@microsoft.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 16 May 2026 04:05:33 +0000 Message-Id: <20260516040533.C84C0C19425@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] The RDMA driver (mana_ib) fails to initialize because it does not = allocate GIC references for its EQs. -- commit 9f615e81497dbea890c8df0a9aa9efd643e9a6a7 Author: Long Li net: mana: Allocate interrupt context for each EQ when creating vPort This commit updates the driver to use GIC functions to create a dedicated interrupt context or acquire a shared interrupt context for each EQ when setting up a vPort. The caller is now responsible for acquiring and releasing the GIC reference across the EQ create/destroy lifecycle. > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/= ethernet/microsoft/mana/mana_en.c > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c [ ... ] > @@ -1684,12 +1690,22 @@ int mana_create_eq(struct mana_port_context *apc) > debugfs_create_dir("EQs", apc->mana_port_debugfs); > =20 > for (i =3D 0; i < apc->num_queues; i++) { > - spec.eq.msix_index =3D (i + 1) % gc->num_msix_usable; > + msi =3D (i + 1) % gc->num_msix_usable; > + > + gic =3D mana_gd_get_gic(gc, !gc->msi_sharing, &msi); > + if (!gic) { > + err =3D -ENOMEM; > + goto out; > + } > + spec.eq.msix_index =3D msi; Will this change to the initialization logic break the RDMA driver (mana_ib= )? Since the caller is now required to manually acquire a GIC reference via mana_gd_get_gic() before creating EQs, and mana_ib hasn't been updated to do this, won't it trigger a WARN_ON(!gic) inside mana_gd_register_irq() and fail device initialization? I noticed this was fixed later in the patch series by commit 'RDMA/mana_ib: Allocate interrupt contexts on EQs', but could this break bisectability her= e? > + > err =3D mana_gd_create_mana_eq(gd, &spec, &apc->eqs[i].eq); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260515040508.4917= 48-1-longli@microsoft.com?part=3D5