From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C9E6031327D; Mon, 8 Jun 2026 10:14:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780913647; cv=none; b=lfe7dl86/+qZJIxbg0MCqk99Zs8G8v4NU1EknhQLP3RDO+1yBSA3CriAxFmbcwqW4Z/Zua+EoCUwQkt5ctVgbttZ6dq3Y0i/PC4a1+APZgV8kJLmMScPq0YJPEr9gfLmL4pSZ9hpuL3Sj4f7vCKfSAveTLvp35rOuZ9E1NDwUlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780913647; c=relaxed/simple; bh=gC+onrXYGvy71kSebdmca8pRlTC0uWzgIwwWRfamJA8=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PCJJVnuA9HwEGAyBIkf4tdLPW6GZzT5zFnX7cYoX/SYcmpp7hkq2mdj+ejY0bp+2YBHHzH8zV4q9dog8hJkdkmF9ppFm0Jj46bVWCAABtl4YEBX/OpF0OONX1MNHEHKSCzcXFFEjRQiOJAPFEZ8D0SK7gqvf1efgklVvL+b/M6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=joPArdp8; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="joPArdp8" Received: by linux.microsoft.com (Postfix, from userid 1231) id E0C0220B716B; Mon, 8 Jun 2026 03:13:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E0C0220B716B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1780913627; bh=trhabQE42+25m+BwIKSJ5YnDXkksfcD+tHqcjwGCLsY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=joPArdp8YKKroAEhaNSmHzyT+frG4sQDIOAHgGTDvbHgo92DJn6P+GhtdDbAq8YoH 6uj7tFSnE3rBidRx/XXjPCIxPa7cwxpWXfAnoFtGxZJx3tuz+fzewhEmUTJTBtsuXu +CTBzW5H/kh/MG6LleOGu1sawH+u2+H/qZpRj1gg= From: Aditya Garg To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shradhagupta@linux.microsoft.com, dipayanroy@linux.microsoft.com, ernis@linux.microsoft.com, kees@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, gargaditya@microsoft.com, gargaditya@linux.microsoft.com, ssengar@linux.microsoft.com, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 2/2] net: mana: guard TX wq object destroy with INVALID_MANA_HANDLE check Date: Mon, 8 Jun 2026 03:13:41 -0700 Message-ID: <20260608101345.2267320-3-gargaditya@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260608101345.2267320-1-gargaditya@linux.microsoft.com> References: <20260608101345.2267320-1-gargaditya@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mana_create_txq() has several error paths (after mana_alloc_queues() or mana_create_wq_obj() failure) where tx_qp[i].tx_object stays as the INVALID_MANA_HANDLE sentinel set at allocation. mana_destroy_txq() then unconditionally calls mana_destroy_wq_obj() with (u64)-1, which firmware rejects and logs an error. Mirror the RX-side pattern in mana_destroy_rxq() and skip the destroy when the handle is still INVALID_MANA_HANDLE. Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Signed-off-by: Aditya Garg Reviewed-by: Dipayaan Roy Reviewed-by: Haiyang Zhang --- drivers/net/ethernet/microsoft/mana/mana_en.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index c9b1df1ed109..d7de4c4d25bb 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -2334,7 +2334,8 @@ static void mana_destroy_txq(struct mana_port_context *apc) netif_napi_del_locked(napi); apc->tx_qp[i].txq.napi_initialized = false; } - mana_destroy_wq_obj(apc, GDMA_SQ, apc->tx_qp[i].tx_object); + if (apc->tx_qp[i].tx_object != INVALID_MANA_HANDLE) + mana_destroy_wq_obj(apc, GDMA_SQ, apc->tx_qp[i].tx_object); mana_deinit_cq(apc, &apc->tx_qp[i].tx_cq); -- 2.43.0