From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0E7A44331D for ; Wed, 22 Jul 2026 21:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784756697; cv=none; b=AryGvt96TgfmTQFNR/zIdU/cp89jDaJwMsQb/6sGjC4mcoUJ+n1ANjNgFyv+xMzlSSFjbZi58pNoS+wYd7RusZprKbU6V5ZSUSWi+jTpkRN6sAse4+IA7GP+MjhreILhF5MLOIL14OF68pabSMW/a2XZSwSh1lD0kEW91EE9H00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784756697; c=relaxed/simple; bh=KaVy0LDD2WZ56zIlG4jDVljfxrz2j27JL0AnOSACkpk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XVL4MYHK6yrKayfELfgkQ+iwDzk2Qjp5FxVugqngt8I6Kr+5jNafGjPCOXRSvBGp/7Fsgo9rz6h7x3xRqgMUsP8uVHd0bg7IOg7xfgN5Ao1UEFQcvsH+K4AZOqq4FoBaDkalnmqLZOn3WQOs4wqgfsle5qyldThrM6DOUNB+r7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MjXGis/0; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MjXGis/0" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-84874b52eabso12804476b3a.0 for ; Wed, 22 Jul 2026 14:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784756695; x=1785361495; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WVIK4CTS2ebWqFuX16f+6TzH9lK4l3CZHr+WHLsMqrs=; b=MjXGis/08C6P1DbvTDS6XJJiOLeKA3eQfTgRH93dbv1sJJCfHSRkL3aF/mNyyMkS+M 2/bzui3U5K4koDZ1W+02OsJlccKvZw20haIwOpjsQL6hK4muM/KJT0lqRDPbyLUU18VR pm1Mgq7UGLlKE0DYF+SgPGFSWxgOKUnaQ85PNqqo5naqIWdQKyv4vHEXcrv87MBWVXKn zra+0ehpmUoykyEljanDVPzp3AfQRYC/c5nVsAoTFdRDqc+tF2ByiA7xh7hs5Dj0b0x1 OEtwLJzVmH1UNoPWyOsX/CF+qI+idQQHhRLt2Svm9kDITmGxLhByKG6WSxAoISesyuHF es8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784756695; x=1785361495; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WVIK4CTS2ebWqFuX16f+6TzH9lK4l3CZHr+WHLsMqrs=; b=P4kjIQaie55CrTN3Gh8bVRuRRamJmbnDUugfNJnZWNH6YENr7o6UNYnQcAymYX43OU +cxgjsBltGQ2daHLruCRcwok1sxqpTebRHHVhnwZYhHmNKhcSEOVw0gQbS2QlBc4cRI2 IWSm84Gryh6Lj6jXK7stET0X2JIRp5mioG7IepbvsfDrpBY4AzRMmbXICGqIwLVDQIfU Ie9+261f39RIp6ce0J3/7HOO3ufkEgM7ehEYC9LbJO/gdp/C12Xx90/cbZlHPv6ira+t mTejqO3txDJyxu08ObithHnPqcj4GoMiMJNhGv9bXdy/5QgKz5DPoIMM831z4hLtCGaT EFzQ== X-Forwarded-Encrypted: i=1; AHgh+RqoXo3SIeimUwbYE49yeO3mdeB0ekbY4776uKQc6kmsmXY3ju3ul4HEVcBn5Hi05lV1vBi48NwqpnoLRBY=@vger.kernel.org X-Gm-Message-State: AOJu0YwX2xp6ELQ3ZbSpmyvo/++xAJLe2oIFzDMXn3Tl/fhTH6pgFOHt s1b/1mwXZM4OW9fa/84XPVImeym75+DsVuZJeP9RFOxcGHk36ceN7UUw X-Gm-Gg: AR+sD11SCp1n6oSJ1ioiV7i/1Fu19P70ojagCmGQrs6yjdv5fpP0XY/pCEYlW7tJ11b zV3QxdXmIX/Bb9WHbJXMEePosNIO77bSTqP9mOGOLOfm5v0Axpz7+4uv9ukEmldJeioVW0mWyyd atQxTukGwh2rxBvA2CzzDid1X82kdUzyX7NoUudH+cPkjidxgLRDLz33sViPmrkFPAumDveVxwX zx2j2Ky+VqjQ8YC5ZcXXc1xrplX29Db94ZBREV/kaXSKsXPSkTOn8RSNGMYJSL9eYHlcqmqxMD2 7nYyTA3HVnX6FvitIHreS4gKAxN4epfEWsNiJnBmTVgUDG8TosO1T9j8VeaxLd5CMkHO718Wn2H S5GXeJ9+wacHnEkpGyEySbRXPraUqnq61Z8U7GXnIq7YDdFMq0pnPZX1Nte0Gei8a965w/ARonI 6prcj0NlklQcyBJllVs8UbbpS2ue35GC6ZDAK/CywrDepO+pih X-Received: by 2002:a05:6a00:852:b0:848:46ea:bbe7 with SMTP id d2e1a72fcca58-84e2bc6b5d6mr673956b3a.19.1784756695183; Wed, 22 Jul 2026 14:44:55 -0700 (PDT) Received: from [192.168.0.160] (c-98-225-44-182.hsd1.wa.comcast.net. [98.225.44.182]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e17237c3fsm1946297b3a.9.2026.07.22.14.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 14:44:54 -0700 (PDT) From: Stanislav Kinsburskii Date: Wed, 22 Jul 2026 14:44:27 -0700 Subject: [PATCH v10 5/8] drm/nouveau: Use hmm_range_fault_unlocked_timeout() for SVM faults Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260722-hmm-v10-v1-5-606464dd601a@gmail.com> References: <20260722-hmm-v10-v1-0-606464dd601a@gmail.com> In-Reply-To: <20260722-hmm-v10-v1-0-606464dd601a@gmail.com> To: Jason Gunthorpe , Leon Romanovsky , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jonathan Corbet , Shuah Khan , Shuah Khan , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Lyude Paul , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Min Ma , Lizhi Hou , Oded Gabbay , skinsburskii@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rdma@vger.kernel.org, Jason Gunthorpe X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784756683; l=2163; i=skinsburskii@gmail.com; s=20260722; h=from:subject:message-id; bh=KaVy0LDD2WZ56zIlG4jDVljfxrz2j27JL0AnOSACkpk=; b=uKgRFxKY7gMhEFoK0hHnwQl6N8UsouNcazo70jIAxend3BGPO0koGFjjGoE03g3KTWZd66DI6 5tAsc5/qbDAAjPQ/pjqrtB3km5I7U9rctkdARaqcdzu58Lj+SzHd5bT X-Developer-Key: i=skinsburskii@gmail.com; a=ed25519; pk=bDpriHBYgeTdkIDweZDCemxsU93neJBOCn3YLIuJpnE= nouveau_range_fault() takes mmap_read_lock() only to call hmm_range_fault(). It also keeps a single HMM_RANGE_DEFAULT_TIMEOUT deadline across both HMM -EBUSY retries and post-fault mmu_interval_read_retry() retries. Use hmm_range_fault_unlocked_timeout() instead. The HMM helper now owns the mmap lock and refreshes range->notifier_seq for its internal retries. Nouveau keeps its existing absolute deadline in the outer loop and passes the remaining jiffies to the helper for each fault attempt, so retries caused by mmu_interval_read_retry() do not reset the overall retry budget. Nouveau still validates the interval notifier sequence while holding svmm->mutex before programming the GPU mapping. Reviewed-by: Jason Gunthorpe Signed-off-by: Stanislav Kinsburskii --- drivers/gpu/drm/nouveau/nouveau_svm.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c index dcc92131488e..58735446d783 100644 --- a/drivers/gpu/drm/nouveau/nouveau_svm.c +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c @@ -678,20 +678,22 @@ static int nouveau_range_fault(struct nouveau_svmm *svmm, range.end = notifier->notifier.interval_tree.last + 1; while (true) { - if (time_after(jiffies, timeout)) { + long remaining = timeout - jiffies; + + /* + * The HMM timeout only bounds retries while HMM is walking and + * faulting the range. This fault is handled by a kernel worker, + * so fatal signals from the faulting process cannot stop an + * endless stream of invalidations here. + */ + if (time_after_eq(jiffies, timeout)) { ret = -EBUSY; goto out; } - range.notifier_seq = mmu_interval_read_begin(range.notifier); - mmap_read_lock(mm); - ret = hmm_range_fault(&range); - mmap_read_unlock(mm); - if (ret) { - if (ret == -EBUSY) - continue; + ret = hmm_range_fault_unlocked_timeout(&range, remaining); + if (ret) goto out; - } mutex_lock(&svmm->mutex); if (mmu_interval_read_retry(range.notifier, -- 2.43.0