From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f97.google.com (mail-qv1-f97.google.com [209.85.219.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 048843DDDAC for ; Tue, 29 Sep 2026 04:03:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790654606; cv=none; b=AETofKt1ywVjKoIKgZRvAdd7u8W2yc6toCvTV7NFhXPOTRDKx8ZMy3EQVIEtTm/GBv1Ls8A2Qyz+f7l8Q2kKN3y1xVMTuzkDZCKZ0fKrsBG2g0AhJ7WTkCqXRv5zSE0r9lmfJVYoq0gIzLBbubiodROFZFFZeqAC4MKGx+Pn6rA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790654606; c=relaxed/simple; bh=cAPVcgsAJorVkgcgjx8qJ2Cz7pTUEIJBuCCMwyGBvoc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lpzh/sDCHtecQgP/OrRapPSZ1UqrPusQw+vaFk7bPppoY69YQBqTF2ejzWgzmFPOHaZm5DkHl+Y1m5jkl930gLNwCkdFuDzN8djIUmqoUd5zhdwk00Eq3263ZcO5XylWP8/E217nIkZGIKUuBbK9CW6ceibuvEsodv9gOvxV/hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=S5hD9btE; arc=none smtp.client-ip=209.85.219.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="S5hD9btE" Received: by mail-qv1-f97.google.com with SMTP id 6a1803df08f44-9144ea75493so2755256d6.0 for ; Mon, 28 Sep 2026 21:03:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790654604; x=1791259404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=p1CKCrpax+qcHAbV5I37hg3uq7X1UIkb9ImgfW4E7N8=; b=RxDcey105tPRoisTBt3xAviYw/sUEBElz9BhavPCsi5xwYd7C+5VC524u9bzCzYOkK XxHvlEij2RZl3HHrDQ7iZJ4s2gK/ah27BKsXqyeu+2gb1sHlcp8g1uT+x0t+Dg0ji1Ew RBhy+02LpDojdZjBGKroiIUiu/YfYD7nzY+lM+boIAXi4SZdB9Ss0eiMiyz/XRdOfior yYFNSNuyDeqMNwKLf7weiReXNbLxb8hjIiD5+LWzuvxg7sT1qONKHsZrDKnb8UpyQJRK V+3V9EfOk5PsIMv2ll7H82fGW4LEa4NCQ5adSbbeNb5JTN2dwIaOOHyUfs6FhXBbM9Sm KWAA== X-Forwarded-Encrypted: i=1; AKwUvBxAAE8hYLJB2PkjsohbrZOnlY1c3nex7nCid5kPeLvtn1DuZ72jOBVf17xeKpYaLAqX9y8y6uhxW+D0dpU=@vger.kernel.org X-Gm-Message-State: AFuF++kLxAEgmuI/OHorz4wOex8uLvCgj+oE4rnY5xjN7AnaV7dxzf/I WNASyPnhgipaHuGxR5uMQtiw0ugWVBZJkEZFljZjgYnVpzLSHYH+0eObLafm/9fZ+HgKRvkooQO gQ8PhDwTZYbLcJ3ePEzJl0zT9+MEetM39WURFTlbY9x8FFh+qLwes1Df1r9zguulxjd96pi+0ZK uBWO3fsikKjZDihAoJbSncNlUrrCZjtty0Q5hcKsew3x2jNhDbR7qUNvDpiREE93iryq2wW/BYm HjHQphiR7+GyPsa X-Gm-Gg: AYBFou0l+T/BsbbM/XRTualsssg9ed9447DkfcegEkVcLDAa5VGGrkT34sgh+vjNZ83 2WBBxM2oNJY2DWFhGoPRKwQpwm7S8PXF13sTbZqRyRKtBOIf54VS3DSymehzI3bEKR8x8BozyH4 cm3BiMloeRyp9JaeCt6h1TiofnWVkdDXiaf/AdLW4IJ1bVo1fcPemPp4rEYolOw3H3y+sstJXf6 wApdprHZdnGgnpB+vUq1X6/r9m0eYJS4lfsscPmeb8ZlXEhPHj5d/y8YiPPxVcwRNoAiyZ3MTkZ Gyfme+DYfXUvgnYggzZmrwcWKl+5I+GzMRtDM2nQ2xXgByyKkMODiP+onU16H6FkPNvYwqTJVaG FVsA01p9+PzuwsubTb+ER78HEYZZD/sdJGM9/NDsopCAF6OkUoP/mN2nA//3IA/JA4cxtD0rWVi PYYH4OQqONPdcYwIXXlYG9I0aMZQBZ8b8V X-Received: by 2002:a05:620a:2548:b0:92e:76a1:96cd with SMTP id af79cd13be357-93c43b5af2dmr2462947285a.13.1790654603753; Mon, 28 Sep 2026 21:03:23 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id af79cd13be357-93c8138bd78sm116302785a.3.2026.09.28.21.03.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Sep 2026 21:03:23 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-30c0d568830so7722350eec.1 for ; Mon, 28 Sep 2026 21:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1790654601; x=1791259401; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=p1CKCrpax+qcHAbV5I37hg3uq7X1UIkb9ImgfW4E7N8=; b=S5hD9btEeeCasujz5w9QZDPjqqKKIrEHlJMVqOqhX8KtIl+hs1yg3FyozSXIHCQDtD 9u57WciCTYugRIfLEGeT5e2xFFu67Xc8zbGGVunTFXU+nSERWicaZLT2ywSoRAPCSJWn 5zgf3Rs94gkb08ZDMg2/ffnuONLXuLnDyT+jE= X-Forwarded-Encrypted: i=1; AKwUvBzViyr37U5uBBUFX4pTYL0jTOEKGAB/vsBbIpEy67E9EoWOkJCLaZZrFhH5YlhJGvZJboaggJBqLAtdjyE=@vger.kernel.org X-Received: by 2002:a05:693c:4099:b0:34b:401a:4648 with SMTP id 5a478bee46e88-34b40298aa6mr875185eec.20.1790654601402; Mon, 28 Sep 2026 21:03:21 -0700 (PDT) X-Received: by 2002:a05:693c:4099:b0:34b:401a:4648 with SMTP id 5a478bee46e88-34b40298aa6mr875122eec.20.1790654600700; Mon, 28 Sep 2026 21:03:20 -0700 (PDT) Received: from vertex.localdomain ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-347323f5a7esm10952571eec.15.2026.09.28.21.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 21:03:18 -0700 (PDT) From: Zack Rusin To: Kiryl Shutsemau , Borislav Petkov , x86@kernel.org, Dennis Zhou , Tejun Heo , Arnd Bergmann , Rick Edgecombe , Tom Lendacky , Wei Liu , Dexuan Cui , Paolo Bonzini , Vitaly Kuznetsov Cc: Ajay Kaher , Alexey Makhalov , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , virtualization@lists.linux.dev, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Christoph Lameter , Andrew Morton , Bo Gan , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, Jonathan Corbet , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Andy Lutomirski , Peter Zijlstra , linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, Nathan Chancellor , Kees Cook , Ashish Kalra Subject: [PATCH v2 3/6] x86/percpu: Require embedded allocation in encrypted guests Date: Tue, 29 Sep 2026 00:02:52 -0400 Message-ID: <20260929040256.543767-4-zack.rusin@broadcom.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260929040256.543767-1-zack.rusin@broadcom.com> References: <20260929040256.543767-1-zack.rusin@broadcom.com> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Early sharing needs direct-mapped per-CPU storage. In TDX, a private direct-map alias of a shared page can terminate the guest, including through load_unaligned_zeropad(). Require embed rather than adding early vmalloc conversion and alias synchronization. Warn when overriding percpu_alloc=page and let embed failures reach the existing panic. Restrict this policy to encrypted guests, leaving host SME allocation unchanged. Suggested-by: Kiryl Shutsemau Link: https://lore.kernel.org/r/aqvxQoIoYhJTZpAC@thinkstation Signed-off-by: Zack Rusin --- Documentation/admin-guide/kernel-parameters.txt | 3 +++ arch/x86/kernel/setup_percpu.c | 12 ++++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 33cd30996e47..8ba881af3520 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -5347,6 +5347,9 @@ Kernel parameters See comments in mm/percpu.c for details on each allocator. This parameter is primarily for debugging and performance comparison. + On x86 encrypted guests, only "embed" is supported; + "page" is ignored with a warning. An embed allocation + failure is fatal instead of falling back to "page". pirq= [SMP,APIC] Manual mp-table setup See Documentation/arch/x86/i386/IO-APIC.rst. diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c index bfa48e7a32a2..c83c61e0b20a 100644 --- a/arch/x86/kernel/setup_percpu.c +++ b/arch/x86/kernel/setup_percpu.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -112,6 +113,7 @@ void __init setup_per_cpu_areas(void) { unsigned int cpu; unsigned long delta; + bool encrypted = cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT); int rc; pr_info("NR_CPUS:%d nr_cpumask_bits:%d nr_cpu_ids:%u nr_node_ids:%u\n", @@ -127,6 +129,12 @@ void __init setup_per_cpu_areas(void) if (pcpu_chosen_fc == PCPU_FC_AUTO && pcpu_need_numa()) pcpu_chosen_fc = PCPU_FC_PAGE; #endif + if (encrypted) { + if (pcpu_chosen_fc == PCPU_FC_PAGE) + pr_warn("Ignoring percpu_alloc=page in an encrypted guest\n"); + pcpu_chosen_fc = PCPU_FC_EMBED; + } + rc = -EINVAL; if (pcpu_chosen_fc != PCPU_FC_PAGE) { const size_t dyn_size = PERCPU_MODULE_RESERVE + @@ -149,11 +157,11 @@ void __init setup_per_cpu_areas(void) dyn_size, atom_size, pcpu_cpu_distance, pcpu_cpu_to_node); - if (rc < 0) + if (rc < 0 && !encrypted) pr_warn("%s allocator failed (%d), falling back to page size\n", pcpu_fc_names[pcpu_chosen_fc], rc); } - if (rc < 0) + if (rc < 0 && !encrypted) rc = pcpu_page_first_chunk(PERCPU_FIRST_CHUNK_RESERVE, pcpu_cpu_to_node); if (rc < 0) -- 2.53.0