From: Bjorn Helgaas <helgaas@kernel.org>
To: Naman Jain <namjain@linux.microsoft.com>
Cc: "Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
"Wei Liu" <wei.liu@kernel.org>,
"K . Y . Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Dexuan Cui" <decui@microsoft.com>,
"Michael Kelley" <mhklinux@outlook.com>,
"Long Li" <longli@microsoft.com>,
"Nam Cao" <namcao@linutronix.de>,
"Joerg Roedel" <joro@8bytes.org>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Vasant Hegde" <vasant.hegde@amd.com>,
"Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Kees Cook" <kees@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Radu Rendec" <radu@rendec.net>,
"Sean Christopherson" <seanjc@google.com>,
"Kai Huang" <kai.huang@intel.com>,
"Dmitry Ilvokhin" <d@ilvokhin.com>,
"Shradha Gupta" <shradhagupta@linux.microsoft.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Thierry Reding" <treding@nvidia.com>,
"Jiri Wiesner" <jwiesner@suse.de>,
"Daniel J Blueman" <daniel@quora.org>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 4/4] x86/irq, iommu/amd, x86/hyperv, PCI: Drop redundant irq_retrigger inits
Date: Thu, 15 Oct 2026 17:47:08 -0500 [thread overview]
Message-ID: <20261015224708.GA1810637@bhelgaas> (raw)
In-Reply-To: <20260923043023.3150498-5-namjain@linux.microsoft.com>
On Wed, Sep 23, 2026 at 04:30:23AM +0000, Naman Jain wrote:
> With fixup_irqs() and msi_set_affinity() now using
> irq_chip_retrigger_hierarchy(), the outermost domain chips no longer need
> the helper as their irq_retrigger() callback. The generic resend path
> already uses the hierarchy helper.
>
> The hierarchy walk reaches the x86 vector domain's apic_retrigger_irq() for
> all of these stacked domain chips.
>
> Remove the now redundant irq_retrigger() initializations from the outermost
> domain interrupt chips, including the Hyper-V root partition PCI/MSI chip.
>
> No functional change intended.
>
> Suggested-by: Thomas Gleixner <tglx@kernel.org>
> Reviewed-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> Reviewed-by: Thomas Gleixner <tglx@kernel.org>
> Signed-off-by: Naman Jain <namjain@linux.microsoft.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com> # pci-hyperv.c
> ---
> arch/x86/hyperv/irqdomain.c | 1 -
> arch/x86/kernel/apic/io_apic.c | 2 --
> arch/x86/kernel/apic/msi.c | 2 --
> arch/x86/kernel/hpet.c | 1 -
> drivers/iommu/amd/init.c | 1 -
> drivers/pci/controller/pci-hyperv.c | 1 -
> 6 files changed, 8 deletions(-)
>
> diff --git a/arch/x86/hyperv/irqdomain.c b/arch/x86/hyperv/irqdomain.c
> index 6d790636c8b95..b3ad50a874dca 100644
> --- a/arch/x86/hyperv/irqdomain.c
> +++ b/arch/x86/hyperv/irqdomain.c
> @@ -316,7 +316,6 @@ static bool hv_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
> return false;
>
> chip->flags |= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED;
> - chip->irq_retrigger = irq_chip_retrigger_hierarchy;
>
> info->ops->msi_prepare = pci_msi_prepare;
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 7d7175d012288..18f49a251f23b 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1857,7 +1857,6 @@ static struct irq_chip ioapic_chip __read_mostly = {
> .irq_ack = irq_chip_ack_parent,
> .irq_eoi = ioapic_ack_level,
> .irq_set_affinity = ioapic_set_affinity,
> - .irq_retrigger = irq_chip_retrigger_hierarchy,
> .irq_get_irqchip_state = ioapic_irq_get_chip_state,
> .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED |
> IRQCHIP_AFFINITY_PRE_STARTUP,
> @@ -1871,7 +1870,6 @@ static struct irq_chip ioapic_ir_chip __read_mostly = {
> .irq_ack = irq_chip_ack_parent,
> .irq_eoi = ioapic_ir_ack_level,
> .irq_set_affinity = ioapic_set_affinity,
> - .irq_retrigger = irq_chip_retrigger_hierarchy,
> .irq_get_irqchip_state = ioapic_irq_get_chip_state,
> .flags = IRQCHIP_SKIP_SET_WAKE |
> IRQCHIP_AFFINITY_PRE_STARTUP,
> diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c
> index 9160227b9b32a..aad2f15eb2176 100644
> --- a/arch/x86/kernel/apic/msi.c
> +++ b/arch/x86/kernel/apic/msi.c
> @@ -246,7 +246,6 @@ static bool x86_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
> info->ops->msi_prepare = x86_msi_prepare;
>
> info->chip->irq_ack = irq_chip_ack_parent;
> - info->chip->irq_retrigger = irq_chip_retrigger_hierarchy;
> info->chip->flags |= IRQCHIP_SKIP_SET_WAKE |
> IRQCHIP_AFFINITY_PRE_STARTUP;
>
> @@ -313,7 +312,6 @@ static struct irq_chip dmar_msi_controller = {
> .irq_mask = dmar_msi_mask,
> .irq_ack = irq_chip_ack_parent,
> .irq_set_affinity = msi_domain_set_affinity,
> - .irq_retrigger = irq_chip_retrigger_hierarchy,
> .irq_compose_msi_msg = dmar_msi_compose_msg,
> .irq_write_msi_msg = dmar_msi_write_msg,
> .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED |
> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> index 8dc7b710e1250..2bb7a6f466af3 100644
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -509,7 +509,6 @@ static struct irq_chip hpet_msi_controller __ro_after_init = {
> .irq_mask = hpet_msi_mask,
> .irq_ack = irq_chip_ack_parent,
> .irq_set_affinity = msi_domain_set_affinity,
> - .irq_retrigger = irq_chip_retrigger_hierarchy,
> .irq_write_msi_msg = hpet_msi_write_msg,
> .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP,
> };
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 8a410d4aa3704..0d22324568911 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -2477,7 +2477,6 @@ static struct irq_chip intcapxt_controller = {
> .irq_unmask = intcapxt_unmask_irq,
> .irq_mask = intcapxt_mask_irq,
> .irq_ack = irq_chip_ack_parent,
> - .irq_retrigger = irq_chip_retrigger_hierarchy,
> .irq_set_affinity = intcapxt_set_affinity,
> .irq_set_wake = intcapxt_set_wake,
> .flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_MOVE_DEFERRED,
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 056d379b3cee4..a004b08d68fe9 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -2119,7 +2119,6 @@ static bool hv_pcie_init_dev_msi_info(struct device *dev, struct irq_domain *dom
> info->ops->msi_prepare = hv_msi_prepare;
>
> chip->irq_set_affinity = irq_chip_set_affinity_parent;
> - chip->irq_retrigger = irq_chip_retrigger_hierarchy;
>
> if (IS_ENABLED(CONFIG_X86))
> chip->flags |= IRQCHIP_MOVE_DEFERRED;
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-10-15 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 4:30 [PATCH v6 0/4] x86/irq: Fix lost interrupts on CPU hot-unplug Naman Jain
2026-09-23 4:30 ` [PATCH v6 1/4] x86/hyperv: Set irq_retrigger for root partition PCI/MSI irqchip Naman Jain
2026-09-23 4:37 ` sashiko-bot
2026-09-23 4:30 ` [PATCH v6 2/4] x86/irq: Use irq_chip_retrigger_hierarchy() in fixup_irqs() Naman Jain
2026-09-23 4:41 ` sashiko-bot
2026-09-23 4:30 ` [PATCH v6 3/4] x86/irq: Use irq_chip_retrigger_hierarchy() in msi_set_affinity() Naman Jain
2026-09-23 4:42 ` sashiko-bot
2026-09-23 14:30 ` Michael Kelley
2026-09-23 4:30 ` [PATCH v6 4/4] x86/irq, iommu/amd, x86/hyperv, PCI: Drop redundant irq_retrigger inits Naman Jain
2026-09-23 4:43 ` sashiko-bot
2026-09-23 14:33 ` Michael Kelley
2026-10-15 22:47 ` Bjorn Helgaas [this message]
2026-10-15 9:09 ` [PATCH v6 0/4] x86/irq: Fix lost interrupts on CPU hot-unplug Naman Jain
2026-10-15 22:36 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015224708.GA1810637@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=d@ilvokhin.com \
--cc=daniel@quora.org \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jwiesner@suse.de \
--cc=kai.huang@intel.com \
--cc=kees@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=namcao@linutronix.de \
--cc=namjain@linux.microsoft.com \
--cc=radu@rendec.net \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=seanjc@google.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@kernel.org \
--cc=treding@nvidia.com \
--cc=vasant.hegde@amd.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox