Re: [PATCH v4 6/7] Drivers: hv: Use hv_setup_*() to set up hypercall arguments for mshv code

[Nuno Das Neves <nunodasneves@linux.microsoft.com>]

On 7/17/2025 11:55 PM, mhkelley58@gmail.com wrote:
> From: Michael Kelley <mhklinux@outlook.com>
> 
> Update hypercall call sites to use the new hv_setup_*() functions
> to set up hypercall arguments. Since these functions zero the
> fixed portion of input memory, remove now redundant calls to memset()
> and explicit zero'ing of input fields. Where feasible use batch size
> returned by hv_setup_inout_array() instead of separate #define value.
> 
> Signed-off-by: Michael Kelley <mhklinux@outlook.com>
> ---
> 
> Notes:
>     Changes in v4:
>     * Rename hv_hvcall_*() functions to hv_setup_*() [Easwar Hariharan]
>     * Rename hv_hvcall_in_batch_size() to hv_get_input_batch_size()
>       [Easwar Hariharan]
>     
>     Changes in v3:
>     * This patch is new in v3 due to rebasing on 6.15-rc1, which has new
>       mshv-related hypercalls.
> 
>  drivers/hv/mshv_common.c       |  31 +++------
>  drivers/hv/mshv_root_hv_call.c | 121 +++++++++++++--------------------
>  drivers/hv/mshv_root_main.c    |   5 +-
>  3 files changed, 60 insertions(+), 97 deletions(-)

<snip>
I tested most of the modified call sites (about 75%), and the rest look
correct to me.

Tested-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
Reviewed-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>