From: Jork Loeser <jloeser@linux.microsoft.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Long Li <longli@microsoft.com>,
"Anirudh Rayabharam (Microsoft)" <anirudh@anirudhrb.com>,
Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mshv: add vmbus dependency
Date: Wed, 20 May 2026 10:15:59 -0700 (PDT) [thread overview]
Message-ID: <52a29c5-715e-8ea-af1-dafebfca7a84@linux.microsoft.com> (raw)
In-Reply-To: <20260520074044.923728-1-arnd@kernel.org>
On Wed, 20 May 2026, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When the vmbus driver is not part of the kernel, the mvhv_root
> driver now fails to link:
>
> ERROR: modpost: "hv_vmbus_exists" [drivers/hv/mshv_root.ko] undefined!
>
> Avoid this by adding an explicit Kconfig dependency. Note that
> stubbing out the hv_vmbus_exists() based on configuration would
> also work for some cases, but not with MSHV_ROOT=y and HYPERV_VMBUS=m.
>
> Fixes: f1a9e67c1138 ("mshv: limit SynIC management to MSHV-owned resources")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/hv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> index 52af086fdeb2..21193b571a80 100644
> --- a/drivers/hv/Kconfig
> +++ b/drivers/hv/Kconfig
> @@ -75,6 +75,7 @@ config MSHV_ROOT
> # e.g. When withdrawing memory, the hypervisor gives back 4k pages in
> # no particular order, making it impossible to reassemble larger pages
> depends on PAGE_SIZE_4KB
> + depends on HYPERV_VMBUS
> select EVENTFD
> select VIRT_XFER_TO_GUEST_WORK
> select HMM_MIRROR
> --
> 2.39.5
>
Yes, this is the right short-term fix. We will need to solve the root case
(no VMBUS required) with a separate SYNIC driver abstraction.
Reviewed-by: Jork Loeser <jloeser@linux.microsoft.com>
Thank you!
Jork
prev parent reply other threads:[~2026-05-20 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 7:40 [PATCH] mshv: add vmbus dependency Arnd Bergmann
2026-05-20 13:46 ` Michael Kelley
2026-05-20 13:51 ` Arnd Bergmann
2026-05-20 17:13 ` Jork Loeser
2026-05-20 17:15 ` Jork Loeser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52a29c5-715e-8ea-af1-dafebfca7a84@linux.microsoft.com \
--to=jloeser@linux.microsoft.com \
--cc=anirudh@anirudhrb.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=skinsburskii@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox