From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0CB6EE4996 for ; Mon, 21 Aug 2023 06:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233365AbjHUGq0 (ORCPT ); Mon, 21 Aug 2023 02:46:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233409AbjHUGqZ (ORCPT ); Mon, 21 Aug 2023 02:46:25 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD0ACB3 for ; Sun, 20 Aug 2023 23:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692600341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUH8EM/c4BgCyJddNU6uELLJ8bA/pGDspC2Nb/HHUYY=; b=jC6II0PDu6LOwaf0BX6sQkJxAnR5aeGN12DFhcbiwhFUzpDYxcefgK3SLZaxDxc9muKTwr v/HzlLa7QbDFsYbaC1W87rWNLrSn/oUlBJKiAu6teZ2bASvSndSXNMLvT058ktJ1d4PMUR WvVk2PhQTEIFSErDd9WbaLY9qNY5+PM= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-fhcBNnpBNZ6M0XswV1Q0WQ-1; Mon, 21 Aug 2023 02:45:38 -0400 X-MC-Unique: fhcBNnpBNZ6M0XswV1Q0WQ-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-26f3fce5b0bso1051673a91.2 for ; Sun, 20 Aug 2023 23:45:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692600337; x=1693205137; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rUH8EM/c4BgCyJddNU6uELLJ8bA/pGDspC2Nb/HHUYY=; b=hkPdjUK3SynhecWYtbcVjxVJUB2eNhJXfdOoTPnsnID454mBGtnVqoGr+bRgsAIO0j r/kam8M9+nyo/ET+CxyP6ppJGd3p9daw0a1bZT0ZLPD1XAfr7JfkmgiEUb0deqV0kqrM Li4IhWdsox7uj/BshoTvHm6+EwS1bECR7eTkumKTSbadDxnBgZMedM3xgRvGoSNzFmR3 fr5iUbT/PuUTyBvN062Ist8fbIO7O8IMzHpEhf1XdVBWrWbBSLZphJbq4q/meX6AkGRC 1mqwFthTnYVeEEPFIxWfb8ajanT/hAK0lXavsrXB+YXzZnY991FLbt/DOaahTM7YjKB/ TCng== X-Gm-Message-State: AOJu0YzQ/xXYKzn7SFT3OMHiZVaBk9Poqmky6eCU0xiRLWNU45pSr8Ys Srl/H8KK5tY3WxO2BV57tkyLNqxxcn7lZcMwDWrTcQ8SlCZEqpRn4ZD8ce++QVVYbWBMmw3c+0W dM+KnE+NZmQ5shphWBixcdiAx X-Received: by 2002:a17:90a:2f06:b0:268:37b:a10e with SMTP id s6-20020a17090a2f0600b00268037ba10emr2885284pjd.11.1692600337173; Sun, 20 Aug 2023 23:45:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhMxnaElq+qOTcktFtonqQ5m9DNcuZEtAl/95cxPPiE918/oL2gA20Hrfq336KSnmg4f84nA== X-Received: by 2002:a17:90a:2f06:b0:268:37b:a10e with SMTP id s6-20020a17090a2f0600b00268037ba10emr2885246pjd.11.1692600336873; Sun, 20 Aug 2023 23:45:36 -0700 (PDT) Received: from smtpclient.apple ([49.207.201.27]) by smtp.gmail.com with ESMTPSA id d19-20020a17090ae29300b00267eead2f16sm5376430pjz.36.2023.08.20.23.45.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Aug 2023 23:45:36 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH v3] hv/hv_kvp_daemon: Add support for keyfile config based connection profile in NM From: Ani Sinha In-Reply-To: <20230808054248.GA12620@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Date: Mon, 21 Aug 2023 12:15:29 +0530 Cc: Wei Liu , Olaf Hering , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Dexuan Cui , Long Li , Michael Kelley Content-Transfer-Encoding: quoted-printable Message-Id: <5A8AA269-FBDB-4023-9809-273C046B2BCD@redhat.com> References: <1683265875-3706-1-git-send-email-shradhagupta@linux.microsoft.com> <20230508095340.2ca1630f.olaf@aepfle.de> <20230508191246.2fcd6eb5.olaf@aepfle.de> <20230523053627.GA10913@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <53E9AC1D-C907-4B55-97F2-FC10DCD4D470@redhat.com> <4142F3A4-8AB4-4DE2-8D03-D3A8F8776BF9@redhat.com> <20230808054248.GA12620@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> To: Shradha Gupta X-Mailer: Apple Mail (2.3696.120.41.1.4) Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org > On 08-Aug-2023, at 11:12 AM, Shradha Gupta = wrote: >=20 > On Tue, Aug 08, 2023 at 10:41:21AM +0530, Ani Sinha wrote: >>=20 >>=20 >>> On 12-Jul-2023, at 12:32 PM, Ani Sinha wrote: >>>=20 >>>=20 >>>=20 >>>> On 23-May-2023, at 11:06 AM, Shradha Gupta = wrote: >>>>=20 >>>> On Mon, May 08, 2023 at 05:16:19PM +0000, Wei Liu wrote: >>>>> On Mon, May 08, 2023 at 07:12:46PM +0200, Olaf Hering wrote: >>>>>> Mon, 8 May 2023 16:47:54 +0000 Wei Liu : >>>>>>=20 >>>>>>> Olaf, is this a reviewed-by from you? :-) >>>>>>=20 >>>>>> Sorry, I did not review the new functionality, just tried to make = sure there will be no regression for existing consumers. >>>>>=20 >>>>> Okay, this is fine, too. Thank you for looking into this. >>>>>=20 >>>>>=20 >>>>>>=20 >>>>>> Olaf >>>>>=20 >>>>=20 >>>> Gentle reminder. >>>>=20 >>>=20 >>> I have a comment about the following change: >>>=20 >>> + error =3D fprintf(nmfile, "\n[ipv4]\n"); >>> + if (error < 0) >>> + goto setval_error; >>> + >>> + if (new_val->dhcp_enabled) { >>> + error =3D kvp_write_file(nmfile, "method", "", = "auto"); >>> + if (error < 0) >>> + goto setval_error; >>> + } else { >>> + error =3D kvp_write_file(nmfile, "method", "", = "manual"); >>> + if (error < 0) >>> + goto setval_error; >>> + } >>>=20 >>> I think the method equally would apply for ipv6 as it applies for = ipv4.=20 >>> We can use = https://www.golinuxcloud.com/nmcli-command-examples-cheatsheet-centos-rhel= /#18_Disable_IPv6_Address_for_ethernet_connection_IPV6INIT as a = reference.=20 >>> So setting the method should be common to both ipv4 and ipv6. >>=20 >> Ping once more ??? >> Can anyone comment on the avove and/or review the patchset? > That's correct Ani, this needs to be enabled for ipv6 as well, will = send out another version. Thanks for catching this. Have you sent out a new version? I do not see anything in my inbox. >=20