From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA75C433ED for ; Mon, 3 May 2021 08:28:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4C686127A for ; Mon, 3 May 2021 08:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230186AbhECI3e (ORCPT ); Mon, 3 May 2021 04:29:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46753 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbhECI3e (ORCPT ); Mon, 3 May 2021 04:29:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620030521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oeOHRYo4V+sjXuBsEphc00viyXFIqMXEH0Oj0f+S1EU=; b=Mj+l2yoR6S/M4tP4lcyMK1XPZ9jyPTsaxiNkSMUFx0QOcE2Os3LDUS3fqJotYayX1hn4DM 8c2wAtCZXF5iteutp8OLdhxVk4QkgQnn/0yRRELEHCFzwN3duH59oqWXcIRHmsUknts2yt GeZD8AlAV3t6250OeaAMu+mYjbrYaRg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-541-NAv2oIdMN5KGAg_6y1hnAw-1; Mon, 03 May 2021 04:28:38 -0400 X-MC-Unique: NAv2oIdMN5KGAg_6y1hnAw-1 Received: by mail-wm1-f71.google.com with SMTP id z9-20020a1c65090000b029014b497b2d98so92048wmb.8 for ; Mon, 03 May 2021 01:28:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oeOHRYo4V+sjXuBsEphc00viyXFIqMXEH0Oj0f+S1EU=; b=L+Z1+pF17VR9gIKlOAjvpUl9nFt3gw5sImzM02Ex6B37WgNK9hf9DMOrkYAoYvlmUz t+gRQHtKnLNqvpnyql57IWWCvqscF/lkRu+eWQKX0EgGG3eP1LfO0KbRp3WKYS0zBzTj 2RPTIy+jcBegKDkzBtMZmeh74FZZCjsNgGFKppEj7bcZzx0BnM0avfaeDbHUybN5/QZM 2QzL+EWrfosJTtRWYb/p7Of9SBl+r4HRMJ0G0yt7ccJAThBPVyBm9XRnrxtDa8cZkqsF tFhx5weZNIJuQ8OREFJE0zk7GVzT/fyRmbANt/NL9YEKR7ttT8r6NS4jkRsllXARXTX4 Kx4Q== X-Gm-Message-State: AOAM531j8iwwezBUmxnxITVRsine/jNVyacFRgeetwYF+xmBMfWb7FU0 E5w2uK9sHzlxr9QKOFZz+9e5qvgt6ictE4fk8yW4pgHeS+Dhn9KUFjQuXp7w6xVJ2oYowVe7eOF Fa/g2jgYFLknTciOe9II7n+Km X-Received: by 2002:a5d:6d85:: with SMTP id l5mr22979386wrs.22.1620030517790; Mon, 03 May 2021 01:28:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaIYYprmCHdbWEQG0UKlOnfr25C8JpbLNd+9kN/fx46K8mzScJzZQz2ZSZd2ki6w32eeO6Cw== X-Received: by 2002:a5d:6d85:: with SMTP id l5mr22979345wrs.22.1620030517468; Mon, 03 May 2021 01:28:37 -0700 (PDT) Received: from [192.168.3.132] (p5b0c649f.dip0.t-ipconnect.de. [91.12.100.159]) by smtp.gmail.com with ESMTPSA id r5sm12059190wmh.23.2021.05.03.01.28.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 01:28:37 -0700 (PDT) To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Michael S. Tsirkin" , Jason Wang , Alexey Dobriyan , "Matthew Wilcox (Oracle)" , Oscar Salvador , Michal Hocko , Roman Gushchin , Alex Shi , Steven Price , Mike Kravetz , Aili Yao , Jiri Bohac , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Naoya Horiguchi , linux-hyperv@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20210429122519.15183-1-david@redhat.com> <20210429122519.15183-8-david@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v1 7/7] fs/proc/kcore: use page_offline_(freeze|unfreeze) Message-ID: <5a5a7552-4f0a-75bc-582f-73d24afcf57b@redhat.com> Date: Mon, 3 May 2021 10:28:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On 02.05.21 08:34, Mike Rapoport wrote: > On Thu, Apr 29, 2021 at 02:25:19PM +0200, David Hildenbrand wrote: >> Let's properly synchronize with drivers that set PageOffline(). Unfreeze >> every now and then, so drivers that want to set PageOffline() can make >> progress. >> >> Signed-off-by: David Hildenbrand >> --- >> fs/proc/kcore.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c >> index 92ff1e4436cb..3d7531f47389 100644 >> --- a/fs/proc/kcore.c >> +++ b/fs/proc/kcore.c >> @@ -311,6 +311,7 @@ static void append_kcore_note(char *notes, size_t *i, const char *name, >> static ssize_t >> read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) >> { >> + size_t page_offline_frozen = 0; >> char *buf = file->private_data; >> size_t phdrs_offset, notes_offset, data_offset; >> size_t phdrs_len, notes_len; >> @@ -509,6 +510,18 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) >> pfn = __pa(start) >> PAGE_SHIFT; >> page = pfn_to_online_page(pfn); > > Can't this race with page offlining for the first time we get here? To clarify, we have three types of offline pages in the kernel ... a) Pages part of an offline memory section; the memap is stale and not trustworthy. pfn_to_online_page() checks that. We *can* protect against memory offlining using get_online_mems()/put_online_mems(), but usually avoid doing so as the race window is very small (and a problem all over the kernel we basically never hit) and locking is rather expensive. In the future, we might switch to rcu to handle that more efficiently and avoiding these possible races. b) PageOffline(): logically offline pages contained in an online memory section with a sane memmap. virtio-mem calls these pages "fake offline"; something like a "temporary" memory hole. The new mechanism I propose will be used to handle synchronization as races can be more severe, e.g., when reading actual page content here. c) Soft offline pages: hwpoisoned pages that are not actually harmful yet, but could become harmful in the future. So we better try to remove the page from the page allcoator and try to migrate away existing users. So page_offline_* handle "b) PageOffline()" only. There is a tiny race between pfn_to_online_page(pfn) and looking at the memmap as we have in many cases already throughout the kernel, to be tackled in the future. (A better name for PageOffline() might make sense; PageSoftOffline() would be catchy but interferes with c). PageLogicallyOffline() is ugly; PageFakeOffline() might do) > >> + /* >> + * Don't race against drivers that set PageOffline() >> + * and expect no further page access. >> + */ >> + if (page_offline_frozen == MAX_ORDER_NR_PAGES) { >> + page_offline_unfreeze(); >> + page_offline_frozen = 0; >> + cond_resched(); >> + } >> + if (!page_offline_frozen++) >> + page_offline_freeze(); >> + > > Don't we need to freeze before doing pfn_to_online_page()? See my explanation above. Thanks! -- Thanks, David / dhildenb