From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB4DC433E6 for ; Mon, 1 Mar 2021 13:32:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FE5C64E09 for ; Mon, 1 Mar 2021 13:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235719AbhCANca (ORCPT ); Mon, 1 Mar 2021 08:32:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:36486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235730AbhCANcR (ORCPT ); Mon, 1 Mar 2021 08:32:17 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF77864D9F; Mon, 1 Mar 2021 13:31:36 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lGie6-00GPaX-Od; Mon, 01 Mar 2021 13:31:34 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 01 Mar 2021 13:31:34 +0000 From: Marc Zyngier To: Frank Wunderlich Cc: Lorenzo Pieralisi , Bjorn Helgaas , Thierry Reding , Thomas Gleixner , Rob Herring , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Thierry Reding , Jonathan Hunter , Ryder Lee , Marek Vasut , Yoshihiro Shimoda , Michal Simek , Paul Walmsley , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: Aw: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling In-Reply-To: References: <20210225151023.3642391-1-maz@kernel.org> <20210225151023.3642391-10-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <5afd1d656299d87c43bdf31b8ced2d5f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: frank-w@public-files.de, lorenzo.pieralisi@arm.com, bhelgaas@google.com, treding@nvidia.com, tglx@linutronix.de, robh@kernel.org, will@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, ryder.lee@mediatek.com, marek.vasut+renesas@gmail.com, yoshihiro.shimoda.uh@renesas.com, michal.simek@xilinx.com, paul.walmsley@sifive.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org Frank, >> > i guess it's a bug in ath10k driver or my r64 board (it is a v1.1 >> > which has missing capacitors on tx lines). >> >> No, this definitely looks like a bug in the MTK PCIe driver, >> where the mutex is either not properly initialised, corrupted, >> or the wrong pointer is passed. > > but why does it happen only with the ath10k-card and not the mt7612 in > same slot? Does mt7612 use MSI? What we have here is a bogus mutex in the MTK PCIe driver, and the only way not to get there would be to avoid using MSIs. > >> This r64 machine is supposed to have working MSIs, right? > > imho mt7622 have working MSI > >> Do you get the same issue without this series? > > tested 5.11.0 [1] without this series (but with your/thomas' patch > from discussion about my old patch) and got same trace. so this series > does not break anything here. Can you retest without any additional patch on top of 5.11? These two patches only affect platforms that do *not* have MSIs at all. > >> > Tried with an mt7612e, this seems to work without any errors. >> > >> > so for mt7622/mt7623 >> > >> > Tested-by: Frank Wunderlich >> >> We definitely need to understand the above. > > there is a hardware-bug which may cause this...afair i saw this with > the card in r64 with earlier Kernel-versions where other cards work > (like the mt7612e). I don't think a HW bug affecting PCI would cause what we are seeing here, unless it results in memory corruption. Thanks, M. -- Jazz is not dead. It just smells funny...