From: Aditya Garg <gargaditya@linux.microsoft.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
ernis@linux.microsoft.com, horms@kernel.org,
dipayanroy@linux.microsoft.com, shacharr@microsoft.com,
stephen@networkplumber.org, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ssengar@linux.microsoft.com, gargaditya@microsoft.com
Subject: Re: [PATCH net] net: mana: Return error code from mana_create_rxq()
Date: Mon, 27 Jul 2026 16:54:41 +0530 [thread overview]
Message-ID: <5b7bd70d-8fbf-44c5-b5ce-0ce729db9cc1@linux.microsoft.com> (raw)
In-Reply-To: <20260723090621.6261a3e8@kernel.org>
On 23-07-2026 21:36, Jakub Kicinski wrote:
> On Fri, 17 Jul 2026 19:48:18 -0700 Aditya Garg wrote:
>> Change mana_create_rxq() to return an int and pass the created rxq back
>> to the caller through an output parameter. The caller now propagates the
>> returned error code directly instead of substituting -ENOMEM.
>
> We generally prefer the use of ERR_PTR to output arguments in
> the kernel. Looks like it'd work here nicely.
Thanks for the review Jakub,
I'll post a v2 using ERR_PTR/PTR_ERR
Regards,
Aditya
prev parent reply other threads:[~2026-07-27 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 2:48 [PATCH net] net: mana: Return error code from mana_create_rxq() Aditya Garg
2026-07-23 16:06 ` Jakub Kicinski
2026-07-27 11:24 ` Aditya Garg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b7bd70d-8fbf-44c5-b5ce-0ce729db9cc1@linux.microsoft.com \
--to=gargaditya@linux.microsoft.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=dipayanroy@linux.microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=gargaditya@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shacharr@microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=stephen@networkplumber.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox