From: Joe Perches <joe@perches.com>
To: Matheus Castello <matheus@castello.eng.br>,
Michael Kelley <mikelley@microsoft.com>
Cc: "sashal@kernel.org" <sashal@kernel.org>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING
Date: Tue, 24 Nov 2020 18:56:14 -0800 [thread overview]
Message-ID: <60b60d026a0636090b1617c6fd9e7b3a88013a7f.camel@perches.com> (raw)
In-Reply-To: <ada0ef93-1443-49a0-914c-1ad03ffa024b@castello.eng.br>
On Tue, 2020-11-24 at 21:54 -0300, Matheus Castello wrote:
> > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
[]
> > The above would be marginally better if organized as follows so that the
> > main execution path isn't in an "if" clause. Also reduces indentation.
> >
> > hv_panic_page = (void *)hv_alloc_hyperv_zeroed_page();
> > if (!hv_panic_page) {
> > pr_err("Hyper-V: panic message page memory allocation failed");
And nicer to add a terminating newline to the format like the pr_err below.
> > return;
> > }
> > ret = kmsg_dump_register(&hv_kmsg_dumper);
> > if (ret) {
> > pr_err("Hyper-V: kmsg dump register error 0x%x\n", ret);
> > hv_free_hyperv_page((unsigned long)hv_panic_page);
> > hv_panic_page = NULL;
> > }
next prev parent reply other threads:[~2020-11-25 2:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 19:57 [PATCH 0/6] Add improvements suggested by checkpatch for vmbus_drv Matheus Castello
2020-11-15 19:57 ` [PATCH 1/6] drivers: hv: Fix hyperv_record_panic_msg path on comment Matheus Castello
2020-11-15 22:11 ` Michael Kelley
2020-11-15 19:57 ` [PATCH 2/6] drivers: hv: vmbus: Replace symbolic permissions by octal permissions Matheus Castello
2020-11-15 22:15 ` Michael Kelley
2020-11-15 19:57 ` [PATCH 3/6] drivers: hv: vmbus: Fix checkpatch LINE_SPACING Matheus Castello
2020-11-15 22:16 ` Michael Kelley
2020-11-15 19:57 ` [PATCH 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING Matheus Castello
2020-11-15 22:25 ` Michael Kelley
2020-11-25 0:54 ` Matheus Castello
2020-11-25 2:56 ` Joe Perches [this message]
2020-11-25 3:14 ` Matheus Castello
2020-11-15 19:57 ` [PATCH 5/6] drivers: hv: vmbus: Fix unnecessary OOM_MESSAGE Matheus Castello
2020-11-16 11:21 ` Wei Liu
2020-11-16 15:58 ` Wei Liu
2020-11-15 19:57 ` [PATCH 6/6] drivers: hv: vmbus: Fix call msleep using < 20ms Matheus Castello
2020-11-15 22:32 ` Michael Kelley
2020-11-17 10:58 ` [PATCH 0/6] Add improvements suggested by checkpatch for vmbus_drv Wei Liu
2020-11-25 0:53 ` Matheus Castello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60b60d026a0636090b1617c6fd9e7b3a88013a7f.camel@perches.com \
--to=joe@perches.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matheus@castello.eng.br \
--cc=mikelley@microsoft.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox