From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yunhong Jiang <yunhong.jiang@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, rafael@kernel.org, lenb@kernel.org,
kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox
Date: Thu, 8 Aug 2024 09:41:16 +0200 [thread overview]
Message-ID: <624e1985-7dd2-4abe-a918-78cb43556967@kernel.org> (raw)
In-Reply-To: <20240807165658.GA17382@yjiang5-mobl.amr.corp.intel.com>
On 07/08/2024 18:56, Yunhong Jiang wrote:
> On Wed, Aug 07, 2024 at 07:57:43AM +0200, Krzysztof Kozlowski wrote:
>> On 07/08/2024 00:12, Yunhong Jiang wrote:
>>> Add the binding to use the ACPI wakeup mailbox mechanism to bringup APs.
>>
>> We do not have bindings for ACPI. I think in the past it was mentioned
>> pretty clear - we do not care what ACPI has in the wild.
>
> Thank you for review.
> Can you please give a bit more information on "do not have bindings for ACPI"?
> We don't put the ACPI table into the device tree, but reuse some existing ACPI
> mailbox mechanism. Is this acceptable for you?
I understood that rationale behind this patch is "ACPI" thus that reply.
This one sentence in commit msg is not helping. Entire binding
description speaks about ACPI, so yeah - I don't care what ACPI does.
Provide proper explanation/description of firmware or hardware, then
sure. But the patch saying ACPI is doing something, so bindings will be
doing the same is for me NAK. Whatever ACPI is doing is never a reason
alone to do the same in Devicetree.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-08 7:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 22:12 [PATCH 0/7] x86/acpi: Move ACPI MADT wakeup to generic code Yunhong Jiang
2024-08-06 22:12 ` [PATCH 1/7] " Yunhong Jiang
2024-08-06 22:12 ` [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox Yunhong Jiang
2024-08-06 23:38 ` Rob Herring (Arm)
2024-08-07 17:00 ` Yunhong Jiang
2024-08-07 5:57 ` Krzysztof Kozlowski
2024-08-07 16:56 ` Yunhong Jiang
2024-08-08 7:41 ` Krzysztof Kozlowski [this message]
2024-08-09 23:29 ` Yunhong Jiang
2024-08-06 22:12 ` [PATCH 3/7] x86/dt: Support the ACPI multiprocessor wakeup for device tree Yunhong Jiang
2024-08-07 16:50 ` Thomas Gleixner
2024-08-06 22:12 ` [PATCH 4/7] x86/hyperv: Parse the ACPI wakeup mailbox Yunhong Jiang
2024-08-06 22:12 ` [PATCH 5/7] x86/hyperv: Mark ACPI wakeup mailbox page as private Yunhong Jiang
2024-08-07 16:59 ` Thomas Gleixner
2024-08-09 23:17 ` Yunhong Jiang
2024-08-06 22:12 ` [PATCH 6/7] x86/hyperv: Reserve real mode when ACPI wakeup mailbox is available Yunhong Jiang
2024-08-07 17:33 ` Thomas Gleixner
2024-08-24 0:17 ` Yunhong Jiang
2024-08-06 22:12 ` [PATCH 7/7] x86/hyperv: Use the ACPI wakeup mailbox for VTL2 guests when available Yunhong Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624e1985-7dd2-4abe-a918-78cb43556967@kernel.org \
--to=krzk@kernel.org \
--cc=bp@alien8.de \
--cc=conor+dt@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=kys@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
--cc=yunhong.jiang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).