From: Naman Jain <namjain@linux.microsoft.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: "K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Long Li <longli@microsoft.com>,
Michael Kelley <mhklinux@outlook.com>,
linux-hyperv@vger.kernel.org,
Saurabh Sengar <ssengar@linux.microsoft.com>
Subject: Re: [PATCH v2] tools/hv: fcopy: Fix irregularities with size of ring buffer
Date: Wed, 2 Jul 2025 11:01:48 +0530 [thread overview]
Message-ID: <630a37bf-7ed5-42fb-ae64-6f6a29161d2e@linux.microsoft.com> (raw)
In-Reply-To: <20250701131532.125b960c.olaf@aepfle.de>
On 7/1/2025 4:45 PM, Olaf Hering wrote:
> Tue, 1 Jul 2025 16:18:37 +0530 Naman Jain <namjain@linux.microsoft.com>:
>
>> + syslog(LOG_ERR, "Could not determine ring size, using default: %u bytes",
>> + HV_RING_SIZE_DEFAULT);
>
> I think this is not an actionable error.
> Maybe use the default just silently?
>
>
> Olaf
So let's suppose a case, where the actual ring buffer size was different
than the default value, and for some reason, we were not able to
determine the ring size from the sysfs entry. This results in wrong size
configured in FCopy daemon. FCopy does not work in that scenario and
silently fails. We would definitely like to inform that to the user.
Default size case is just to provide a best effort way of making it
work.
I am fine to change it to LOG_INFO or keep it the same. Please let me
know your thoughts.
Regards,
Naman
next prev parent reply other threads:[~2025-07-02 5:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 10:48 [PATCH v2] tools/hv: fcopy: Fix irregularities with size of ring buffer Naman Jain
2025-07-01 11:15 ` Olaf Hering
2025-07-02 5:31 ` Naman Jain [this message]
2025-07-02 6:32 ` [EXTERNAL] " Long Li
2025-07-02 6:56 ` Naman Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=630a37bf-7ed5-42fb-ae64-6f6a29161d2e@linux.microsoft.com \
--to=namjain@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mhklinux@outlook.com \
--cc=olaf@aepfle.de \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox