From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hardik Garg <hargar@linux.microsoft.com>
Cc: apais@microsoft.com, conor+dt@kernel.org, decui@microsoft.com,
devicetree@vger.kernel.org, haiyangz@microsoft.com,
hargar@microsoft.com, krzk+dt@kernel.org, kys@microsoft.com,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
robh@kernel.org, ssengar@linux.microsoft.com, wei.liu@kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: microsoft: Add vmbus message-connection-id property
Date: Mon, 14 Jul 2025 09:56:57 +0200 [thread overview]
Message-ID: <63ca8d08-2fd3-440e-858a-f8d79890016f@kernel.org> (raw)
In-Reply-To: <1752479327-19753-1-git-send-email-hargar@linux.microsoft.com>
On 14/07/2025 09:48, Hardik Garg wrote:
> Thank you for your review, Krzysztof. I apologize for the delay in
> my response.
You got review after 8 hours.
You respond after 3 weeks.
>
>>> What is a connection ID and why it cannot be inferred from existing
>>> system API?
>
> The connection-id determines which hypervisor communication channel the
> guest should use to talk to the VMBus host. Reading from DeviceTree allows
> platforms to specify their preferred communication channel, making it more
> flexible (I will add this detail in the commit message). Presently, this
We don't add properties to make things flexible.
> value is hardcoded and there is no existing API to read it.
>
>>> There's a reason why you have here generic property - this is generic
>>> and/or discoverable and/or whatever software interface. Adding now more
>>> properties, just because you made it generic, is not the way.
>
> Presently the value is hardcoded and we want to provide a functionality to
> the user to specify their prefered communication channel. This is a
> virtualized hardware property for us.
That's not really acceptable reason. With such approach I would add 100
properties to make various things "flexible".
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-14 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 23:06 [PATCH v4 0/2] vmbus: Add DeviceTree support for message connection-id Hardik Garg
2025-06-19 23:06 ` [PATCH v4 1/2] dt-bindings: microsoft: Add vmbus message-connection-id property Hardik Garg
2025-06-20 7:21 ` Krzysztof Kozlowski
2025-07-14 7:48 ` Hardik Garg
2025-07-14 7:56 ` Krzysztof Kozlowski [this message]
2025-07-16 4:42 ` Hardik Garg
2025-07-16 14:35 ` Krzysztof Kozlowski
2025-07-23 3:08 ` Hardik Garg
2025-07-23 6:18 ` Krzysztof Kozlowski
2025-07-24 22:12 ` Hardik Garg
2025-07-25 7:32 ` Krzysztof Kozlowski
2025-06-19 23:06 ` [PATCH v4 2/2] vmbus: retrieve connection-id from DeviceTree Hardik Garg
2025-06-20 2:36 ` Michael Kelley
2025-06-20 7:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ca8d08-2fd3-440e-858a-f8d79890016f@kernel.org \
--to=krzk@kernel.org \
--cc=apais@microsoft.com \
--cc=conor+dt@kernel.org \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=haiyangz@microsoft.com \
--cc=hargar@linux.microsoft.com \
--cc=hargar@microsoft.com \
--cc=krzk+dt@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).