From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, longli@microsoft.com, mhklinux@outlook.com,
prapal@linux.microsoft.com, mrathor@linux.microsoft.com,
paekkaladevi@linux.microsoft.com,
Jinank Jain <jinankjain@microsoft.com>
Subject: Re: [PATCH 3/3] mshv: Add debugfs to view hypervisor statistics
Date: Thu, 4 Dec 2025 10:57:31 -0800 [thread overview]
Message-ID: <6704d1d1-9968-451a-8771-f4754b9a2126@linux.microsoft.com> (raw)
In-Reply-To: <aTCNoecOOFHabyZC@skinsburskii.localdomain>
On 12/3/2025 11:21 AM, Stanislav Kinsburskii wrote:
> On Wed, Dec 03, 2025 at 09:53:25AM -0800, Nuno Das Neves wrote:
>> Introduce a debugfs interface to expose root and child partition stats
>> when running with mshv_root.
>>
>
> <snip>
>> +static void mshv_debugfs_parent_partition_remove(void)
>
> nit: it makes sense to add __exit to this method.
>
> <snip>
>
>> +
>> +void mshv_debugfs_exit(void)
>
> Ditto.
It looks like __exit is purposely omitted here, because
mshv_debugfs_exit() is called in the error cleanup path of
mshv_parent_partition_init().
Thanks
Nuno
>
> Reviewed-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
>
> Thanks,
> Stanislav
prev parent reply other threads:[~2025-12-04 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 17:53 [PATCH 0/3] mshv: Debugfs interface for mshv_root Nuno Das Neves
2025-12-03 17:53 ` [PATCH 1/3] mshv: Ignore second stats page map result failure Nuno Das Neves
2025-12-03 19:03 ` Stanislav Kinsburskii
2025-12-03 21:43 ` Nuno Das Neves
2025-12-03 17:53 ` [PATCH 2/3] mshv: Add definitions for stats pages Nuno Das Neves
2025-12-03 19:06 ` Stanislav Kinsburskii
2025-12-03 21:58 ` Nuno Das Neves
2025-12-03 17:53 ` [PATCH 3/3] mshv: Add debugfs to view hypervisor statistics Nuno Das Neves
2025-12-03 19:21 ` Stanislav Kinsburskii
2025-12-04 18:57 ` Nuno Das Neves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6704d1d1-9968-451a-8771-f4754b9a2126@linux.microsoft.com \
--to=nunodasneves@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=jinankjain@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mhklinux@outlook.com \
--cc=mrathor@linux.microsoft.com \
--cc=paekkaladevi@linux.microsoft.com \
--cc=prapal@linux.microsoft.com \
--cc=skinsburskii@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox