linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Kisel <romank@linux.microsoft.com>
To: Nuno Das Neves <nunodasneves@linux.microsoft.com>,
	hpa@zytor.com, kys@microsoft.com, bp@alien8.de,
	dave.hansen@linux.intel.com, decui@microsoft.com,
	eahariha@linux.microsoft.com, haiyangz@microsoft.com,
	mingo@redhat.com, mhklinux@outlook.com, tglx@linutronix.de,
	tiala@microsoft.com, wei.liu@kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: apais@microsoft.com, benhill@microsoft.com,
	ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev
Subject: Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode
Date: Wed, 8 Jan 2025 13:22:13 -0800	[thread overview]
Message-ID: <729f82d5-804c-417c-a050-29682fd5eed8@linux.microsoft.com> (raw)
In-Reply-To: <b4a27944-7622-429c-9e59-602f727363b2@linux.microsoft.com>



On 1/8/2025 1:08 PM, Nuno Das Neves wrote:
> On 12/30/2024 10:09 AM, Roman Kisel wrote:

[...]

> Replying in a new thread since I don't have all the context about the different
> VTL code paths that may need to converge. To my perspective, the approach in this
> patch seems perfectly reasonable to fix the current issue.
> 
> One small improvement might be to put this check into a helper function. That would
> make it easier to amend later when/if a clearly better solution is proposed.
> 
> Something like:
> 
> static inline bool hv_output_page_exists()
> {
> 	return hv_root_partition || IS_ENABLED(CONFIG_HYPERV_VTL_MODE);
> }

Will apply, thank you for the suggestion, Nuno!

> 
> Thanks
> Nuno

-- 
Thank you,
Roman


  reply	other threads:[~2025-01-08 21:22 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30 18:09 [PATCH v5 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id() Roman Kisel
2024-12-30 18:09 ` [PATCH v5 1/5] hyperv: Define struct hv_output_get_vp_registers Roman Kisel
2025-01-06 17:37   ` Michael Kelley
2025-01-06 20:24     ` Roman Kisel
2025-01-08  7:34       ` Wei Liu
2025-01-08 17:48         ` Roman Kisel
2025-01-08 17:58     ` Nuno Das Neves
2025-01-08 18:22       ` Michael Kelley
2025-01-08 18:29         ` Roman Kisel
2024-12-30 18:09 ` [PATCH v5 2/5] hyperv: Fix pointer type in get_vtl(void) Roman Kisel
2025-01-08 17:59   ` Nuno Das Neves
2024-12-30 18:09 ` [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode Roman Kisel
2025-01-03 19:20   ` Stanislav Kinsburskii
2025-01-03 21:39     ` Roman Kisel
2025-01-06 17:11       ` Stanislav Kinsburskii
2025-01-06 18:11         ` Roman Kisel
2025-01-06 19:32           ` Stanislav Kinsburskii
2025-01-06 21:07             ` Roman Kisel
2025-01-07 19:18               ` Stanislav Kinsburskii
2025-01-07 23:11                 ` Roman Kisel
2025-01-08  8:04                   ` Wei Liu
2025-01-08 19:17                   ` Stanislav Kinsburskii
2025-01-08 20:37                     ` Roman Kisel
2025-01-08 22:19                       ` Stanislav Kinsburskii
2025-01-08 23:04                         ` Roman Kisel
2025-01-03 22:08     ` Michael Kelley
     [not found]       ` <CAJ-90NKKfF-KcWJ7sdMCXK9fWiXwMG-9xtjQn9fVhXgjRinZbA@mail.gmail.com>
2025-01-06 14:53         ` Alex Ionescu
2025-01-06 16:10           ` Michael Kelley
2025-01-06 17:23       ` Stanislav Kinsburskii
2025-01-06 18:18         ` Michael Kelley
2025-01-06 19:19           ` Stanislav Kinsburskii
2025-01-06 19:49             ` Michael Kelley
2025-01-06 21:12               ` Stanislav Kinsburskii
2025-01-08 21:08   ` Nuno Das Neves
2025-01-08 21:22     ` Roman Kisel [this message]
2024-12-30 18:09 ` [PATCH v5 4/5] hyperv: Do not overlap the hvcall IO areas in get_vtl() Roman Kisel
2025-01-08  7:36   ` Wei Liu
2025-01-08 17:47     ` Roman Kisel
2024-12-30 18:09 ` [PATCH v5 5/5] hyperv: Do not overlap the hvcall IO areas in hv_vtl_apicid_to_vp_id() Roman Kisel
2024-12-30 18:16 ` [PATCH v5 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id() Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=729f82d5-804c-417c-a050-29682fd5eed8@linux.microsoft.com \
    --to=romank@linux.microsoft.com \
    --cc=apais@microsoft.com \
    --cc=benhill@microsoft.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=eahariha@linux.microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=mingo@redhat.com \
    --cc=nunodasneves@linux.microsoft.com \
    --cc=ssengar@microsoft.com \
    --cc=sunilmut@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=tiala@microsoft.com \
    --cc=vdso@hexbites.dev \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).