From: Paolo Abeni <pabeni@redhat.com>
To: Haiyang Zhang <haiyangz@linux.microsoft.com>,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org
Cc: haiyangz@microsoft.com, paulros@microsoft.com,
decui@microsoft.com, kys@microsoft.com, wei.liu@kernel.org,
edumazet@google.com, davem@davemloft.net, kuba@kernel.org,
longli@microsoft.com, ssengar@linux.microsoft.com,
ernis@linux.microsoft.com, dipayanroy@linux.microsoft.com,
kotaranov@microsoft.com, horms@kernel.org,
shradhagupta@linux.microsoft.com, leon@kernel.org,
mlevitsk@redhat.com, yury.norov@gmail.com,
shirazsaleem@microsoft.com, andrew+netdev@lunn.ch,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next, v3] net: mana: Support HW link state events
Date: Tue, 28 Oct 2025 15:31:28 +0100 [thread overview]
Message-ID: <76598660-8b8e-4fe6-974b-5f3eb431a1ec@redhat.com> (raw)
In-Reply-To: <1761270105-27215-1-git-send-email-haiyangz@linux.microsoft.com>
On 10/24/25 3:41 AM, Haiyang Zhang wrote:
> @@ -3243,6 +3278,8 @@ static int mana_probe_port(struct mana_context *ac, int port_idx,
> goto free_indir;
> }
>
> + netif_carrier_on(ndev);
Why is the above needed? I thought mana_link_state_handle() should kick
and set the carrier on as needed???
/P
next prev parent reply other threads:[~2025-10-28 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 1:41 [net-next, v3] net: mana: Support HW link state events Haiyang Zhang
2025-10-28 14:31 ` Paolo Abeni [this message]
2025-10-28 19:36 ` [EXTERNAL] " Haiyang Zhang
2025-10-28 22:01 ` Jakub Kicinski
2025-10-29 13:20 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76598660-8b8e-4fe6-974b-5f3eb431a1ec@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=dipayanroy@linux.microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=haiyangz@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mlevitsk@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulros@microsoft.com \
--cc=shirazsaleem@microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).