From: Jork Loeser <jloeser@linux.microsoft.com>
To: mhklinux@outlook.com
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, longli@microsoft.com,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, hamzamahfooz@linux.microsoft.com
Subject: Re: [PATCH 1/1] mshv: Add conditional VMBus dependency
Date: Thu, 21 May 2026 14:19:53 -0700 (PDT) [thread overview]
Message-ID: <79f77f98-f91-4cf-47ca-c986faed5055@linux.microsoft.com> (raw)
In-Reply-To: <20260521164921.1995-1-mhklkml@zohomail.com>
On Thu, 21 May 2026, Michael Kelley wrote:
> From: Michael Kelley <mhklinux@outlook.com>
> * Add #ifdefs around MSHV SynIC calls to hv_vmbus_exists(). When
Could as well do an empty definition of hv_vmbus_exists() if VMBUS is not
configured, no?
> diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> index 2d0b3fcb0ff8..aa11bcefddf2 100644
> --- a/drivers/hv/Kconfig
> +++ b/drivers/hv/Kconfig
> @@ -74,6 +74,7 @@ config MSHV_ROOT
> # e.g. When withdrawing memory, the hypervisor gives back 4k pages in
> # no particular order, making it impossible to reassemble larger pages
> depends on PAGE_SIZE_4KB
> + depends on HYPERV_VMBUS if HYPERV_VMBUS
Nice, thanks!
Reviewed-by: Jork Loeser <jloeser@linux.microsoft.com>
next prev parent reply other threads:[~2026-05-21 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 16:49 [PATCH 1/1] mshv: Add conditional VMBus dependency Michael Kelley
2026-05-21 20:15 ` Arnd Bergmann
2026-05-21 21:17 ` Michael Kelley
2026-05-21 21:19 ` Jork Loeser [this message]
2026-05-21 21:41 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f77f98-f91-4cf-47ca-c986faed5055@linux.microsoft.com \
--to=jloeser@linux.microsoft.com \
--cc=arnd@arndb.de \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hamzamahfooz@linux.microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mhklinux@outlook.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox