From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13E782110E for ; Sat, 4 Nov 2023 19:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YOlzPi1O"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="9kWiki06" Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8CAE184; Sat, 4 Nov 2023 12:13:29 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1699125207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MJCihwPTy5OwZN2NTsf1hJfW4cndlqjv9l25lruXqKw=; b=YOlzPi1OQjXip78U4kukgs9z7VijKGU20xncuBg/RxHlSz675Gm3CggyE9xTDjoUkVlbRE N/1PzhG3/AwCNqL7uZh3R14Jz62geTGgkq/cpS6gXbl5wZO9ZtPGOeNbmjUYI9jDKMLOQ4 x0sq/u45XmGuvm8/pvmllH5ugMcpHxyHsYDsYL/SwgzQwZ6K0p4LLUnRUp5AaTOl1gbvUX hyfPzR0/tpy3g+i+vP5NZZ4oIBgzxtbfKJyb7Loym5OUu2kZB/4+F9U/i2umGJt++mDlB4 4NLWmJerDVryX5Ht4q9WtTgb0jsvwRq/vei9dUly3wN17ObPuySSTtzyf5Tp5g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1699125207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MJCihwPTy5OwZN2NTsf1hJfW4cndlqjv9l25lruXqKw=; b=9kWiki06mJPN5/FQqpV/mkXRpWL5jFTRyvL5i9qYAv72d2P2E1/NweXPn92zQ+H0y6Yf3l kfp3Tiq1hdn2N1Cw== To: Andrew Cooper , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steve Wahl , Justin Ernst , Kyle Meyer , Dimitri Sivanich , Russ Anderson , Darren Hart , Andy Shevchenko , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Andrew Cooper Subject: Re: [PATCH 1/3] x86/apic: Drop apic::delivery_mode In-Reply-To: <20231102-x86-apic-v1-1-bf049a2a0ed6@citrix.com> References: <20231102-x86-apic-v1-0-bf049a2a0ed6@citrix.com> <20231102-x86-apic-v1-1-bf049a2a0ed6@citrix.com> Date: Sat, 04 Nov 2023 20:13:26 +0100 Message-ID: <8734xljprd.ffs@tglx> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Nov 02 2023 at 12:26, Andrew Cooper wrote: > This field is set to APIC_DELIVERY_MODE_FIXED in all cases, and is read > exactly once. Fold the constant in uv_program_mmr() and drop the field. > > Searching for the origin of the stale HyperV comment reveals commit > a31e58e129f7 ("x86/apic: Switch all APICs to Fixed delivery mode") which > notes: > > As a consequence of this change, the apic::irq_delivery_mode field is > now pointless, but this needs to be cleaned up in a separate patch. > > 6 years is long enough for this technical debt to have survived. Guilty as charged. :) Thanks for spotting this and cleaning it up! tglx