From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7251020C49C; Wed, 6 Nov 2024 23:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730937307; cv=none; b=laH519bqBVKbNsVHm/20itnLaP/HuWo4m0YoL6LXLGv9b/pm44EMuBX20GHjJ7jUNgaiggLuUgCa9uJkUqrY0jKnwR3PPx9d6NI++M3EPXFDD1BoodKjjjGnJu1Mq9eAI4hK8rqH4bZRYPTFfN9q7xq++2ZBfxjfbneHv4bD4dU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730937307; c=relaxed/simple; bh=vNSvR6RPvToIboxnKWjgc1Wvy57AFHKs9bVAobojDsI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=C9NzPtl/nqn6O7SWdxJZWCQQbQOeLxSBZ3oN9NMFCNN7mX8taNvgndlEv7MUsGaqceGcaKxuu3WZ9cNNkeLWQbRAN/KRNe5LTiLn/DOV7loVqoHjrMKyNAUU3SOXJf60U6jw6B3mXL1mvhXC0OaRW7oWog1dBIF404pp19lyu+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=X8KvauNM; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=rXy4CBfQ; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="X8KvauNM"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="rXy4CBfQ" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1730937304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eBXHsZBlly+B2Lt9SYOMrYNWSUlMWOnyJJVlusbvvcs=; b=X8KvauNMp535HneoyTufxEYHA+4BGbwzdWwnI8d/BUb3rozDITicZZo9wbfxx5QCnpLyOk KLFsY284J4ggbawlughRISSfc9lD3NWss73De0pSau6WJCX28BGzR8aUwWGzzt/6l3eJj5 zWSnUxS84K0iiY+/ksroQqVmbJa5aFRyF89oppWqlWcYwUu8pPDaDIY++IXZ9rkkAmD0mI 9pVmvfY3sHnnu4hufxPEfj6ajkjhmsSenSoofHvsGb16Da0fdhAlhJyWNMXL2fvgMO/m1Z MyBItZpTNC7nNbEU9xv+IoyGbpXrFfY/n8M7yF5bSq3QRBirQkEB7dG3R5IKEw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1730937304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eBXHsZBlly+B2Lt9SYOMrYNWSUlMWOnyJJVlusbvvcs=; b=rXy4CBfQ8Vb+0GN983u0SpHvrdvUUJUNKP3e9bgR+A75cA0HVAB8V9Epdn/ewfNPGnK7e8 ocs1dS5lXF1kSZBQ== To: David Laight , Geert Uytterhoeven Cc: Easwar Hariharan , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "linux-hyperv@vger.kernel.org" , Anna-Maria Behnsen , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "linux-bluetooth@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michael Kelley Subject: RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies() In-Reply-To: <6acb24504a454638848dd9adff7cb5dc@AcuMS.aculab.com> References: <20241028-open-coded-timeouts-v2-0-c7294bb845a1@linux.microsoft.com> <20241028-open-coded-timeouts-v2-1-c7294bb845a1@linux.microsoft.com> <87wmhq28o6.ffs@tglx> <87ed3y255a.ffs@tglx> <6acb24504a454638848dd9adff7cb5dc@AcuMS.aculab.com> Date: Thu, 07 Nov 2024 00:55:05 +0100 Message-ID: <874j4jq5nq.ffs@tglx> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Nov 06 2024 at 22:19, David Laight wrote: > From: Thomas Gleixner >> Still the macro should be documented. > > I was wondering if it really had any purpose at all. > It just obfuscates code, doesn't even make it smaller. What is obfuscated here? secs_to_jiffies() is clearly describing what this is about, while 5 * HZ is not. Nothing in a driver has to care about the underlying conversion of a time delta expressed in SI units to a jiffies based time delta. Thanks, tglx