From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6A9C83F33 for ; Mon, 4 Sep 2023 13:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235096AbjIDNGA (ORCPT ); Mon, 4 Sep 2023 09:06:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232426AbjIDNF7 (ORCPT ); Mon, 4 Sep 2023 09:05:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E493CC7 for ; Mon, 4 Sep 2023 06:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693832712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JGDuo0fidzIyb7lQTlkFMMjSr0JbZNOTrueOM/c6sEY=; b=T5zWLRHrBVs1USqX/tvB5tN2WMDSXsH1eXhwvC8fsQ+zR+BLJAY+ZK+8eQX7saTwKWQtjA 4LM34LkAfFrcqjbiVQVcW8ckeNShrt27IxgXRAwe5mjqnMOdl1HwmMOcNcWf86wHbxP+xC eyEtsPaVLx0lEyVLKbzyky9KEXT88W0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-UtOp-xZiN-eLUwh_XWaEEA-1; Mon, 04 Sep 2023 09:05:11 -0400 X-MC-Unique: UtOp-xZiN-eLUwh_XWaEEA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31aef4011cfso809141f8f.2 for ; Mon, 04 Sep 2023 06:05:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693832710; x=1694437510; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JGDuo0fidzIyb7lQTlkFMMjSr0JbZNOTrueOM/c6sEY=; b=DzRrPxlzfdTYlHiF40QaPCtIhWNDkgpkHol21tZiUK2POXnICK4Yalm5cctYY486Yh iRRSFxE3lejv1iDjkfiLCaruQxa14B0NuY8cVowcLwrZXyNOtFkl5YlpS1SF5lPGIkNs lAPszimyj1j8I0HRk9U78W4sPdxiJWf2KoGgBZ5JQtW7HDEKdSOek2/m91IxNxqq4VGy eIFcAE7m3dThsnuVHuUwV+ugFIDUojCTmp1zADWZe6G51QYT3Pu7x+mpuPmUqYRPQTER AZ/1fHf6TNFfhFZUC5IY+tOExMzDS7mSgb8RFIQDMVX9KpccIbkk5oA1gnj96F4dliPM VQpg== X-Gm-Message-State: AOJu0YwB476dvM/GsqKJ18r8e4SuWNU+4P79GMRJIf49b3zc3CgrY/Ut /E+ZlRQtYg0r9EzwhAhz/nBEDVSfuA2XkTFliVXv/dPzbqPD03ZwteEXzVsL+tNuIENj0hYXzCr yph/5odBKPjE++Q4V4D1wrcMS X-Received: by 2002:a05:6000:1cd:b0:317:5de3:86fb with SMTP id t13-20020a05600001cd00b003175de386fbmr7162731wrx.10.1693832709956; Mon, 04 Sep 2023 06:05:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXjVWzCt7e02jUxRGN8dZzdROG6Y6I7k2Dqt3rSE/+w+cQmE9Wq23/UuCwnni8eIyMrEIxCA== X-Received: by 2002:a05:6000:1cd:b0:317:5de3:86fb with SMTP id t13-20020a05600001cd00b003175de386fbmr7162714wrx.10.1693832709657; Mon, 04 Sep 2023 06:05:09 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id f7-20020adffcc7000000b0031c7682607asm14485436wrs.111.2023.09.04.06.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Sep 2023 06:05:09 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , deller@gmx.de, daniel@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-staging@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, Thomas Zimmermann , Bernie Thompson Subject: Re: [PATCH 2/8] fbdev/udlfb: Use fb_ops helpers for deferred I/O In-Reply-To: <20230828132131.29295-3-tzimmermann@suse.de> References: <20230828132131.29295-1-tzimmermann@suse.de> <20230828132131.29295-3-tzimmermann@suse.de> Date: Mon, 04 Sep 2023 15:05:08 +0200 Message-ID: <874jka6qd7.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org Thomas Zimmermann writes: > Generate callback functions for struct fb_ops with the fbdev macro > FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to > the generated functions with fbdev initializer macros. > > Signed-off-by: Thomas Zimmermann > Cc: Bernie Thompson > --- Acked-by: Javier Martinez Canillas [...] > +static void dlfb_ops_damage_range(struct fb_info *info, off_t off, size_t len) > +{ > + struct dlfb_data *dlfb = info->par; > + int start = max((int)(off / info->fix.line_length), 0); > + int lines = min((u32)((len / info->fix.line_length) + 1), (u32)info->var.yres); > + > + dlfb_handle_damage(dlfb, 0, start, info->var.xres, lines); > +} > + > +static void dlfb_ops_damage_area(struct fb_info *info, u32 x, u32 y, u32 width, u32 height) > +{ > + struct dlfb_data *dlfb = info->par; > + > + dlfb_offload_damage(dlfb, x, y, width, height); > +} > + These two are very similar to the helpers you added for the smscufx driver in patch #1. I guess there's room for further consolidation as follow-up ? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat