linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Cc: KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] arm64: hyperv: make the format of 'Hyper-V: Host Build' output match x86
Date: Sun, 06 Mar 2022 11:51:51 +0100	[thread overview]
Message-ID: <875yorbbg8.fsf@redhat.com> (raw)
In-Reply-To: <MN0PR21MB309826D5A9E262A65E0E07F9D7059@MN0PR21MB3098.namprd21.prod.outlook.com>

"Michael Kelley (LINUX)" <mikelley@microsoft.com> writes:

> From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Friday, March 4, 2022 4:24 AM
>> 
>> Currently, the following is observed on Hyper-V/ARM:
>> 
>>  Hyper-V: Host Build 10.0.22477.1061-1-0
>> 
>> This differs from similar output on x86:
>> 
>>  Hyper-V Host Build:20348-10.0-1-0.1138
>> 
>> and this is inconvenient. As x86 was the first to introduce the current
>> format and to not break existing tools parsing it, change the format on
>> ARM to match.
>
> Interesting.  I had explicitly output this line differently on ARM64 so
> that the output is in the standard form of a Windows version number,
> which is what the Host Build value actually is.  My intent is to fix the
> x86 side as well.  I had not anticipated there being automated parsing
> of these strings.
>
> I had also put the colon in the place to be consistent with most
> other Hyper-V messages.  I know:  picky, picky. :-)
>
> What's the impact of changing the tools that parse it so that
> either version could be handled?

I wish we knew what tools are out there parsing this line :-) The issue
got reported by QA as 'inconsistency'.

As the format of this string was never promissed to be an ABI I think we
can go the other way around: change x86 to match ARM. Some scripts may
need fixing but IMO this is acceptable. Let's just promiss to not change
it in the future :-)

-- 
Vitaly


      reply	other threads:[~2022-03-06 10:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 12:24 [PATCH] arm64: hyperv: make the format of 'Hyper-V: Host Build' output match x86 Vitaly Kuznetsov
2022-03-04 18:22 ` Michael Kelley (LINUX)
2022-03-06 10:51   ` Vitaly Kuznetsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yorbbg8.fsf@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=sthemmin@microsoft.com \
    --cc=wei.liu@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).