From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-hyperv-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D2AC2C433FE
	for <linux-hyperv@archiver.kernel.org>; Sun, 13 Nov 2022 21:19:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232799AbiKMVTv (ORCPT <rfc822;linux-hyperv@archiver.kernel.org>);
        Sun, 13 Nov 2022 16:19:51 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42716 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230525AbiKMVTu (ORCPT
        <rfc822;linux-hyperv@vger.kernel.org>);
        Sun, 13 Nov 2022 16:19:50 -0500
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3212363F8;
        Sun, 13 Nov 2022 13:19:49 -0800 (PST)
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1668374387;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=BfbygagHNtZ439/ix5hRvKwJ52ZWwUhrEYQ5rP7sRBE=;
        b=bNgU8BMmemo2cGpkQIoeTIj4xSyfGBWUmPWPUIn9ifDxEYxr1fEErm/iqthDVoZiBDX4L9
        KT+0mgTDrf+eOLXDB6I4pIY74LOwX4uY/3YRdDvM/NGzOpdCsKhc0tCOXocVTdCV6HrW96
        jYCSJSFVzc9piwtvNUfseZcVRfd5x+kk3JLO1MpXCR8Rg2dbjXiNR0TwDRNCmDEO94566X
        jtfIrwn5QxqvDqxjNryVHULOKwkBv4QDE9R4jJGFCVoZkHZOQhVC7LdWILBKfOKUM3XK7F
        sjnsBRKXhbkVjBxnTn7lOLfUHRXVgz3Ggy6MATfG4WclmBS7l1dX84qGvs7llg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1668374387;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=BfbygagHNtZ439/ix5hRvKwJ52ZWwUhrEYQ5rP7sRBE=;
        b=kO7yD3qVxXKEqcZNfNq6vKxyRAtwuqlBC6Rkx9ogz5EH535zisFNPdGbI8Lj1pqikowSvP
        sjXRL5Rjl4Wz/2AA==
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Andy Lutomirski <luto@kernel.org>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: RE: [PATCH] clocksource/drivers/hyper-v: Include asm/hyperv-tlfs.h
 not asm/mshyperv.h
In-Reply-To: <BYAPR21MB1688DCC2BDD263042B499D84D7029@BYAPR21MB1688.namprd21.prod.outlook.com>
References: <87zgcwt2qg.ffs@tglx>
 <BYAPR21MB1688C5BCDF3269BA070DB884D7039@BYAPR21MB1688.namprd21.prod.outlook.com>
 <87wn7ztc89.ffs@tglx>
 <BYAPR21MB1688DCC2BDD263042B499D84D7029@BYAPR21MB1688.namprd21.prod.outlook.com>
Date:   Sun, 13 Nov 2022 22:19:46 +0100
Message-ID: <87iljituvh.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-hyperv.vger.kernel.org>
X-Mailing-List: linux-hyperv@vger.kernel.org

On Sun, Nov 13 2022 at 13:12, Michael Kelley wrote:
> From: Thomas Gleixner <tglx@linutronix.de> Sent: Sunday, November 13, 2022 1:50 AM
>> On Sat, Nov 12 2022 at 21:55, Michael Kelley wrote:
>> > But I can see the problem with too much getting dragged into the VDSO
>> > builds.  If hv_get_raw_timer() is added to hyperv_timer.h, it should
>> > be under #ifdef CONFIG_X86.  Adding an #ifdef isn't ideal, and a more
>> > more proper solution might be to have a separate hyperv_timer.h include
>> > file under arch/x86/include/asm.  But the latter seems like overkill for just
>> > hv_get_raw_timer(), so I'm OK with the #ifdef.
>> 
>> We surely can have asm/hyperv_timer.h but TBH:
>> 
>> >>  static inline notrace u64
>> >>  hv_read_tsc_page_tsc(const struct ms_hyperv_tsc_page *tsc_pg, u64 *cur_tsc)
>> >>  {
>> 
>> hv_read_tsc_page_tsc() does not look architecture agnostic either. TSC
>> is pretty x86 specific :)
>
> Yes, the naming still says "tsc".  But there's nothing in the code that actually
> requires the TSC if hv_get_raw_timer() maps to some other hardware counter on
> a different architecture.   That's why the hv_get_raw_timer() abstraction is there
> in the first place.  If we didn't care about x86-isms, hv_read_tsc_page_tsc() would
> just directly invoke rdtsc_ordered().

Not really intuitive, but anyway...