From: Thomas Gleixner <tglx@linutronix.de>
To: David Woodhouse <dwmw2@infradead.org>,
lirongqing@baidu.com, seanjc@google.com, kys@microsoft.com,
haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown
Date: Fri, 02 Aug 2024 12:49:32 +0200 [thread overview]
Message-ID: <87plqr19oj.ffs@tglx> (raw)
In-Reply-To: <56d3780bc42c98721e15129b7fd53080c4530760.camel@infradead.org>
On Fri, Aug 02 2024 at 09:07, David Woodhouse wrote:
> On Thu, 2024-08-01 at 20:57 +0200, Thomas Gleixner wrote:
>> It's not counting right out of reset. But once it started counting it's
>> tedious to stop :)
>
> My reading of the data sheet definitely suggests that it *shouldn't*
> be.
>
> Mode 0 says: "The output will be initially low after the mode set
> operation. After the count is loaded into the selected count
> register... the counter will count."
Hmm. Indeed. That does not stop the counter, but it prevents the
interrupt from firing over and over.
So fine, we can go with the patch from Li, but the changelog needs a
rewrite and the code want's a big fat comment.
Thanks,
tglx
next prev parent reply other threads:[~2024-08-02 10:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 1:14 [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown lirongqing
2023-02-08 1:04 ` Michael Kelley (LINUX)
2023-02-08 15:04 ` Sean Christopherson
2023-02-24 9:45 ` Li,Rongqing
[not found] ` <3b8496c071214bda9e5ecfa048f18ab9@baidu.com>
2023-04-13 1:28 ` Wei Liu
[not found] ` <1311175816673.202304.ZDdawTGHoa/UH20U@liuwe-devbox-debian-v2>
2023-04-14 5:17 ` Li,Rongqing
2024-08-01 9:00 ` David Woodhouse
2024-08-01 15:22 ` David Woodhouse
2024-08-01 21:07 ` Thomas Gleixner
2024-08-01 21:10 ` David Woodhouse
2024-08-01 14:21 ` Thomas Gleixner
2024-08-01 16:14 ` Michael Kelley
2024-08-01 18:54 ` Thomas Gleixner
2024-08-02 8:21 ` David Woodhouse
2024-08-02 14:55 ` Sean Christopherson
2024-08-02 15:04 ` David Woodhouse
2024-08-12 23:59 ` Sean Christopherson
2024-08-13 6:39 ` David Woodhouse
2024-08-01 17:49 ` David Woodhouse
2024-08-01 18:25 ` David Woodhouse
2024-08-01 18:57 ` Thomas Gleixner
2024-08-02 8:07 ` David Woodhouse
2024-08-02 10:49 ` Thomas Gleixner [this message]
2024-08-02 11:04 ` David Woodhouse
2024-08-02 13:27 ` Thomas Gleixner
2024-08-02 13:46 ` David Woodhouse
2024-08-01 19:06 ` Thomas Gleixner
2024-08-01 19:21 ` David Woodhouse
2024-08-01 20:00 ` Thomas Gleixner
2024-08-01 20:49 ` David Woodhouse
2024-08-01 21:22 ` Thomas Gleixner
2024-08-01 21:31 ` David Woodhouse
2024-08-02 9:55 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plqr19oj.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=dwmw2@infradead.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).